Which option is good in terms of software design?
0
I have one request interface(IRequest) and two classes(ClientAddress & ClientOrder) are implementing it and the same design is followed for Response.
I have tried to do it 2 ways-
1. With Explicit type casting by assigning class object to interface.
2. By using classes object and variable
public interface IRequest
{
string ClientId { get; set; }
}
public class ClientAddress : IRequest
{
public string ClientId { get; set; }
public string AppId { get; set; }
}
public class ClientOrder : IRequest
{
public string ClientId { get; set; }
public string FromDate { get; set; }
public string ToDate { get; set; }
//other properties
}
public interface IResponse
{
string ClientName { get; set; }
}
public class ClientAddressResponse : IResponse
{
public string ClientName { get; set; }
public string HouseNumber { get; set; }
public string Area { get; set; }
public string City { get; set; }
}
public class ClientOrderResponse : IResponse
{
public string ClientName { get; set; }
public List<Orders> OrderList { get; set; }
//other properties
}
public class DAL
{
public IResponse GetAddress(IRequest req)
{
//return client address
}
public IResponse GetOrderList(IRequest req)
{
//return order list
}
}
////Option 1:
class Program
{
static void Main(string args)
{
IRequest req1 = new ClientAddress();
req1.ClientId = 1;
((ClientAddress)req1).AppId = "abcd";
DAL d = new DAL();
IResponse res1 = d.GetAddress(req1);
IRequest req2 = new ClientOrder();
req2.ClientId = 1;
((ClientOrder)req2).FromDate = "2019/01/01";
((ClientOrder)req2).ToDate = "2019/01/15";
IResponse res2 = d.GetOrderList(req2);
}
}
////Option 2-
class Program
{
static void Main(string args)
{
ClientAddress req1 = new ClientAddress();
req1.ClientId = 1;
req1.AppId = "abcd";
DAL d = new DAL();
IResponse res1 = d.GetAddress(req1);
ClientOrder req2 = new ClientOrder();
req2.ClientId = 1;
req2.FromDate = "2019/01/01";
req2.ToDate = "2019/01/15";
IResponse res2 = d.GetOrderList(req2);
}
}
Please guide me which design is good/bad and why we should use/avoid it.
c# object-oriented design-patterns interface
asked 10 mins ago
MogliMogli
11
New contributor
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
0
I have one request interface(IRequest) and two classes(ClientAddress & ClientOrder) are implementing it and the same design is followed for Response.
I have tried to do it 2 ways-
1. With Explicit type casting by assigning class object to interface.
2. By using classes object and variable
public interface IRequest
{
string ClientId { get; set; }
}
public class ClientAddress : IRequest
{
public string ClientId { get; set; }
public string AppId { get; set; }
}
public class ClientOrder : IRequest
{
public string ClientId { get; set; }
public string FromDate { get; set; }
public string ToDate { get; set; }
//other properties
}
public interface IResponse
{
string ClientName { get; set; }
}
public class ClientAddressResponse : IResponse
{
public string ClientName { get; set; }
public string HouseNumber { get; set; }
public string Area { get; set; }
public string City { get; set; }
}
public class ClientOrderResponse : IResponse
{
public string ClientName { get; set; }
public List<Orders> OrderList { get; set; }
//other properties
}
public class DAL
{
public IResponse GetAddress(IRequest req)
{
//return client address
}
public IResponse GetOrderList(IRequest req)
{
//return order list
}
}
////Option 1:
class Program
{
static void Main(string args)
{
IRequest req1 = new ClientAddress();
req1.ClientId = 1;
((ClientAddress)req1).AppId = "abcd";
DAL d = new DAL();
IResponse res1 = d.GetAddress(req1);
IRequest req2 = new ClientOrder();
req2.ClientId = 1;
((ClientOrder)req2).FromDate = "2019/01/01";
((ClientOrder)req2).ToDate = "2019/01/15";
IResponse res2 = d.GetOrderList(req2);
}
}
////Option 2-
class Program
{
static void Main(string args)
{
ClientAddress req1 = new ClientAddress();
req1.ClientId = 1;
req1.AppId = "abcd";
DAL d = new DAL();
IResponse res1 = d.GetAddress(req1);
ClientOrder req2 = new ClientOrder();
req2.ClientId = 1;
req2.FromDate = "2019/01/01";
req2.ToDate = "2019/01/15";
IResponse res2 = d.GetOrderList(req2);
}
}
Please guide me which design is good/bad and why we should use/avoid it.
c# object-oriented design-patterns interface
asked 10 mins ago
MogliMogli
11
New contributor
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
0
0
0
I have one request interface(IRequest) and two classes(ClientAddress & ClientOrder) are implementing it and the same design is followed for Response.
I have tried to do it 2 ways-
1. With Explicit type casting by assigning class object to interface.
2. By using classes object and variable
public interface IRequest
{
string ClientId { get; set; }
}
public class ClientAddress : IRequest
{
public string ClientId { get; set; }
public string AppId { get; set; }
}
public class ClientOrder : IRequest
{
public string ClientId { get; set; }
public string FromDate { get; set; }
public string ToDate { get; set; }
//other properties
}
public interface IResponse
{
string ClientName { get; set; }
}
public class ClientAddressResponse : IResponse
{
public string ClientName { get; set; }
public string HouseNumber { get; set; }
public string Area { get; set; }
public string City { get; set; }
}
public class ClientOrderResponse : IResponse
{
public string ClientName { get; set; }
public List<Orders> OrderList { get; set; }
//other properties
}
public class DAL
{
public IResponse GetAddress(IRequest req)
{
//return client address
}
public IResponse GetOrderList(IRequest req)
{
//return order list
}
}
////Option 1:
class Program
{
static void Main(string args)
{
IRequest req1 = new ClientAddress();
req1.ClientId = 1;
((ClientAddress)req1).AppId = "abcd";
DAL d = new DAL();
IResponse res1 = d.GetAddress(req1);
IRequest req2 = new ClientOrder();
req2.ClientId = 1;
((ClientOrder)req2).FromDate = "2019/01/01";
((ClientOrder)req2).ToDate = "2019/01/15";
IResponse res2 = d.GetOrderList(req2);
}
}
////Option 2-
class Program
{
static void Main(string args)
{
ClientAddress req1 = new ClientAddress();
req1.ClientId = 1;
req1.AppId = "abcd";
DAL d = new DAL();
IResponse res1 = d.GetAddress(req1);
ClientOrder req2 = new ClientOrder();
req2.ClientId = 1;
req2.FromDate = "2019/01/01";
req2.ToDate = "2019/01/15";
IResponse res2 = d.GetOrderList(req2);
}
}
Please guide me which design is good/bad and why we should use/avoid it.
c# object-oriented design-patterns interface
asked 10 mins ago
MogliMogli
11
New contributor
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
I have one request interface(IRequest) and two classes(ClientAddress & ClientOrder) are implementing it and the same design is followed for Response.
I have tried to do it 2 ways-
1. With Explicit type casting by assigning class object to interface.
2. By using classes object and variable
public interface IRequest
{
string ClientId { get; set; }
}
public class ClientAddress : IRequest
{
public string ClientId { get; set; }
public string AppId { get; set; }
}
public class ClientOrder : IRequest
{
public string ClientId { get; set; }
public string FromDate { get; set; }
public string ToDate { get; set; }
//other properties
}
public interface IResponse
{
string ClientName { get; set; }
}
public class ClientAddressResponse : IResponse
{
public string ClientName { get; set; }
public string HouseNumber { get; set; }
public string Area { get; set; }
public string City { get; set; }
}
public class ClientOrderResponse : IResponse
{
public string ClientName { get; set; }
public List<Orders> OrderList { get; set; }
//other properties
}
public class DAL
{
public IResponse GetAddress(IRequest req)
{
//return client address
}
public IResponse GetOrderList(IRequest req)
{
//return order list
}
}
////Option 1:
class Program
{
static void Main(string args)
{
IRequest req1 = new ClientAddress();
req1.ClientId = 1;
((ClientAddress)req1).AppId = "abcd";
DAL d = new DAL();
IResponse res1 = d.GetAddress(req1);
IRequest req2 = new ClientOrder();
req2.ClientId = 1;
((ClientOrder)req2).FromDate = "2019/01/01";
((ClientOrder)req2).ToDate = "2019/01/15";
IResponse res2 = d.GetOrderList(req2);
}
}
////Option 2-
class Program
{
static void Main(string args)
{
ClientAddress req1 = new ClientAddress();
req1.ClientId = 1;
req1.AppId = "abcd";
DAL d = new DAL();
IResponse res1 = d.GetAddress(req1);
ClientOrder req2 = new ClientOrder();
req2.ClientId = 1;
req2.FromDate = "2019/01/01";
req2.ToDate = "2019/01/15";
IResponse res2 = d.GetOrderList(req2);
}
}
Please guide me which design is good/bad and why we should use/avoid it.
c# object-oriented design-patterns interface
c# object-oriented design-patterns interface
asked 10 mins ago
MogliMogli
11
New contributor
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 mins ago
MogliMogli
11
New contributor
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 mins ago
MogliMogli
11
New contributor
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 mins ago
MogliMogli
11
asked 10 mins ago
MogliMogli
11
11
New contributor
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Mogli is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Mogli is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211456%2fwhich-option-is-good-in-terms-of-software-design%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Mogli is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Mogli is a new contributor. Be nice, and check out our Code of Conduct.
Mogli is a new contributor. Be nice, and check out our Code of Conduct.
Mogli is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211456%2fwhich-option-is-good-in-terms-of-software-design%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
