Angular 7 HttpClient POST and GET












0












$begingroup$


I have googled and read many tutorials about fetching data and posting data to Rest API. But i have never seen a tutorial with how to handle the getting of new data after a POST or an PUT in a best practice way. So i experimented a bit and codes this. It is working but I don't know if it is the correct way of doing this.



In customerservice I have a subject that components can subscribe to. When I'm getting customers from the API I'm publishing the result into the subject. And in the component I'm subscribing to a customer subject.



In a POST to the API I'm triggering a GetCustomer() to fetch all customers again.



CustomerService



import { Injectable } from '@angular/core';
import { LoggerService } from 'src/app/core/services/logger.service';
import { Observable, Subject } from 'rxjs';
import { Customer } from 'src/app/shared/models/customer.model';
import { HttpClient } from '@angular/common/http';
import { tap, map } from 'rxjs/operators';

@Injectable({
providedIn: 'root'
})
export class CustomersService {
customers = new Subject<Customer>();

constructor(private http: HttpClient, private logger: LoggerService) { }

getCustomers(): void {
this.http.get<Customer>('/subscribers/customers').pipe(map(res => {
this.logger.info('Getting customers', res);
this.customers.next(res);
})).subscribe();
}

addCustomer(customer: Customer): void {
this.http.post<Customer>('/subscribers/customers', customer).pipe(map(res => {
this.logger.info('Adding new customer', res);
this.getCustomers();
})).subscribe();
}
}


CustomerComponent



import { Component, OnInit } from '@angular/core';
import { BsModalRef, BsModalService } from 'ngx-bootstrap/modal';
import { CustomerDialogComponent } from '../../components/customer-dialog/customer-dialog.component';
import { CustomersService } from '../../services/customers.service';
import { Observable } from 'rxjs';
import { Customer } from 'src/app/shared/models/customer.model';
import { LoadingWrapper } from 'src/app/shared/helpers/LoadingWrapper';

@Component({
selector: 'app-customers',
templateUrl: './customers.component.html',
styleUrls: ['./customers.component.scss']
})
export class CustomersComponent implements OnInit {

bsModalRef: BsModalRef;
customers: LoadingWrapper<Customer>;

constructor(private modalService: BsModalService, private customersService: CustomersService) { }

ngOnInit() {
this.customers = new LoadingWrapper(this.customersService.customers);
this.customersService.getCustomers();
}

open(): void {
this.bsModalRef = this.modalService.show(CustomerDialogComponent, { backdrop: false, class: 'right-modal' });
}
}


And finally my modals that's POST a new customer:



import { Component, OnInit } from '@angular/core';
import { FormGroup, Validators } from '@angular/forms';
import { FormInputBase } from 'src/app/shared/models/form-input-base.model';
import { LoggerService } from 'src/app/core/services/logger.service';
import { FormInputText } from 'src/app/shared/models/form-input-text.model';
import { FormService } from 'src/app/core/services/form.service';
import { BsModalService } from 'ngx-bootstrap';
import { CustomersService } from '../../services/customers.service';

@Component({
selector: 'app-add-customer',
templateUrl: './add-customer.component.html',
styleUrls: ['./add-customer.component.scss']
})
export class AddCustomerComponent implements OnInit {
addCustomerForm: FormGroup;
addCustomerInputs: FormInputBase<any>;

constructor(private logger: LoggerService, private formService: FormService,
private modalService: BsModalService, private customerService: CustomersService) { }

ngOnInit() {
this.addCustomerInputs = this.getCustomerInputs();
this.addCustomerForm = this.formService.toFormGroup(this.addCustomerInputs);
}

getCustomerInputs(): FormInputBase<any> {
const inputs: FormInputBase<any> = [
new FormInputText({
key: 'name',
label: 'Name',
placeholder: 'Customer name',
order: 1,
validation: [Validators.required, Validators.maxLength(200)]
}),
new FormInputText({
key: 'ref',
label: 'Ref',
placeholder: 'External reference',
order: 2
})
];
return inputs.sort((a, b) => a.order - b.order);
}

add(): void {
this.customerService.addCustomer(this.addCustomerForm.value);
}

close(): void {
this.modalService.hide(1);
}
}









share|improve this question









New contributor




Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I have googled and read many tutorials about fetching data and posting data to Rest API. But i have never seen a tutorial with how to handle the getting of new data after a POST or an PUT in a best practice way. So i experimented a bit and codes this. It is working but I don't know if it is the correct way of doing this.



    In customerservice I have a subject that components can subscribe to. When I'm getting customers from the API I'm publishing the result into the subject. And in the component I'm subscribing to a customer subject.



    In a POST to the API I'm triggering a GetCustomer() to fetch all customers again.



    CustomerService



    import { Injectable } from '@angular/core';
    import { LoggerService } from 'src/app/core/services/logger.service';
    import { Observable, Subject } from 'rxjs';
    import { Customer } from 'src/app/shared/models/customer.model';
    import { HttpClient } from '@angular/common/http';
    import { tap, map } from 'rxjs/operators';

    @Injectable({
    providedIn: 'root'
    })
    export class CustomersService {
    customers = new Subject<Customer>();

    constructor(private http: HttpClient, private logger: LoggerService) { }

    getCustomers(): void {
    this.http.get<Customer>('/subscribers/customers').pipe(map(res => {
    this.logger.info('Getting customers', res);
    this.customers.next(res);
    })).subscribe();
    }

    addCustomer(customer: Customer): void {
    this.http.post<Customer>('/subscribers/customers', customer).pipe(map(res => {
    this.logger.info('Adding new customer', res);
    this.getCustomers();
    })).subscribe();
    }
    }


    CustomerComponent



    import { Component, OnInit } from '@angular/core';
    import { BsModalRef, BsModalService } from 'ngx-bootstrap/modal';
    import { CustomerDialogComponent } from '../../components/customer-dialog/customer-dialog.component';
    import { CustomersService } from '../../services/customers.service';
    import { Observable } from 'rxjs';
    import { Customer } from 'src/app/shared/models/customer.model';
    import { LoadingWrapper } from 'src/app/shared/helpers/LoadingWrapper';

    @Component({
    selector: 'app-customers',
    templateUrl: './customers.component.html',
    styleUrls: ['./customers.component.scss']
    })
    export class CustomersComponent implements OnInit {

    bsModalRef: BsModalRef;
    customers: LoadingWrapper<Customer>;

    constructor(private modalService: BsModalService, private customersService: CustomersService) { }

    ngOnInit() {
    this.customers = new LoadingWrapper(this.customersService.customers);
    this.customersService.getCustomers();
    }

    open(): void {
    this.bsModalRef = this.modalService.show(CustomerDialogComponent, { backdrop: false, class: 'right-modal' });
    }
    }


    And finally my modals that's POST a new customer:



    import { Component, OnInit } from '@angular/core';
    import { FormGroup, Validators } from '@angular/forms';
    import { FormInputBase } from 'src/app/shared/models/form-input-base.model';
    import { LoggerService } from 'src/app/core/services/logger.service';
    import { FormInputText } from 'src/app/shared/models/form-input-text.model';
    import { FormService } from 'src/app/core/services/form.service';
    import { BsModalService } from 'ngx-bootstrap';
    import { CustomersService } from '../../services/customers.service';

    @Component({
    selector: 'app-add-customer',
    templateUrl: './add-customer.component.html',
    styleUrls: ['./add-customer.component.scss']
    })
    export class AddCustomerComponent implements OnInit {
    addCustomerForm: FormGroup;
    addCustomerInputs: FormInputBase<any>;

    constructor(private logger: LoggerService, private formService: FormService,
    private modalService: BsModalService, private customerService: CustomersService) { }

    ngOnInit() {
    this.addCustomerInputs = this.getCustomerInputs();
    this.addCustomerForm = this.formService.toFormGroup(this.addCustomerInputs);
    }

    getCustomerInputs(): FormInputBase<any> {
    const inputs: FormInputBase<any> = [
    new FormInputText({
    key: 'name',
    label: 'Name',
    placeholder: 'Customer name',
    order: 1,
    validation: [Validators.required, Validators.maxLength(200)]
    }),
    new FormInputText({
    key: 'ref',
    label: 'Ref',
    placeholder: 'External reference',
    order: 2
    })
    ];
    return inputs.sort((a, b) => a.order - b.order);
    }

    add(): void {
    this.customerService.addCustomer(this.addCustomerForm.value);
    }

    close(): void {
    this.modalService.hide(1);
    }
    }









    share|improve this question









    New contributor




    Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I have googled and read many tutorials about fetching data and posting data to Rest API. But i have never seen a tutorial with how to handle the getting of new data after a POST or an PUT in a best practice way. So i experimented a bit and codes this. It is working but I don't know if it is the correct way of doing this.



      In customerservice I have a subject that components can subscribe to. When I'm getting customers from the API I'm publishing the result into the subject. And in the component I'm subscribing to a customer subject.



      In a POST to the API I'm triggering a GetCustomer() to fetch all customers again.



      CustomerService



      import { Injectable } from '@angular/core';
      import { LoggerService } from 'src/app/core/services/logger.service';
      import { Observable, Subject } from 'rxjs';
      import { Customer } from 'src/app/shared/models/customer.model';
      import { HttpClient } from '@angular/common/http';
      import { tap, map } from 'rxjs/operators';

      @Injectable({
      providedIn: 'root'
      })
      export class CustomersService {
      customers = new Subject<Customer>();

      constructor(private http: HttpClient, private logger: LoggerService) { }

      getCustomers(): void {
      this.http.get<Customer>('/subscribers/customers').pipe(map(res => {
      this.logger.info('Getting customers', res);
      this.customers.next(res);
      })).subscribe();
      }

      addCustomer(customer: Customer): void {
      this.http.post<Customer>('/subscribers/customers', customer).pipe(map(res => {
      this.logger.info('Adding new customer', res);
      this.getCustomers();
      })).subscribe();
      }
      }


      CustomerComponent



      import { Component, OnInit } from '@angular/core';
      import { BsModalRef, BsModalService } from 'ngx-bootstrap/modal';
      import { CustomerDialogComponent } from '../../components/customer-dialog/customer-dialog.component';
      import { CustomersService } from '../../services/customers.service';
      import { Observable } from 'rxjs';
      import { Customer } from 'src/app/shared/models/customer.model';
      import { LoadingWrapper } from 'src/app/shared/helpers/LoadingWrapper';

      @Component({
      selector: 'app-customers',
      templateUrl: './customers.component.html',
      styleUrls: ['./customers.component.scss']
      })
      export class CustomersComponent implements OnInit {

      bsModalRef: BsModalRef;
      customers: LoadingWrapper<Customer>;

      constructor(private modalService: BsModalService, private customersService: CustomersService) { }

      ngOnInit() {
      this.customers = new LoadingWrapper(this.customersService.customers);
      this.customersService.getCustomers();
      }

      open(): void {
      this.bsModalRef = this.modalService.show(CustomerDialogComponent, { backdrop: false, class: 'right-modal' });
      }
      }


      And finally my modals that's POST a new customer:



      import { Component, OnInit } from '@angular/core';
      import { FormGroup, Validators } from '@angular/forms';
      import { FormInputBase } from 'src/app/shared/models/form-input-base.model';
      import { LoggerService } from 'src/app/core/services/logger.service';
      import { FormInputText } from 'src/app/shared/models/form-input-text.model';
      import { FormService } from 'src/app/core/services/form.service';
      import { BsModalService } from 'ngx-bootstrap';
      import { CustomersService } from '../../services/customers.service';

      @Component({
      selector: 'app-add-customer',
      templateUrl: './add-customer.component.html',
      styleUrls: ['./add-customer.component.scss']
      })
      export class AddCustomerComponent implements OnInit {
      addCustomerForm: FormGroup;
      addCustomerInputs: FormInputBase<any>;

      constructor(private logger: LoggerService, private formService: FormService,
      private modalService: BsModalService, private customerService: CustomersService) { }

      ngOnInit() {
      this.addCustomerInputs = this.getCustomerInputs();
      this.addCustomerForm = this.formService.toFormGroup(this.addCustomerInputs);
      }

      getCustomerInputs(): FormInputBase<any> {
      const inputs: FormInputBase<any> = [
      new FormInputText({
      key: 'name',
      label: 'Name',
      placeholder: 'Customer name',
      order: 1,
      validation: [Validators.required, Validators.maxLength(200)]
      }),
      new FormInputText({
      key: 'ref',
      label: 'Ref',
      placeholder: 'External reference',
      order: 2
      })
      ];
      return inputs.sort((a, b) => a.order - b.order);
      }

      add(): void {
      this.customerService.addCustomer(this.addCustomerForm.value);
      }

      close(): void {
      this.modalService.hide(1);
      }
      }









      share|improve this question









      New contributor




      Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I have googled and read many tutorials about fetching data and posting data to Rest API. But i have never seen a tutorial with how to handle the getting of new data after a POST or an PUT in a best practice way. So i experimented a bit and codes this. It is working but I don't know if it is the correct way of doing this.



      In customerservice I have a subject that components can subscribe to. When I'm getting customers from the API I'm publishing the result into the subject. And in the component I'm subscribing to a customer subject.



      In a POST to the API I'm triggering a GetCustomer() to fetch all customers again.



      CustomerService



      import { Injectable } from '@angular/core';
      import { LoggerService } from 'src/app/core/services/logger.service';
      import { Observable, Subject } from 'rxjs';
      import { Customer } from 'src/app/shared/models/customer.model';
      import { HttpClient } from '@angular/common/http';
      import { tap, map } from 'rxjs/operators';

      @Injectable({
      providedIn: 'root'
      })
      export class CustomersService {
      customers = new Subject<Customer>();

      constructor(private http: HttpClient, private logger: LoggerService) { }

      getCustomers(): void {
      this.http.get<Customer>('/subscribers/customers').pipe(map(res => {
      this.logger.info('Getting customers', res);
      this.customers.next(res);
      })).subscribe();
      }

      addCustomer(customer: Customer): void {
      this.http.post<Customer>('/subscribers/customers', customer).pipe(map(res => {
      this.logger.info('Adding new customer', res);
      this.getCustomers();
      })).subscribe();
      }
      }


      CustomerComponent



      import { Component, OnInit } from '@angular/core';
      import { BsModalRef, BsModalService } from 'ngx-bootstrap/modal';
      import { CustomerDialogComponent } from '../../components/customer-dialog/customer-dialog.component';
      import { CustomersService } from '../../services/customers.service';
      import { Observable } from 'rxjs';
      import { Customer } from 'src/app/shared/models/customer.model';
      import { LoadingWrapper } from 'src/app/shared/helpers/LoadingWrapper';

      @Component({
      selector: 'app-customers',
      templateUrl: './customers.component.html',
      styleUrls: ['./customers.component.scss']
      })
      export class CustomersComponent implements OnInit {

      bsModalRef: BsModalRef;
      customers: LoadingWrapper<Customer>;

      constructor(private modalService: BsModalService, private customersService: CustomersService) { }

      ngOnInit() {
      this.customers = new LoadingWrapper(this.customersService.customers);
      this.customersService.getCustomers();
      }

      open(): void {
      this.bsModalRef = this.modalService.show(CustomerDialogComponent, { backdrop: false, class: 'right-modal' });
      }
      }


      And finally my modals that's POST a new customer:



      import { Component, OnInit } from '@angular/core';
      import { FormGroup, Validators } from '@angular/forms';
      import { FormInputBase } from 'src/app/shared/models/form-input-base.model';
      import { LoggerService } from 'src/app/core/services/logger.service';
      import { FormInputText } from 'src/app/shared/models/form-input-text.model';
      import { FormService } from 'src/app/core/services/form.service';
      import { BsModalService } from 'ngx-bootstrap';
      import { CustomersService } from '../../services/customers.service';

      @Component({
      selector: 'app-add-customer',
      templateUrl: './add-customer.component.html',
      styleUrls: ['./add-customer.component.scss']
      })
      export class AddCustomerComponent implements OnInit {
      addCustomerForm: FormGroup;
      addCustomerInputs: FormInputBase<any>;

      constructor(private logger: LoggerService, private formService: FormService,
      private modalService: BsModalService, private customerService: CustomersService) { }

      ngOnInit() {
      this.addCustomerInputs = this.getCustomerInputs();
      this.addCustomerForm = this.formService.toFormGroup(this.addCustomerInputs);
      }

      getCustomerInputs(): FormInputBase<any> {
      const inputs: FormInputBase<any> = [
      new FormInputText({
      key: 'name',
      label: 'Name',
      placeholder: 'Customer name',
      order: 1,
      validation: [Validators.required, Validators.maxLength(200)]
      }),
      new FormInputText({
      key: 'ref',
      label: 'Ref',
      placeholder: 'External reference',
      order: 2
      })
      ];
      return inputs.sort((a, b) => a.order - b.order);
      }

      add(): void {
      this.customerService.addCustomer(this.addCustomerForm.value);
      }

      close(): void {
      this.modalService.hide(1);
      }
      }






      javascript angular-2+ angular-bootstrap






      share|improve this question









      New contributor




      Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 24 mins ago









      Jamal

      30.4k11121227




      30.4k11121227






      New contributor




      Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 5 hours ago









      TanTan

      1011




      1011




      New contributor




      Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Tan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Tan is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215533%2fangular-7-httpclient-post-and-get%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Tan is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Tan is a new contributor. Be nice, and check out our Code of Conduct.













          Tan is a new contributor. Be nice, and check out our Code of Conduct.












          Tan is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215533%2fangular-7-httpclient-post-and-get%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Create new schema in PostgreSQL using DBeaver

          Deepest pit of an array with Javascript: test on Codility

          Costa Masnaga