Number of way to render an amount of money












1














I made an algorithm to train my skill in dynamic programming and I would like to have feed back on it. This algorithm takes a money system (int) and have a certain amount of money to render.



Do you see any problems in this code?



public static int wayToRenderMemo(int array, int i, double cost, HashMap memo) {
if(i>=array.length) {
return 0;
}
else if(cost < 0) {
return 0;
}
else if(cost == 0) {
return 1;
}
else if(memo.containsKey(String.valueOf(i)+":"+String.valueOf(cost))) {
return (int) memo.get(String.valueOf(i)+":"+String.valueOf(cost));
}
else {
int res = 0;
for(int j = 0; j < array.length; j++) {
res += wayToRenderMemo(array, i+j, cost-array[j], memo);
}
memo.put(String.valueOf(i)+":"+String.valueOf(cost), res);
return res;
}
}

public static void main(String args) {
int array = {1, 2, 5, 10, 20, 50, 100};

double amountOfMoneyToRender = 20;
System.out.println("Number of way to render "+amountOfMoneyToRender+"€ with the following system : "+Arrays.toString(array));
HashMap memo = new HashMap();
long t3 = System.currentTimeMillis();
System.out.println(wayToRenderMemo(array, 0, amountOfMoneyToRender, memo));
long t4 = System.currentTimeMillis();
double time2 = (t4-t3)/1000.0;
System.out.println("Result found in : "+time2+"seconds");
}









share|improve this question









New contributor




J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

























    1














    I made an algorithm to train my skill in dynamic programming and I would like to have feed back on it. This algorithm takes a money system (int) and have a certain amount of money to render.



    Do you see any problems in this code?



    public static int wayToRenderMemo(int array, int i, double cost, HashMap memo) {
    if(i>=array.length) {
    return 0;
    }
    else if(cost < 0) {
    return 0;
    }
    else if(cost == 0) {
    return 1;
    }
    else if(memo.containsKey(String.valueOf(i)+":"+String.valueOf(cost))) {
    return (int) memo.get(String.valueOf(i)+":"+String.valueOf(cost));
    }
    else {
    int res = 0;
    for(int j = 0; j < array.length; j++) {
    res += wayToRenderMemo(array, i+j, cost-array[j], memo);
    }
    memo.put(String.valueOf(i)+":"+String.valueOf(cost), res);
    return res;
    }
    }

    public static void main(String args) {
    int array = {1, 2, 5, 10, 20, 50, 100};

    double amountOfMoneyToRender = 20;
    System.out.println("Number of way to render "+amountOfMoneyToRender+"€ with the following system : "+Arrays.toString(array));
    HashMap memo = new HashMap();
    long t3 = System.currentTimeMillis();
    System.out.println(wayToRenderMemo(array, 0, amountOfMoneyToRender, memo));
    long t4 = System.currentTimeMillis();
    double time2 = (t4-t3)/1000.0;
    System.out.println("Result found in : "+time2+"seconds");
    }









    share|improve this question









    New contributor




    J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.























      1












      1








      1







      I made an algorithm to train my skill in dynamic programming and I would like to have feed back on it. This algorithm takes a money system (int) and have a certain amount of money to render.



      Do you see any problems in this code?



      public static int wayToRenderMemo(int array, int i, double cost, HashMap memo) {
      if(i>=array.length) {
      return 0;
      }
      else if(cost < 0) {
      return 0;
      }
      else if(cost == 0) {
      return 1;
      }
      else if(memo.containsKey(String.valueOf(i)+":"+String.valueOf(cost))) {
      return (int) memo.get(String.valueOf(i)+":"+String.valueOf(cost));
      }
      else {
      int res = 0;
      for(int j = 0; j < array.length; j++) {
      res += wayToRenderMemo(array, i+j, cost-array[j], memo);
      }
      memo.put(String.valueOf(i)+":"+String.valueOf(cost), res);
      return res;
      }
      }

      public static void main(String args) {
      int array = {1, 2, 5, 10, 20, 50, 100};

      double amountOfMoneyToRender = 20;
      System.out.println("Number of way to render "+amountOfMoneyToRender+"€ with the following system : "+Arrays.toString(array));
      HashMap memo = new HashMap();
      long t3 = System.currentTimeMillis();
      System.out.println(wayToRenderMemo(array, 0, amountOfMoneyToRender, memo));
      long t4 = System.currentTimeMillis();
      double time2 = (t4-t3)/1000.0;
      System.out.println("Result found in : "+time2+"seconds");
      }









      share|improve this question









      New contributor




      J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      I made an algorithm to train my skill in dynamic programming and I would like to have feed back on it. This algorithm takes a money system (int) and have a certain amount of money to render.



      Do you see any problems in this code?



      public static int wayToRenderMemo(int array, int i, double cost, HashMap memo) {
      if(i>=array.length) {
      return 0;
      }
      else if(cost < 0) {
      return 0;
      }
      else if(cost == 0) {
      return 1;
      }
      else if(memo.containsKey(String.valueOf(i)+":"+String.valueOf(cost))) {
      return (int) memo.get(String.valueOf(i)+":"+String.valueOf(cost));
      }
      else {
      int res = 0;
      for(int j = 0; j < array.length; j++) {
      res += wayToRenderMemo(array, i+j, cost-array[j], memo);
      }
      memo.put(String.valueOf(i)+":"+String.valueOf(cost), res);
      return res;
      }
      }

      public static void main(String args) {
      int array = {1, 2, 5, 10, 20, 50, 100};

      double amountOfMoneyToRender = 20;
      System.out.println("Number of way to render "+amountOfMoneyToRender+"€ with the following system : "+Arrays.toString(array));
      HashMap memo = new HashMap();
      long t3 = System.currentTimeMillis();
      System.out.println(wayToRenderMemo(array, 0, amountOfMoneyToRender, memo));
      long t4 = System.currentTimeMillis();
      double time2 = (t4-t3)/1000.0;
      System.out.println("Result found in : "+time2+"seconds");
      }






      java dynamic-programming memoization






      share|improve this question









      New contributor




      J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 6 mins ago









      Jamal

      30.2k11116226




      30.2k11116226






      New contributor




      J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 3 hours ago









      J. Toulmonde

      61




      61




      New contributor




      J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      J. Toulmonde is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          J. Toulmonde is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210145%2fnumber-of-way-to-render-an-amount-of-money%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          J. Toulmonde is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          J. Toulmonde is a new contributor. Be nice, and check out our Code of Conduct.













          J. Toulmonde is a new contributor. Be nice, and check out our Code of Conduct.












          J. Toulmonde is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210145%2fnumber-of-way-to-render-an-amount-of-money%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Costa Masnaga

          Fotorealismo

          Sidney Franklin