Sql code give invalid SQL statement in Java but it works in SqlDeveloper
I tried to make crud , but insert statement do not work from code
try {
java.sql.Date sqlDate = new java.sql.Date(date.getTime());
conn2 = DriverManager.getConnection(dbURL2, username, password);
String sql="INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID)VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+")";
System.out.println(sql);
stmt = conn2.createStatement();
ResultSet rs = stmt.executeQuery(sql);
while (rs.next()) {
System.out.println(rs.getString("name"));
}
if (conn2 != null && !conn2.isClosed()) {
conn2.close();
}
} catch (SQLException ex) {
ex.printStackTrace();
}
I made a System.out.println to see my sql and to execute it to understand where is the problem, this is my String, and it works in sqlDeveloper:
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID)VALUES('ew','rrr',TO_DATE('2018-11-14', 'yyyy-mm-dd'),12.0,2,2)
java oracle
add a comment |
I tried to make crud , but insert statement do not work from code
try {
java.sql.Date sqlDate = new java.sql.Date(date.getTime());
conn2 = DriverManager.getConnection(dbURL2, username, password);
String sql="INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID)VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+")";
System.out.println(sql);
stmt = conn2.createStatement();
ResultSet rs = stmt.executeQuery(sql);
while (rs.next()) {
System.out.println(rs.getString("name"));
}
if (conn2 != null && !conn2.isClosed()) {
conn2.close();
}
} catch (SQLException ex) {
ex.printStackTrace();
}
I made a System.out.println to see my sql and to execute it to understand where is the problem, this is my String, and it works in sqlDeveloper:
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID)VALUES('ew','rrr',TO_DATE('2018-11-14', 'yyyy-mm-dd'),12.0,2,2)
java oracle
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID) VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+") change to this
– Pooja Aggarwal
Nov 21 '18 at 9:51
@PoojaAggarwal change what? Can you please point the difference out?
– Federico klez Culloca
Nov 21 '18 at 9:51
3
Don't do this, use a prepared statement and pass parameters, this will handle or the escaping for you and ensure your SQL is valid.
– SPlatten
Nov 21 '18 at 9:52
1
As pointed out in the answer by Vaibhav, the usage ofexecuteQuery
is wrong for the insert. Have a look at this, should be using preparedStatement to avert the risk of SQL Injection.
– Jåcob
Nov 21 '18 at 10:01
add a comment |
I tried to make crud , but insert statement do not work from code
try {
java.sql.Date sqlDate = new java.sql.Date(date.getTime());
conn2 = DriverManager.getConnection(dbURL2, username, password);
String sql="INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID)VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+")";
System.out.println(sql);
stmt = conn2.createStatement();
ResultSet rs = stmt.executeQuery(sql);
while (rs.next()) {
System.out.println(rs.getString("name"));
}
if (conn2 != null && !conn2.isClosed()) {
conn2.close();
}
} catch (SQLException ex) {
ex.printStackTrace();
}
I made a System.out.println to see my sql and to execute it to understand where is the problem, this is my String, and it works in sqlDeveloper:
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID)VALUES('ew','rrr',TO_DATE('2018-11-14', 'yyyy-mm-dd'),12.0,2,2)
java oracle
I tried to make crud , but insert statement do not work from code
try {
java.sql.Date sqlDate = new java.sql.Date(date.getTime());
conn2 = DriverManager.getConnection(dbURL2, username, password);
String sql="INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID)VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+")";
System.out.println(sql);
stmt = conn2.createStatement();
ResultSet rs = stmt.executeQuery(sql);
while (rs.next()) {
System.out.println(rs.getString("name"));
}
if (conn2 != null && !conn2.isClosed()) {
conn2.close();
}
} catch (SQLException ex) {
ex.printStackTrace();
}
I made a System.out.println to see my sql and to execute it to understand where is the problem, this is my String, and it works in sqlDeveloper:
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID)VALUES('ew','rrr',TO_DATE('2018-11-14', 'yyyy-mm-dd'),12.0,2,2)
java oracle
java oracle
edited Nov 21 '18 at 10:01
a_horse_with_no_name
293k46447541
293k46447541
asked Nov 21 '18 at 9:49
Andrei GospodarencoAndrei Gospodarenco
8919
8919
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID) VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+") change to this
– Pooja Aggarwal
Nov 21 '18 at 9:51
@PoojaAggarwal change what? Can you please point the difference out?
– Federico klez Culloca
Nov 21 '18 at 9:51
3
Don't do this, use a prepared statement and pass parameters, this will handle or the escaping for you and ensure your SQL is valid.
– SPlatten
Nov 21 '18 at 9:52
1
As pointed out in the answer by Vaibhav, the usage ofexecuteQuery
is wrong for the insert. Have a look at this, should be using preparedStatement to avert the risk of SQL Injection.
– Jåcob
Nov 21 '18 at 10:01
add a comment |
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID) VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+") change to this
– Pooja Aggarwal
Nov 21 '18 at 9:51
@PoojaAggarwal change what? Can you please point the difference out?
– Federico klez Culloca
Nov 21 '18 at 9:51
3
Don't do this, use a prepared statement and pass parameters, this will handle or the escaping for you and ensure your SQL is valid.
– SPlatten
Nov 21 '18 at 9:52
1
As pointed out in the answer by Vaibhav, the usage ofexecuteQuery
is wrong for the insert. Have a look at this, should be using preparedStatement to avert the risk of SQL Injection.
– Jåcob
Nov 21 '18 at 10:01
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID) VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+") change to this
– Pooja Aggarwal
Nov 21 '18 at 9:51
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID) VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+") change to this
– Pooja Aggarwal
Nov 21 '18 at 9:51
@PoojaAggarwal change what? Can you please point the difference out?
– Federico klez Culloca
Nov 21 '18 at 9:51
@PoojaAggarwal change what? Can you please point the difference out?
– Federico klez Culloca
Nov 21 '18 at 9:51
3
3
Don't do this, use a prepared statement and pass parameters, this will handle or the escaping for you and ensure your SQL is valid.
– SPlatten
Nov 21 '18 at 9:52
Don't do this, use a prepared statement and pass parameters, this will handle or the escaping for you and ensure your SQL is valid.
– SPlatten
Nov 21 '18 at 9:52
1
1
As pointed out in the answer by Vaibhav, the usage of
executeQuery
is wrong for the insert. Have a look at this, should be using preparedStatement to avert the risk of SQL Injection.– Jåcob
Nov 21 '18 at 10:01
As pointed out in the answer by Vaibhav, the usage of
executeQuery
is wrong for the insert. Have a look at this, should be using preparedStatement to avert the risk of SQL Injection.– Jåcob
Nov 21 '18 at 10:01
add a comment |
1 Answer
1
active
oldest
votes
you are using insert SQL query to retrieve result.
I believe to retrieve name you need to execute select statement
You was right, thank you Vaibhav
– Andrei Gospodarenco
Nov 21 '18 at 10:00
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53409286%2fsql-code-give-invalid-sql-statement-in-java-but-it-works-in-sqldeveloper%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
you are using insert SQL query to retrieve result.
I believe to retrieve name you need to execute select statement
You was right, thank you Vaibhav
– Andrei Gospodarenco
Nov 21 '18 at 10:00
add a comment |
you are using insert SQL query to retrieve result.
I believe to retrieve name you need to execute select statement
You was right, thank you Vaibhav
– Andrei Gospodarenco
Nov 21 '18 at 10:00
add a comment |
you are using insert SQL query to retrieve result.
I believe to retrieve name you need to execute select statement
you are using insert SQL query to retrieve result.
I believe to retrieve name you need to execute select statement
answered Nov 21 '18 at 9:56
Vaibhav KhamgavkarVaibhav Khamgavkar
363
363
You was right, thank you Vaibhav
– Andrei Gospodarenco
Nov 21 '18 at 10:00
add a comment |
You was right, thank you Vaibhav
– Andrei Gospodarenco
Nov 21 '18 at 10:00
You was right, thank you Vaibhav
– Andrei Gospodarenco
Nov 21 '18 at 10:00
You was right, thank you Vaibhav
– Andrei Gospodarenco
Nov 21 '18 at 10:00
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53409286%2fsql-code-give-invalid-sql-statement-in-java-but-it-works-in-sqldeveloper%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
INSERT INTO Produce(name,description,Produce_Date,Price,CATEGORY_ID,Person_ID) VALUES('"+name+"','"+description+"',TO_DATE('"+sqlDate+"', 'yyyy-mm-dd'),"+price+","+category_Id+","+person_id+") change to this
– Pooja Aggarwal
Nov 21 '18 at 9:51
@PoojaAggarwal change what? Can you please point the difference out?
– Federico klez Culloca
Nov 21 '18 at 9:51
3
Don't do this, use a prepared statement and pass parameters, this will handle or the escaping for you and ensure your SQL is valid.
– SPlatten
Nov 21 '18 at 9:52
1
As pointed out in the answer by Vaibhav, the usage of
executeQuery
is wrong for the insert. Have a look at this, should be using preparedStatement to avert the risk of SQL Injection.– Jåcob
Nov 21 '18 at 10:01