Anything I can do to optimize this code?











up vote
0
down vote

favorite












I was hoping for any for improving the performance of my code, anything at all. This code is supposed to count each character in a given string and account for error handling and type casting as well, and it should do it in the most efficient manner possible, with O(n) being a upper limit for both time and memory. I have went through my process for problem solving which involves explaining the problem in my own words, looking at the inputs, the outputs, if the answer is even possible given the I/O, and then refactoring my code. Please, if anyone sees a better way to accomplish this then let me know. Thank you.






function characterCounter(str) {
// Error Handling
// No input
if (!str) {
return "String input required";
}

// attempt to type cast non strings
if (typeof str !== "string") {
str = str.toString();
// input could not be successfully type casted
if (typeof str !== "string") {
return "Invalid input";
}
}

const stringLen = str.length;
const result = {};
let i = 0;

// loop through each character for O(n) time complexity and O(n) space complexity
// since the object grows based on input size
for (; i < stringLen; i++) {
// If string not in object as a key then add it and set value to 1
if (result[str[i]] === undefined && str[i] !== " ") {
result[str[i].toLowerCase()] = 1;
} else {
if (str[i] !== " ") {
// add one to value at current key
result[str[i]]++;
}
}
}
return result;
}

// Returns an object which allows O(1) for insert, deletion, access, and O(n) for searching...
console.log(characterCounter("Hello, World!"));












share|improve this question


























    up vote
    0
    down vote

    favorite












    I was hoping for any for improving the performance of my code, anything at all. This code is supposed to count each character in a given string and account for error handling and type casting as well, and it should do it in the most efficient manner possible, with O(n) being a upper limit for both time and memory. I have went through my process for problem solving which involves explaining the problem in my own words, looking at the inputs, the outputs, if the answer is even possible given the I/O, and then refactoring my code. Please, if anyone sees a better way to accomplish this then let me know. Thank you.






    function characterCounter(str) {
    // Error Handling
    // No input
    if (!str) {
    return "String input required";
    }

    // attempt to type cast non strings
    if (typeof str !== "string") {
    str = str.toString();
    // input could not be successfully type casted
    if (typeof str !== "string") {
    return "Invalid input";
    }
    }

    const stringLen = str.length;
    const result = {};
    let i = 0;

    // loop through each character for O(n) time complexity and O(n) space complexity
    // since the object grows based on input size
    for (; i < stringLen; i++) {
    // If string not in object as a key then add it and set value to 1
    if (result[str[i]] === undefined && str[i] !== " ") {
    result[str[i].toLowerCase()] = 1;
    } else {
    if (str[i] !== " ") {
    // add one to value at current key
    result[str[i]]++;
    }
    }
    }
    return result;
    }

    // Returns an object which allows O(1) for insert, deletion, access, and O(n) for searching...
    console.log(characterCounter("Hello, World!"));












    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I was hoping for any for improving the performance of my code, anything at all. This code is supposed to count each character in a given string and account for error handling and type casting as well, and it should do it in the most efficient manner possible, with O(n) being a upper limit for both time and memory. I have went through my process for problem solving which involves explaining the problem in my own words, looking at the inputs, the outputs, if the answer is even possible given the I/O, and then refactoring my code. Please, if anyone sees a better way to accomplish this then let me know. Thank you.






      function characterCounter(str) {
      // Error Handling
      // No input
      if (!str) {
      return "String input required";
      }

      // attempt to type cast non strings
      if (typeof str !== "string") {
      str = str.toString();
      // input could not be successfully type casted
      if (typeof str !== "string") {
      return "Invalid input";
      }
      }

      const stringLen = str.length;
      const result = {};
      let i = 0;

      // loop through each character for O(n) time complexity and O(n) space complexity
      // since the object grows based on input size
      for (; i < stringLen; i++) {
      // If string not in object as a key then add it and set value to 1
      if (result[str[i]] === undefined && str[i] !== " ") {
      result[str[i].toLowerCase()] = 1;
      } else {
      if (str[i] !== " ") {
      // add one to value at current key
      result[str[i]]++;
      }
      }
      }
      return result;
      }

      // Returns an object which allows O(1) for insert, deletion, access, and O(n) for searching...
      console.log(characterCounter("Hello, World!"));












      share|improve this question













      I was hoping for any for improving the performance of my code, anything at all. This code is supposed to count each character in a given string and account for error handling and type casting as well, and it should do it in the most efficient manner possible, with O(n) being a upper limit for both time and memory. I have went through my process for problem solving which involves explaining the problem in my own words, looking at the inputs, the outputs, if the answer is even possible given the I/O, and then refactoring my code. Please, if anyone sees a better way to accomplish this then let me know. Thank you.






      function characterCounter(str) {
      // Error Handling
      // No input
      if (!str) {
      return "String input required";
      }

      // attempt to type cast non strings
      if (typeof str !== "string") {
      str = str.toString();
      // input could not be successfully type casted
      if (typeof str !== "string") {
      return "Invalid input";
      }
      }

      const stringLen = str.length;
      const result = {};
      let i = 0;

      // loop through each character for O(n) time complexity and O(n) space complexity
      // since the object grows based on input size
      for (; i < stringLen; i++) {
      // If string not in object as a key then add it and set value to 1
      if (result[str[i]] === undefined && str[i] !== " ") {
      result[str[i].toLowerCase()] = 1;
      } else {
      if (str[i] !== " ") {
      // add one to value at current key
      result[str[i]]++;
      }
      }
      }
      return result;
      }

      // Returns an object which allows O(1) for insert, deletion, access, and O(n) for searching...
      console.log(characterCounter("Hello, World!"));








      function characterCounter(str) {
      // Error Handling
      // No input
      if (!str) {
      return "String input required";
      }

      // attempt to type cast non strings
      if (typeof str !== "string") {
      str = str.toString();
      // input could not be successfully type casted
      if (typeof str !== "string") {
      return "Invalid input";
      }
      }

      const stringLen = str.length;
      const result = {};
      let i = 0;

      // loop through each character for O(n) time complexity and O(n) space complexity
      // since the object grows based on input size
      for (; i < stringLen; i++) {
      // If string not in object as a key then add it and set value to 1
      if (result[str[i]] === undefined && str[i] !== " ") {
      result[str[i].toLowerCase()] = 1;
      } else {
      if (str[i] !== " ") {
      // add one to value at current key
      result[str[i]]++;
      }
      }
      }
      return result;
      }

      // Returns an object which allows O(1) for insert, deletion, access, and O(n) for searching...
      console.log(characterCounter("Hello, World!"));





      function characterCounter(str) {
      // Error Handling
      // No input
      if (!str) {
      return "String input required";
      }

      // attempt to type cast non strings
      if (typeof str !== "string") {
      str = str.toString();
      // input could not be successfully type casted
      if (typeof str !== "string") {
      return "Invalid input";
      }
      }

      const stringLen = str.length;
      const result = {};
      let i = 0;

      // loop through each character for O(n) time complexity and O(n) space complexity
      // since the object grows based on input size
      for (; i < stringLen; i++) {
      // If string not in object as a key then add it and set value to 1
      if (result[str[i]] === undefined && str[i] !== " ") {
      result[str[i].toLowerCase()] = 1;
      } else {
      if (str[i] !== " ") {
      // add one to value at current key
      result[str[i]]++;
      }
      }
      }
      return result;
      }

      // Returns an object which allows O(1) for insert, deletion, access, and O(n) for searching...
      console.log(characterCounter("Hello, World!"));






      performance






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 13 mins ago









      Brian Ruff

      334




      334



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208850%2fanything-i-can-do-to-optimize-this-code%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208850%2fanything-i-can-do-to-optimize-this-code%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Costa Masnaga

          Fotorealismo

          Sidney Franklin