Using mobx for a trivial singleton
up vote
0
down vote
favorite
I'm very new to mobx and unsure, how to use it properly. I'm used to OO, so I prefer using the class
keyword and I found myself writing the following singleton class:
// @flow
import {decorate, observable, action} from "mobx"
class Auth {
email: string = ""
authorization: string = ""
setEmail(email: string) { // P1
this.email = email
}
}
const auth = new Auth()
decorate({dummy: auth}, { // P2
auth: observable,
})
decorate(Auth, {
setEmail: action,
})
export {auth}
I myself find it pretty strange, nonetheless it seems to work.
- P1: This is actually wrong as I wanted to use an arrow function, so that
this
is bound to the current instance. I'm about to change it, but I'm leaving it here hoping for an explanation why it works. - P2: This is a hack used to decorate all members of
auth
asobservable
. AFAIK the decoration marks all members recursively, which is about what I wanted (markingsetEmail
is superfluous, but AFAIK harmless).
I'm perfectly sure that this isn't the best piece of code and I'll gladly improve it. I'd prefer to preserve the class-syntax, if it makes any sense, but I'm open to all kinds of changes.
javascript react.js mobx
add a comment |
up vote
0
down vote
favorite
I'm very new to mobx and unsure, how to use it properly. I'm used to OO, so I prefer using the class
keyword and I found myself writing the following singleton class:
// @flow
import {decorate, observable, action} from "mobx"
class Auth {
email: string = ""
authorization: string = ""
setEmail(email: string) { // P1
this.email = email
}
}
const auth = new Auth()
decorate({dummy: auth}, { // P2
auth: observable,
})
decorate(Auth, {
setEmail: action,
})
export {auth}
I myself find it pretty strange, nonetheless it seems to work.
- P1: This is actually wrong as I wanted to use an arrow function, so that
this
is bound to the current instance. I'm about to change it, but I'm leaving it here hoping for an explanation why it works. - P2: This is a hack used to decorate all members of
auth
asobservable
. AFAIK the decoration marks all members recursively, which is about what I wanted (markingsetEmail
is superfluous, but AFAIK harmless).
I'm perfectly sure that this isn't the best piece of code and I'll gladly improve it. I'd prefer to preserve the class-syntax, if it makes any sense, but I'm open to all kinds of changes.
javascript react.js mobx
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
I'm very new to mobx and unsure, how to use it properly. I'm used to OO, so I prefer using the class
keyword and I found myself writing the following singleton class:
// @flow
import {decorate, observable, action} from "mobx"
class Auth {
email: string = ""
authorization: string = ""
setEmail(email: string) { // P1
this.email = email
}
}
const auth = new Auth()
decorate({dummy: auth}, { // P2
auth: observable,
})
decorate(Auth, {
setEmail: action,
})
export {auth}
I myself find it pretty strange, nonetheless it seems to work.
- P1: This is actually wrong as I wanted to use an arrow function, so that
this
is bound to the current instance. I'm about to change it, but I'm leaving it here hoping for an explanation why it works. - P2: This is a hack used to decorate all members of
auth
asobservable
. AFAIK the decoration marks all members recursively, which is about what I wanted (markingsetEmail
is superfluous, but AFAIK harmless).
I'm perfectly sure that this isn't the best piece of code and I'll gladly improve it. I'd prefer to preserve the class-syntax, if it makes any sense, but I'm open to all kinds of changes.
javascript react.js mobx
I'm very new to mobx and unsure, how to use it properly. I'm used to OO, so I prefer using the class
keyword and I found myself writing the following singleton class:
// @flow
import {decorate, observable, action} from "mobx"
class Auth {
email: string = ""
authorization: string = ""
setEmail(email: string) { // P1
this.email = email
}
}
const auth = new Auth()
decorate({dummy: auth}, { // P2
auth: observable,
})
decorate(Auth, {
setEmail: action,
})
export {auth}
I myself find it pretty strange, nonetheless it seems to work.
- P1: This is actually wrong as I wanted to use an arrow function, so that
this
is bound to the current instance. I'm about to change it, but I'm leaving it here hoping for an explanation why it works. - P2: This is a hack used to decorate all members of
auth
asobservable
. AFAIK the decoration marks all members recursively, which is about what I wanted (markingsetEmail
is superfluous, but AFAIK harmless).
I'm perfectly sure that this isn't the best piece of code and I'll gladly improve it. I'd prefer to preserve the class-syntax, if it makes any sense, but I'm open to all kinds of changes.
javascript react.js mobx
javascript react.js mobx
asked 9 mins ago
maaartinus
12.3k12668
12.3k12668
add a comment |
add a comment |
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209195%2fusing-mobx-for-a-trivial-singleton%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown