String contains non-overlapping letter pairs
up vote
2
down vote
favorite
I was trying my hand at learning Elixir via ancient adventofcode puzzles and was trying to write a function to satisfy this requirement:
It contains a pair of any two letters that appears at least twice in
the string without overlapping, like xyxy (xy) or aabcdefgaa (aa), but
not like aaa (aa, but it overlaps).
Here is what I came up with, but it feels like it might be unwieldy. Is there a way to make it more elegant?
def has_non_overlapping_pair(string) do
0..String.length(string)-2
|> Enum.map(fn n ->
String.slice(string, n, 2)
end)
|> Enum.reduce(["_"], fn pair, acc ->
if pair == hd(acc) do ["_"|acc]
else [pair|acc] end
end)
|> count_occurrences
|> Map.delete("_")
|> Map.values
|> Enum.any?(fn val -> val > 1 end)
end
strings elixir
edited 15 mins ago
Jamal♦
30.2k11115226
asked 9 hours ago
thesunneversets
1112
New contributor
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
2
down vote
favorite
I was trying my hand at learning Elixir via ancient adventofcode puzzles and was trying to write a function to satisfy this requirement:
It contains a pair of any two letters that appears at least twice in
the string without overlapping, like xyxy (xy) or aabcdefgaa (aa), but
not like aaa (aa, but it overlaps).
Here is what I came up with, but it feels like it might be unwieldy. Is there a way to make it more elegant?
def has_non_overlapping_pair(string) do
0..String.length(string)-2
|> Enum.map(fn n ->
String.slice(string, n, 2)
end)
|> Enum.reduce(["_"], fn pair, acc ->
if pair == hd(acc) do ["_"|acc]
else [pair|acc] end
end)
|> count_occurrences
|> Map.delete("_")
|> Map.values
|> Enum.any?(fn val -> val > 1 end)
end
strings elixir
edited 15 mins ago
Jamal♦
30.2k11115226
asked 9 hours ago
thesunneversets
1112
New contributor
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
2
down vote
favorite
up vote
2
down vote
favorite
I was trying my hand at learning Elixir via ancient adventofcode puzzles and was trying to write a function to satisfy this requirement:
It contains a pair of any two letters that appears at least twice in
the string without overlapping, like xyxy (xy) or aabcdefgaa (aa), but
not like aaa (aa, but it overlaps).
Here is what I came up with, but it feels like it might be unwieldy. Is there a way to make it more elegant?
def has_non_overlapping_pair(string) do
0..String.length(string)-2
|> Enum.map(fn n ->
String.slice(string, n, 2)
end)
|> Enum.reduce(["_"], fn pair, acc ->
if pair == hd(acc) do ["_"|acc]
else [pair|acc] end
end)
|> count_occurrences
|> Map.delete("_")
|> Map.values
|> Enum.any?(fn val -> val > 1 end)
end
strings elixir
edited 15 mins ago
Jamal♦
30.2k11115226
asked 9 hours ago
thesunneversets
1112
New contributor
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
I was trying my hand at learning Elixir via ancient adventofcode puzzles and was trying to write a function to satisfy this requirement:
It contains a pair of any two letters that appears at least twice in
the string without overlapping, like xyxy (xy) or aabcdefgaa (aa), but
not like aaa (aa, but it overlaps).
Here is what I came up with, but it feels like it might be unwieldy. Is there a way to make it more elegant?
def has_non_overlapping_pair(string) do
0..String.length(string)-2
|> Enum.map(fn n ->
String.slice(string, n, 2)
end)
|> Enum.reduce(["_"], fn pair, acc ->
if pair == hd(acc) do ["_"|acc]
else [pair|acc] end
end)
|> count_occurrences
|> Map.delete("_")
|> Map.values
|> Enum.any?(fn val -> val > 1 end)
end
strings elixir
strings elixir
edited 15 mins ago
Jamal♦
30.2k11115226
asked 9 hours ago
thesunneversets
1112
New contributor
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 15 mins ago
Jamal♦
30.2k11115226
asked 9 hours ago
thesunneversets
1112
New contributor
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 15 mins ago
Jamal♦
30.2k11115226
edited 15 mins ago
Jamal♦
30.2k11115226
edited 15 mins ago
Jamal♦
30.2k11115226
30.2k11115226
asked 9 hours ago
thesunneversets
1112
New contributor
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 9 hours ago
thesunneversets
1112
asked 9 hours ago
thesunneversets
1112
1112
New contributor
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
thesunneversets is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
thesunneversets is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209921%2fstring-contains-non-overlapping-letter-pairs%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
thesunneversets is a new contributor. Be nice, and check out our Code of Conduct.
thesunneversets is a new contributor. Be nice, and check out our Code of Conduct.
thesunneversets is a new contributor. Be nice, and check out our Code of Conduct.
thesunneversets is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209921%2fstring-contains-non-overlapping-letter-pairs%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
