Time cost difference between opening a new thread to run requests and aiohttp.ClientSession for async IO?
I understood aiohttp supports the async IO so it's completely single thread. But run_in_executor sort of starts a new thread. But I tested for a task with 1000 downloads, it seems the difference is rather insignificant. But I assume aiohttp should be much faster cause the thread cost. Did I do something wrong?
async def get(url):
async with aiohttp.ClientSession() as session:
async with session.get(url) as resp:
print(url, resp.status)
print(url, await resp.text())
loop = asyncio.get_event_loop()
tasks = [
get("http://www.google.com"),
get("http://www.google.com")
]
loop.run_until_complete(asyncio.wait(tasks))
loop.close()
async def get_via_thread(url):
loop = asyncio.get_event_loop()
try:
response = await loop.run_in_executor(None, functools.partial(requests.get, url=url))
python asynchronous python-asyncio aiohttp
asked Nov 25 '18 at 13:47
bot1bot1
327
add a comment |
I understood aiohttp supports the async IO so it's completely single thread. But run_in_executor sort of starts a new thread. But I tested for a task with 1000 downloads, it seems the difference is rather insignificant. But I assume aiohttp should be much faster cause the thread cost. Did I do something wrong?
async def get(url):
async with aiohttp.ClientSession() as session:
async with session.get(url) as resp:
print(url, resp.status)
print(url, await resp.text())
loop = asyncio.get_event_loop()
tasks = [
get("http://www.google.com"),
get("http://www.google.com")
]
loop.run_until_complete(asyncio.wait(tasks))
loop.close()
async def get_via_thread(url):
loop = asyncio.get_event_loop()
try:
response = await loop.run_in_executor(None, functools.partial(requests.get, url=url))
python asynchronous python-asyncio aiohttp
asked Nov 25 '18 at 13:47
bot1bot1
327
add a comment |
I understood aiohttp supports the async IO so it's completely single thread. But run_in_executor sort of starts a new thread. But I tested for a task with 1000 downloads, it seems the difference is rather insignificant. But I assume aiohttp should be much faster cause the thread cost. Did I do something wrong?
async def get(url):
async with aiohttp.ClientSession() as session:
async with session.get(url) as resp:
print(url, resp.status)
print(url, await resp.text())
loop = asyncio.get_event_loop()
tasks = [
get("http://www.google.com"),
get("http://www.google.com")
]
loop.run_until_complete(asyncio.wait(tasks))
loop.close()
async def get_via_thread(url):
loop = asyncio.get_event_loop()
try:
response = await loop.run_in_executor(None, functools.partial(requests.get, url=url))
python asynchronous python-asyncio aiohttp
asked Nov 25 '18 at 13:47
bot1bot1
327
I understood aiohttp supports the async IO so it's completely single thread. But run_in_executor sort of starts a new thread. But I tested for a task with 1000 downloads, it seems the difference is rather insignificant. But I assume aiohttp should be much faster cause the thread cost. Did I do something wrong?
async def get(url):
async with aiohttp.ClientSession() as session:
async with session.get(url) as resp:
print(url, resp.status)
print(url, await resp.text())
loop = asyncio.get_event_loop()
tasks = [
get("http://www.google.com"),
get("http://www.google.com")
]
loop.run_until_complete(asyncio.wait(tasks))
loop.close()
async def get_via_thread(url):
loop = asyncio.get_event_loop()
try:
response = await loop.run_in_executor(None, functools.partial(requests.get, url=url))
python asynchronous python-asyncio aiohttp
python asynchronous python-asyncio aiohttp
asked Nov 25 '18 at 13:47
bot1bot1
327
asked Nov 25 '18 at 13:47
bot1bot1
327
asked Nov 25 '18 at 13:47
bot1bot1
327
asked Nov 25 '18 at 13:47
bot1bot1
327
asked Nov 25 '18 at 13:47
bot1bot1
327
327
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
But I tested for a task with 1000 downloads, it seems the difference
is rather insignificant.
Problem probably somewhere in your benchmark. It's hard to say where exactly since you didn't provide one to reproduce :)
As example, you can take a look at one recent question where OP tried to compare threads and coroutines and got no difference and answer where this result explained and fix provided.
answered Nov 25 '18 at 14:15
Mikhail GerasimovMikhail Gerasimov
14.2k43869
wow thank you. I actually did not see that question, but that answer answered quite well. It seems my assumption is right just my test has to be improved somehow.
– bot1
Nov 25 '18 at 18:20
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53468119%2ftime-cost-difference-between-opening-a-new-thread-to-run-requests-and-aiohttp-cl%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
But I tested for a task with 1000 downloads, it seems the difference
is rather insignificant.
Problem probably somewhere in your benchmark. It's hard to say where exactly since you didn't provide one to reproduce :)
As example, you can take a look at one recent question where OP tried to compare threads and coroutines and got no difference and answer where this result explained and fix provided.
answered Nov 25 '18 at 14:15
Mikhail GerasimovMikhail Gerasimov
14.2k43869
wow thank you. I actually did not see that question, but that answer answered quite well. It seems my assumption is right just my test has to be improved somehow.
– bot1
Nov 25 '18 at 18:20
add a comment |
But I tested for a task with 1000 downloads, it seems the difference
is rather insignificant.
Problem probably somewhere in your benchmark. It's hard to say where exactly since you didn't provide one to reproduce :)
As example, you can take a look at one recent question where OP tried to compare threads and coroutines and got no difference and answer where this result explained and fix provided.
answered Nov 25 '18 at 14:15
Mikhail GerasimovMikhail Gerasimov
14.2k43869
wow thank you. I actually did not see that question, but that answer answered quite well. It seems my assumption is right just my test has to be improved somehow.
– bot1
Nov 25 '18 at 18:20
add a comment |
But I tested for a task with 1000 downloads, it seems the difference
is rather insignificant.
Problem probably somewhere in your benchmark. It's hard to say where exactly since you didn't provide one to reproduce :)
As example, you can take a look at one recent question where OP tried to compare threads and coroutines and got no difference and answer where this result explained and fix provided.
answered Nov 25 '18 at 14:15
Mikhail GerasimovMikhail Gerasimov
14.2k43869
But I tested for a task with 1000 downloads, it seems the difference
is rather insignificant.
Problem probably somewhere in your benchmark. It's hard to say where exactly since you didn't provide one to reproduce :)
As example, you can take a look at one recent question where OP tried to compare threads and coroutines and got no difference and answer where this result explained and fix provided.
answered Nov 25 '18 at 14:15
Mikhail GerasimovMikhail Gerasimov
14.2k43869
answered Nov 25 '18 at 14:15
Mikhail GerasimovMikhail Gerasimov
14.2k43869
answered Nov 25 '18 at 14:15
Mikhail GerasimovMikhail Gerasimov
14.2k43869
answered Nov 25 '18 at 14:15
Mikhail GerasimovMikhail Gerasimov
14.2k43869
14.2k43869
wow thank you. I actually did not see that question, but that answer answered quite well. It seems my assumption is right just my test has to be improved somehow.
– bot1
Nov 25 '18 at 18:20
add a comment |
wow thank you. I actually did not see that question, but that answer answered quite well. It seems my assumption is right just my test has to be improved somehow.
– bot1
Nov 25 '18 at 18:20
wow thank you. I actually did not see that question, but that answer answered quite well. It seems my assumption is right just my test has to be improved somehow.
– bot1
Nov 25 '18 at 18:20
wow thank you. I actually did not see that question, but that answer answered quite well. It seems my assumption is right just my test has to be improved somehow.
– bot1
Nov 25 '18 at 18:20
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53468119%2ftime-cost-difference-between-opening-a-new-thread-to-run-requests-and-aiohttp-cl%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
