How to stop Promise.all loop when it rejects












0















I'm having a hard time trying to stop the loop in promise.all if one promise rejects it. Here's how I did it. Is there something wrong with this?



 Promise.all(myArray.map((obj) => {
this.someFunction(obj);
}))


Here's the function I call..



someFunction(){
return new Promise(function (resolve, reject) {
....
reject()
})}









share|improve this question


















  • 1





    Promise.all does not "loop" anything

    – Bergi
    Nov 22 '18 at 13:24











  • The map returns an array and it is created "instantly", Promise.all will resolve if all promises in the array are resolved and will reject if one rejects. What exactly are you trying to achieve?

    – koox00
    Nov 22 '18 at 14:54


















0















I'm having a hard time trying to stop the loop in promise.all if one promise rejects it. Here's how I did it. Is there something wrong with this?



 Promise.all(myArray.map((obj) => {
this.someFunction(obj);
}))


Here's the function I call..



someFunction(){
return new Promise(function (resolve, reject) {
....
reject()
})}









share|improve this question


















  • 1





    Promise.all does not "loop" anything

    – Bergi
    Nov 22 '18 at 13:24











  • The map returns an array and it is created "instantly", Promise.all will resolve if all promises in the array are resolved and will reject if one rejects. What exactly are you trying to achieve?

    – koox00
    Nov 22 '18 at 14:54
















0












0








0








I'm having a hard time trying to stop the loop in promise.all if one promise rejects it. Here's how I did it. Is there something wrong with this?



 Promise.all(myArray.map((obj) => {
this.someFunction(obj);
}))


Here's the function I call..



someFunction(){
return new Promise(function (resolve, reject) {
....
reject()
})}









share|improve this question














I'm having a hard time trying to stop the loop in promise.all if one promise rejects it. Here's how I did it. Is there something wrong with this?



 Promise.all(myArray.map((obj) => {
this.someFunction(obj);
}))


Here's the function I call..



someFunction(){
return new Promise(function (resolve, reject) {
....
reject()
})}






react-native promise






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 22 '18 at 11:18









kkumberkkumber

167




167








  • 1





    Promise.all does not "loop" anything

    – Bergi
    Nov 22 '18 at 13:24











  • The map returns an array and it is created "instantly", Promise.all will resolve if all promises in the array are resolved and will reject if one rejects. What exactly are you trying to achieve?

    – koox00
    Nov 22 '18 at 14:54
















  • 1





    Promise.all does not "loop" anything

    – Bergi
    Nov 22 '18 at 13:24











  • The map returns an array and it is created "instantly", Promise.all will resolve if all promises in the array are resolved and will reject if one rejects. What exactly are you trying to achieve?

    – koox00
    Nov 22 '18 at 14:54










1




1





Promise.all does not "loop" anything

– Bergi
Nov 22 '18 at 13:24





Promise.all does not "loop" anything

– Bergi
Nov 22 '18 at 13:24













The map returns an array and it is created "instantly", Promise.all will resolve if all promises in the array are resolved and will reject if one rejects. What exactly are you trying to achieve?

– koox00
Nov 22 '18 at 14:54







The map returns an array and it is created "instantly", Promise.all will resolve if all promises in the array are resolved and will reject if one rejects. What exactly are you trying to achieve?

– koox00
Nov 22 '18 at 14:54














2 Answers
2






active

oldest

votes


















0














I have updated my code, it is tested and it works on my machine with the mock data I feed it with. I am not exactly sure how the rest of your code is structured but it is something likes this: Oh and you cannot break out of a map, but we will use a simple for loop because we can break out of that:



function someFunction(){
return new Promise(function (resolve, reject) {
// I will be rejeccting a boolean
// If you are resolving something, resolve it as true
reject(false)
})}


async function shouldStopLoop(){

// the boolean will come here
// if it is false, the catch block will return
// if it is true, the try block will return

let stopLoop = null;
let result = null;

try {
result = await someFunction();
return result
} catch(error) {
stopLoop = error;
return stopLoop;
}
}

function mayReturnPromiseAll() {

let myArray = ['stuf to loop over...']
let arraytoGoInPrimiseAll = ;


// Array.prototype.map cannot be stopped
// Thats why we will use a for loop and we will push the data we need
// into another array
for (var i = 0; i < myArray.length; i++) {
if (!this.someFunction(obj)) {
break;
} else {
// push things in arraytoGoInPrimiseAll
}
}

if(arraytoGoInPrimiseAll.length > 0){
return Promise.all(arraytoGoInPrimiseAll)
} else {
// do something else
}

};





share|improve this answer


























  • still works the same. I'm expecting to stop the loop once the promise encountered rejection. Is there a way for this?

    – kkumber
    Nov 22 '18 at 12:52



















0














Try this:



const arrayOfFunctions = myArray.map(obj => this.someFunction(obj))
Promise.all(arrayOfFunctions).then(values => {
console.log(values);
}).catch(error => {
console.log(error)
});





share|improve this answer























    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53429800%2fhow-to-stop-promise-all-loop-when-it-rejects%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    2 Answers
    2






    active

    oldest

    votes








    2 Answers
    2






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    0














    I have updated my code, it is tested and it works on my machine with the mock data I feed it with. I am not exactly sure how the rest of your code is structured but it is something likes this: Oh and you cannot break out of a map, but we will use a simple for loop because we can break out of that:



    function someFunction(){
    return new Promise(function (resolve, reject) {
    // I will be rejeccting a boolean
    // If you are resolving something, resolve it as true
    reject(false)
    })}


    async function shouldStopLoop(){

    // the boolean will come here
    // if it is false, the catch block will return
    // if it is true, the try block will return

    let stopLoop = null;
    let result = null;

    try {
    result = await someFunction();
    return result
    } catch(error) {
    stopLoop = error;
    return stopLoop;
    }
    }

    function mayReturnPromiseAll() {

    let myArray = ['stuf to loop over...']
    let arraytoGoInPrimiseAll = ;


    // Array.prototype.map cannot be stopped
    // Thats why we will use a for loop and we will push the data we need
    // into another array
    for (var i = 0; i < myArray.length; i++) {
    if (!this.someFunction(obj)) {
    break;
    } else {
    // push things in arraytoGoInPrimiseAll
    }
    }

    if(arraytoGoInPrimiseAll.length > 0){
    return Promise.all(arraytoGoInPrimiseAll)
    } else {
    // do something else
    }

    };





    share|improve this answer


























    • still works the same. I'm expecting to stop the loop once the promise encountered rejection. Is there a way for this?

      – kkumber
      Nov 22 '18 at 12:52
















    0














    I have updated my code, it is tested and it works on my machine with the mock data I feed it with. I am not exactly sure how the rest of your code is structured but it is something likes this: Oh and you cannot break out of a map, but we will use a simple for loop because we can break out of that:



    function someFunction(){
    return new Promise(function (resolve, reject) {
    // I will be rejeccting a boolean
    // If you are resolving something, resolve it as true
    reject(false)
    })}


    async function shouldStopLoop(){

    // the boolean will come here
    // if it is false, the catch block will return
    // if it is true, the try block will return

    let stopLoop = null;
    let result = null;

    try {
    result = await someFunction();
    return result
    } catch(error) {
    stopLoop = error;
    return stopLoop;
    }
    }

    function mayReturnPromiseAll() {

    let myArray = ['stuf to loop over...']
    let arraytoGoInPrimiseAll = ;


    // Array.prototype.map cannot be stopped
    // Thats why we will use a for loop and we will push the data we need
    // into another array
    for (var i = 0; i < myArray.length; i++) {
    if (!this.someFunction(obj)) {
    break;
    } else {
    // push things in arraytoGoInPrimiseAll
    }
    }

    if(arraytoGoInPrimiseAll.length > 0){
    return Promise.all(arraytoGoInPrimiseAll)
    } else {
    // do something else
    }

    };





    share|improve this answer


























    • still works the same. I'm expecting to stop the loop once the promise encountered rejection. Is there a way for this?

      – kkumber
      Nov 22 '18 at 12:52














    0












    0








    0







    I have updated my code, it is tested and it works on my machine with the mock data I feed it with. I am not exactly sure how the rest of your code is structured but it is something likes this: Oh and you cannot break out of a map, but we will use a simple for loop because we can break out of that:



    function someFunction(){
    return new Promise(function (resolve, reject) {
    // I will be rejeccting a boolean
    // If you are resolving something, resolve it as true
    reject(false)
    })}


    async function shouldStopLoop(){

    // the boolean will come here
    // if it is false, the catch block will return
    // if it is true, the try block will return

    let stopLoop = null;
    let result = null;

    try {
    result = await someFunction();
    return result
    } catch(error) {
    stopLoop = error;
    return stopLoop;
    }
    }

    function mayReturnPromiseAll() {

    let myArray = ['stuf to loop over...']
    let arraytoGoInPrimiseAll = ;


    // Array.prototype.map cannot be stopped
    // Thats why we will use a for loop and we will push the data we need
    // into another array
    for (var i = 0; i < myArray.length; i++) {
    if (!this.someFunction(obj)) {
    break;
    } else {
    // push things in arraytoGoInPrimiseAll
    }
    }

    if(arraytoGoInPrimiseAll.length > 0){
    return Promise.all(arraytoGoInPrimiseAll)
    } else {
    // do something else
    }

    };





    share|improve this answer















    I have updated my code, it is tested and it works on my machine with the mock data I feed it with. I am not exactly sure how the rest of your code is structured but it is something likes this: Oh and you cannot break out of a map, but we will use a simple for loop because we can break out of that:



    function someFunction(){
    return new Promise(function (resolve, reject) {
    // I will be rejeccting a boolean
    // If you are resolving something, resolve it as true
    reject(false)
    })}


    async function shouldStopLoop(){

    // the boolean will come here
    // if it is false, the catch block will return
    // if it is true, the try block will return

    let stopLoop = null;
    let result = null;

    try {
    result = await someFunction();
    return result
    } catch(error) {
    stopLoop = error;
    return stopLoop;
    }
    }

    function mayReturnPromiseAll() {

    let myArray = ['stuf to loop over...']
    let arraytoGoInPrimiseAll = ;


    // Array.prototype.map cannot be stopped
    // Thats why we will use a for loop and we will push the data we need
    // into another array
    for (var i = 0; i < myArray.length; i++) {
    if (!this.someFunction(obj)) {
    break;
    } else {
    // push things in arraytoGoInPrimiseAll
    }
    }

    if(arraytoGoInPrimiseAll.length > 0){
    return Promise.all(arraytoGoInPrimiseAll)
    } else {
    // do something else
    }

    };






    share|improve this answer














    share|improve this answer



    share|improve this answer








    edited Nov 22 '18 at 15:16

























    answered Nov 22 '18 at 11:30









    squeekyDavesqueekyDave

    407215




    407215













    • still works the same. I'm expecting to stop the loop once the promise encountered rejection. Is there a way for this?

      – kkumber
      Nov 22 '18 at 12:52



















    • still works the same. I'm expecting to stop the loop once the promise encountered rejection. Is there a way for this?

      – kkumber
      Nov 22 '18 at 12:52

















    still works the same. I'm expecting to stop the loop once the promise encountered rejection. Is there a way for this?

    – kkumber
    Nov 22 '18 at 12:52





    still works the same. I'm expecting to stop the loop once the promise encountered rejection. Is there a way for this?

    – kkumber
    Nov 22 '18 at 12:52













    0














    Try this:



    const arrayOfFunctions = myArray.map(obj => this.someFunction(obj))
    Promise.all(arrayOfFunctions).then(values => {
    console.log(values);
    }).catch(error => {
    console.log(error)
    });





    share|improve this answer




























      0














      Try this:



      const arrayOfFunctions = myArray.map(obj => this.someFunction(obj))
      Promise.all(arrayOfFunctions).then(values => {
      console.log(values);
      }).catch(error => {
      console.log(error)
      });





      share|improve this answer


























        0












        0








        0







        Try this:



        const arrayOfFunctions = myArray.map(obj => this.someFunction(obj))
        Promise.all(arrayOfFunctions).then(values => {
        console.log(values);
        }).catch(error => {
        console.log(error)
        });





        share|improve this answer













        Try this:



        const arrayOfFunctions = myArray.map(obj => this.someFunction(obj))
        Promise.all(arrayOfFunctions).then(values => {
        console.log(values);
        }).catch(error => {
        console.log(error)
        });






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 22 '18 at 23:12









        DiamantDiamant

        10817




        10817






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53429800%2fhow-to-stop-promise-all-loop-when-it-rejects%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Costa Masnaga

            Fotorealismo

            Sidney Franklin