Turning nested jQuery Promises into flat code structure using .done() and .then()











up vote
0
down vote

favorite












This code uses jQuery promises in combination with callbacks does the following:




  1. Saves Group UUID to server using storeGroupOnServer()

  2. Creates a DOM element for the group using createGroupDomNode()

  3. Creates child elements for each image, using createNewChildDomNode()


How can this be written more flat (avoiding the nesting), using .then()?



groupPromise.done(function(fileGroupInfo) {
storeGroupOnServer(fileGroupInfo.uuid, function(groupid){

createGroupDomNode(groupid, function(groupnode){

$.each(arrayOfFiles, function(i, file) {
file.done(function(fileInfo) {
createNewChildDomNode(fileInfo.cdnUrl, groupnode);
});
});
});
});
});


Step 1: storeGroupOnServer():



storeGroupOnServer = function(uuid, callback) {
$.post('saveGroup.php', {uuid:uuid},
function(data) {
callback(data.groupid);
},'json');
};


Step 2: createGroupDomNode():



createGroupDomNode = function(groupid, callback) {
var cloner = $('#cloner');
var newnode = cloner.clone(true);
newnode.attr('id',groupid);
newnode.removeClass('hide');
cloner.after(newnode);
callback(newnode);
}


Step 3: createNewChildDomNode():



function createNewChildDomNode(imgpath, groupdom){
imgnode = $('<img/>').attr('src',imgpath);
picnode = $('<picture/>').append(imgnode);
$(groupdom).first().prepend(picnode);
}









share|improve this question




























    up vote
    0
    down vote

    favorite












    This code uses jQuery promises in combination with callbacks does the following:




    1. Saves Group UUID to server using storeGroupOnServer()

    2. Creates a DOM element for the group using createGroupDomNode()

    3. Creates child elements for each image, using createNewChildDomNode()


    How can this be written more flat (avoiding the nesting), using .then()?



    groupPromise.done(function(fileGroupInfo) {
    storeGroupOnServer(fileGroupInfo.uuid, function(groupid){

    createGroupDomNode(groupid, function(groupnode){

    $.each(arrayOfFiles, function(i, file) {
    file.done(function(fileInfo) {
    createNewChildDomNode(fileInfo.cdnUrl, groupnode);
    });
    });
    });
    });
    });


    Step 1: storeGroupOnServer():



    storeGroupOnServer = function(uuid, callback) {
    $.post('saveGroup.php', {uuid:uuid},
    function(data) {
    callback(data.groupid);
    },'json');
    };


    Step 2: createGroupDomNode():



    createGroupDomNode = function(groupid, callback) {
    var cloner = $('#cloner');
    var newnode = cloner.clone(true);
    newnode.attr('id',groupid);
    newnode.removeClass('hide');
    cloner.after(newnode);
    callback(newnode);
    }


    Step 3: createNewChildDomNode():



    function createNewChildDomNode(imgpath, groupdom){
    imgnode = $('<img/>').attr('src',imgpath);
    picnode = $('<picture/>').append(imgnode);
    $(groupdom).first().prepend(picnode);
    }









    share|improve this question


























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      This code uses jQuery promises in combination with callbacks does the following:




      1. Saves Group UUID to server using storeGroupOnServer()

      2. Creates a DOM element for the group using createGroupDomNode()

      3. Creates child elements for each image, using createNewChildDomNode()


      How can this be written more flat (avoiding the nesting), using .then()?



      groupPromise.done(function(fileGroupInfo) {
      storeGroupOnServer(fileGroupInfo.uuid, function(groupid){

      createGroupDomNode(groupid, function(groupnode){

      $.each(arrayOfFiles, function(i, file) {
      file.done(function(fileInfo) {
      createNewChildDomNode(fileInfo.cdnUrl, groupnode);
      });
      });
      });
      });
      });


      Step 1: storeGroupOnServer():



      storeGroupOnServer = function(uuid, callback) {
      $.post('saveGroup.php', {uuid:uuid},
      function(data) {
      callback(data.groupid);
      },'json');
      };


      Step 2: createGroupDomNode():



      createGroupDomNode = function(groupid, callback) {
      var cloner = $('#cloner');
      var newnode = cloner.clone(true);
      newnode.attr('id',groupid);
      newnode.removeClass('hide');
      cloner.after(newnode);
      callback(newnode);
      }


      Step 3: createNewChildDomNode():



      function createNewChildDomNode(imgpath, groupdom){
      imgnode = $('<img/>').attr('src',imgpath);
      picnode = $('<picture/>').append(imgnode);
      $(groupdom).first().prepend(picnode);
      }









      share|improve this question















      This code uses jQuery promises in combination with callbacks does the following:




      1. Saves Group UUID to server using storeGroupOnServer()

      2. Creates a DOM element for the group using createGroupDomNode()

      3. Creates child elements for each image, using createNewChildDomNode()


      How can this be written more flat (avoiding the nesting), using .then()?



      groupPromise.done(function(fileGroupInfo) {
      storeGroupOnServer(fileGroupInfo.uuid, function(groupid){

      createGroupDomNode(groupid, function(groupnode){

      $.each(arrayOfFiles, function(i, file) {
      file.done(function(fileInfo) {
      createNewChildDomNode(fileInfo.cdnUrl, groupnode);
      });
      });
      });
      });
      });


      Step 1: storeGroupOnServer():



      storeGroupOnServer = function(uuid, callback) {
      $.post('saveGroup.php', {uuid:uuid},
      function(data) {
      callback(data.groupid);
      },'json');
      };


      Step 2: createGroupDomNode():



      createGroupDomNode = function(groupid, callback) {
      var cloner = $('#cloner');
      var newnode = cloner.clone(true);
      newnode.attr('id',groupid);
      newnode.removeClass('hide');
      cloner.after(newnode);
      callback(newnode);
      }


      Step 3: createNewChildDomNode():



      function createNewChildDomNode(imgpath, groupdom){
      imgnode = $('<img/>').attr('src',imgpath);
      picnode = $('<picture/>').append(imgnode);
      $(groupdom).first().prepend(picnode);
      }






      javascript jquery promise






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 1 hour ago









      Jamal

      30.2k11115226




      30.2k11115226










      asked 12 hours ago









      bart

      1268




      1268



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














           

          draft saved


          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f207833%2fturning-nested-jquery-promises-into-flat-code-structure-using-done-and-then%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















           

          draft saved


          draft discarded



















































           


          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f207833%2fturning-nested-jquery-promises-into-flat-code-structure-using-done-and-then%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Costa Masnaga

          Fotorealismo

          Sidney Franklin