Greatest Common Divisor program
up vote
0
down vote
favorite
I had a program test me on code written and executed in the browser. The test cases were all hidden, and I passed 9 out of 13 test cases that were hidden.
I used a library feature when my time was running out to see if I was just crazy. Sure enough, the test with the library example passed all 13 tests.
The problem was asking to implement a GCD program on an array of positive integers. I did checks on the data types and to validate the entries that were coming in. Assume that we only have working examples and zero is not positive. Assume num
is not less than zero.
I will run benchmarks to see if there is a drastic difference...
NOTE: The tests are Python 2.7 specific.
def mGCD(num, arr):
#Python3 and Python2 executable
workthese = arr[:num]
smallest = min(workthese)
if smallest == 0:
return None
if smallest == 1:
return 1
for i in range(0, num):
if workthese[i]%smallest != 0:
break
if i == num-1:
return smallest
return 1
def pGCD(num, arr):
#Python2 executable
'''
Equivalent to:
>>> lis = (30,40,60,70)
>>> res = gcd(*lis[:2]) #get the gcd of first two numbers
>>> for x in lis[2:]: #now iterate over the list starting from the 3rd element
... res = gcd(res,x)
>>> res
10
'''
from fractions import gcd
workthese = arr[:num]
return reduce(gcd,(workthese))
if __name__ == "__main__":
assert mGCD(1, [2,4,6]) == 2
assert mGCD(3, [2,4,6]) == 2
assert mGCD(3, [6,4,2]) == 2
assert mGCD(2, [2,4,5]) == 2
assert mGCD(2, [13,39]) == 13
assert mGCD(2, [39,13]) == 13
assert mGCD(2, [39,13,1]) == 13
assert pGCD(1, [2,4,6]) == 2
assert pGCD(3, [2,4,6]) == 2
assert pGCD(3, [6,4,2]) == 2
assert pGCD(2, [2,4,5]) == 2
assert pGCD(2, [13,39]) == 13
assert pGCD(2, [39,13]) == 13
assert pGCD(2, [39,13,1]) == 13
python python-2.x
add a comment |
up vote
0
down vote
favorite
I had a program test me on code written and executed in the browser. The test cases were all hidden, and I passed 9 out of 13 test cases that were hidden.
I used a library feature when my time was running out to see if I was just crazy. Sure enough, the test with the library example passed all 13 tests.
The problem was asking to implement a GCD program on an array of positive integers. I did checks on the data types and to validate the entries that were coming in. Assume that we only have working examples and zero is not positive. Assume num
is not less than zero.
I will run benchmarks to see if there is a drastic difference...
NOTE: The tests are Python 2.7 specific.
def mGCD(num, arr):
#Python3 and Python2 executable
workthese = arr[:num]
smallest = min(workthese)
if smallest == 0:
return None
if smallest == 1:
return 1
for i in range(0, num):
if workthese[i]%smallest != 0:
break
if i == num-1:
return smallest
return 1
def pGCD(num, arr):
#Python2 executable
'''
Equivalent to:
>>> lis = (30,40,60,70)
>>> res = gcd(*lis[:2]) #get the gcd of first two numbers
>>> for x in lis[2:]: #now iterate over the list starting from the 3rd element
... res = gcd(res,x)
>>> res
10
'''
from fractions import gcd
workthese = arr[:num]
return reduce(gcd,(workthese))
if __name__ == "__main__":
assert mGCD(1, [2,4,6]) == 2
assert mGCD(3, [2,4,6]) == 2
assert mGCD(3, [6,4,2]) == 2
assert mGCD(2, [2,4,5]) == 2
assert mGCD(2, [13,39]) == 13
assert mGCD(2, [39,13]) == 13
assert mGCD(2, [39,13,1]) == 13
assert pGCD(1, [2,4,6]) == 2
assert pGCD(3, [2,4,6]) == 2
assert pGCD(3, [6,4,2]) == 2
assert pGCD(2, [2,4,5]) == 2
assert pGCD(2, [13,39]) == 13
assert pGCD(2, [39,13]) == 13
assert pGCD(2, [39,13,1]) == 13
python python-2.x
1
assert mGCD(2, [4,6]) == 2
– Michael Butscher
2 hours ago
@michaelButscher you're so right... 🤦♂️
– T.Woody
1 hour ago
@l0b0 run it in 2.7 ...
– T.Woody
1 hour ago
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
I had a program test me on code written and executed in the browser. The test cases were all hidden, and I passed 9 out of 13 test cases that were hidden.
I used a library feature when my time was running out to see if I was just crazy. Sure enough, the test with the library example passed all 13 tests.
The problem was asking to implement a GCD program on an array of positive integers. I did checks on the data types and to validate the entries that were coming in. Assume that we only have working examples and zero is not positive. Assume num
is not less than zero.
I will run benchmarks to see if there is a drastic difference...
NOTE: The tests are Python 2.7 specific.
def mGCD(num, arr):
#Python3 and Python2 executable
workthese = arr[:num]
smallest = min(workthese)
if smallest == 0:
return None
if smallest == 1:
return 1
for i in range(0, num):
if workthese[i]%smallest != 0:
break
if i == num-1:
return smallest
return 1
def pGCD(num, arr):
#Python2 executable
'''
Equivalent to:
>>> lis = (30,40,60,70)
>>> res = gcd(*lis[:2]) #get the gcd of first two numbers
>>> for x in lis[2:]: #now iterate over the list starting from the 3rd element
... res = gcd(res,x)
>>> res
10
'''
from fractions import gcd
workthese = arr[:num]
return reduce(gcd,(workthese))
if __name__ == "__main__":
assert mGCD(1, [2,4,6]) == 2
assert mGCD(3, [2,4,6]) == 2
assert mGCD(3, [6,4,2]) == 2
assert mGCD(2, [2,4,5]) == 2
assert mGCD(2, [13,39]) == 13
assert mGCD(2, [39,13]) == 13
assert mGCD(2, [39,13,1]) == 13
assert pGCD(1, [2,4,6]) == 2
assert pGCD(3, [2,4,6]) == 2
assert pGCD(3, [6,4,2]) == 2
assert pGCD(2, [2,4,5]) == 2
assert pGCD(2, [13,39]) == 13
assert pGCD(2, [39,13]) == 13
assert pGCD(2, [39,13,1]) == 13
python python-2.x
I had a program test me on code written and executed in the browser. The test cases were all hidden, and I passed 9 out of 13 test cases that were hidden.
I used a library feature when my time was running out to see if I was just crazy. Sure enough, the test with the library example passed all 13 tests.
The problem was asking to implement a GCD program on an array of positive integers. I did checks on the data types and to validate the entries that were coming in. Assume that we only have working examples and zero is not positive. Assume num
is not less than zero.
I will run benchmarks to see if there is a drastic difference...
NOTE: The tests are Python 2.7 specific.
def mGCD(num, arr):
#Python3 and Python2 executable
workthese = arr[:num]
smallest = min(workthese)
if smallest == 0:
return None
if smallest == 1:
return 1
for i in range(0, num):
if workthese[i]%smallest != 0:
break
if i == num-1:
return smallest
return 1
def pGCD(num, arr):
#Python2 executable
'''
Equivalent to:
>>> lis = (30,40,60,70)
>>> res = gcd(*lis[:2]) #get the gcd of first two numbers
>>> for x in lis[2:]: #now iterate over the list starting from the 3rd element
... res = gcd(res,x)
>>> res
10
'''
from fractions import gcd
workthese = arr[:num]
return reduce(gcd,(workthese))
if __name__ == "__main__":
assert mGCD(1, [2,4,6]) == 2
assert mGCD(3, [2,4,6]) == 2
assert mGCD(3, [6,4,2]) == 2
assert mGCD(2, [2,4,5]) == 2
assert mGCD(2, [13,39]) == 13
assert mGCD(2, [39,13]) == 13
assert mGCD(2, [39,13,1]) == 13
assert pGCD(1, [2,4,6]) == 2
assert pGCD(3, [2,4,6]) == 2
assert pGCD(3, [6,4,2]) == 2
assert pGCD(2, [2,4,5]) == 2
assert pGCD(2, [13,39]) == 13
assert pGCD(2, [39,13]) == 13
assert pGCD(2, [39,13,1]) == 13
python python-2.x
python python-2.x
edited 5 mins ago
Jamal♦
30.2k11115226
30.2k11115226
asked 3 hours ago
T.Woody
1094
1094
1
assert mGCD(2, [4,6]) == 2
– Michael Butscher
2 hours ago
@michaelButscher you're so right... 🤦♂️
– T.Woody
1 hour ago
@l0b0 run it in 2.7 ...
– T.Woody
1 hour ago
add a comment |
1
assert mGCD(2, [4,6]) == 2
– Michael Butscher
2 hours ago
@michaelButscher you're so right... 🤦♂️
– T.Woody
1 hour ago
@l0b0 run it in 2.7 ...
– T.Woody
1 hour ago
1
1
assert mGCD(2, [4,6]) == 2
– Michael Butscher
2 hours ago
assert mGCD(2, [4,6]) == 2
– Michael Butscher
2 hours ago
@michaelButscher you're so right... 🤦♂️
– T.Woody
1 hour ago
@michaelButscher you're so right... 🤦♂️
– T.Woody
1 hour ago
@l0b0 run it in 2.7 ...
– T.Woody
1 hour ago
@l0b0 run it in 2.7 ...
– T.Woody
1 hour ago
add a comment |
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208966%2fgreatest-common-divisor-program%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
assert mGCD(2, [4,6]) == 2
– Michael Butscher
2 hours ago
@michaelButscher you're so right... 🤦♂️
– T.Woody
1 hour ago
@l0b0 run it in 2.7 ...
– T.Woody
1 hour ago