Python merge sort











up vote
0
down vote

favorite












In Algorithms Fourth Edition by Robert Sedgewick and Kevin Wayne, the exercise 2.2.10 states that:




Implement a version of merge() that copies the second half of a to
aux in decreasing order and then does the merge back to a. This
change al- lows you to remove the code to test that each of the halves
has been exhausted from the inner loop.




This is my code in Python:



def merge(a, lo, mi, hi): 
aux_hi = deque(a[mi:hi])
for i in range(lo, hi)[::-1]:
if aux_hi:
last_a = i-len(aux_hi)
if last_a < lo:
a[i] = aux_hi.pop()
else:
a[i] = aux_hi.pop() if aux_hi[-1] > a[last_a] else a[last_a]
else:
break


Have I implemented it as required? Or can it be improved further?










share|improve this question




























    up vote
    0
    down vote

    favorite












    In Algorithms Fourth Edition by Robert Sedgewick and Kevin Wayne, the exercise 2.2.10 states that:




    Implement a version of merge() that copies the second half of a to
    aux in decreasing order and then does the merge back to a. This
    change al- lows you to remove the code to test that each of the halves
    has been exhausted from the inner loop.




    This is my code in Python:



    def merge(a, lo, mi, hi): 
    aux_hi = deque(a[mi:hi])
    for i in range(lo, hi)[::-1]:
    if aux_hi:
    last_a = i-len(aux_hi)
    if last_a < lo:
    a[i] = aux_hi.pop()
    else:
    a[i] = aux_hi.pop() if aux_hi[-1] > a[last_a] else a[last_a]
    else:
    break


    Have I implemented it as required? Or can it be improved further?










    share|improve this question


























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      In Algorithms Fourth Edition by Robert Sedgewick and Kevin Wayne, the exercise 2.2.10 states that:




      Implement a version of merge() that copies the second half of a to
      aux in decreasing order and then does the merge back to a. This
      change al- lows you to remove the code to test that each of the halves
      has been exhausted from the inner loop.




      This is my code in Python:



      def merge(a, lo, mi, hi): 
      aux_hi = deque(a[mi:hi])
      for i in range(lo, hi)[::-1]:
      if aux_hi:
      last_a = i-len(aux_hi)
      if last_a < lo:
      a[i] = aux_hi.pop()
      else:
      a[i] = aux_hi.pop() if aux_hi[-1] > a[last_a] else a[last_a]
      else:
      break


      Have I implemented it as required? Or can it be improved further?










      share|improve this question















      In Algorithms Fourth Edition by Robert Sedgewick and Kevin Wayne, the exercise 2.2.10 states that:




      Implement a version of merge() that copies the second half of a to
      aux in decreasing order and then does the merge back to a. This
      change al- lows you to remove the code to test that each of the halves
      has been exhausted from the inner loop.




      This is my code in Python:



      def merge(a, lo, mi, hi): 
      aux_hi = deque(a[mi:hi])
      for i in range(lo, hi)[::-1]:
      if aux_hi:
      last_a = i-len(aux_hi)
      if last_a < lo:
      a[i] = aux_hi.pop()
      else:
      a[i] = aux_hi.pop() if aux_hi[-1] > a[last_a] else a[last_a]
      else:
      break


      Have I implemented it as required? Or can it be improved further?







      python algorithm sorting mergesort






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 8 mins ago









      Jamal

      30.2k11115226




      30.2k11115226










      asked 6 hours ago









      lerner

      1265




      1265



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209702%2fpython-merge-sort%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209702%2fpython-merge-sort%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Costa Masnaga

          Fotorealismo

          Sidney Franklin