TicTacToe endgame feedback in C#
0
$begingroup$
I'm learning C# and currently having an assignment on Tic Tac Toe. I'd love to have some feedback on where I can improve.
I've managed to create the end game functions but I feel it could be improved. I'm just not sure how to do it and was hoping someone here could help me.
I hope the information I've provided is enough, this.cells is a multidimensional array containing the Cell objects:
/// <summary>
/// Contains info about what kind of cell we're dealing with
/// </summary>
public enum Cell {
Empty,
Circle,
Cross
}
Below is the part I'm searching feedback on. Too many if statements? What could I have done different or better?
/// <summary>
/// Check all possible combinations for the target cell
/// of winning the game (row, column, or slope).
///
/// Returns true if there is a win condition, false if there isn't.
/// </summary>
private bool IsGameOver(Cell cell) {
// Row 1
if (this.cells[0, 0] == cell && this.cells[0, 1] == cell && this.cells[0, 2] == cell) {
return true;
}
// Row 2
if (this.cells[1, 0] == cell && this.cells[1, 1] == cell && this.cells[1, 2] == cell) {
return true;
}
// Row 3
if (this.cells[2, 0] == cell && this.cells[2, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Clm 1
if (this.cells[0, 0] == cell && this.cells[1, 0] == cell && this.cells[2, 0] == cell) {
return true;
}
// Clm 2
if (this.cells[1, 0] == cell && this.cells[1, 1] == cell && this.cells[1, 2] == cell) {
return true;
}
// Clm 3
if (this.cells[2, 0] == cell && this.cells[2, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Horizontal line 1
if (this.cells[0, 0] == cell && this.cells[1, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Horizontal line 2
if (this.cells[0, 2] == cell && this.cells[1, 1] == cell && this.cells[2, 0] == cell) {
return true;
}
return false;
}
c#
asked 7 mins ago
jubibannajubibanna
101
New contributor
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I'm learning C# and currently having an assignment on Tic Tac Toe. I'd love to have some feedback on where I can improve.
I've managed to create the end game functions but I feel it could be improved. I'm just not sure how to do it and was hoping someone here could help me.
I hope the information I've provided is enough, this.cells is a multidimensional array containing the Cell objects:
/// <summary>
/// Contains info about what kind of cell we're dealing with
/// </summary>
public enum Cell {
Empty,
Circle,
Cross
}
Below is the part I'm searching feedback on. Too many if statements? What could I have done different or better?
/// <summary>
/// Check all possible combinations for the target cell
/// of winning the game (row, column, or slope).
///
/// Returns true if there is a win condition, false if there isn't.
/// </summary>
private bool IsGameOver(Cell cell) {
// Row 1
if (this.cells[0, 0] == cell && this.cells[0, 1] == cell && this.cells[0, 2] == cell) {
return true;
}
// Row 2
if (this.cells[1, 0] == cell && this.cells[1, 1] == cell && this.cells[1, 2] == cell) {
return true;
}
// Row 3
if (this.cells[2, 0] == cell && this.cells[2, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Clm 1
if (this.cells[0, 0] == cell && this.cells[1, 0] == cell && this.cells[2, 0] == cell) {
return true;
}
// Clm 2
if (this.cells[1, 0] == cell && this.cells[1, 1] == cell && this.cells[1, 2] == cell) {
return true;
}
// Clm 3
if (this.cells[2, 0] == cell && this.cells[2, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Horizontal line 1
if (this.cells[0, 0] == cell && this.cells[1, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Horizontal line 2
if (this.cells[0, 2] == cell && this.cells[1, 1] == cell && this.cells[2, 0] == cell) {
return true;
}
return false;
}
c#
asked 7 mins ago
jubibannajubibanna
101
New contributor
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I'm learning C# and currently having an assignment on Tic Tac Toe. I'd love to have some feedback on where I can improve.
I've managed to create the end game functions but I feel it could be improved. I'm just not sure how to do it and was hoping someone here could help me.
I hope the information I've provided is enough, this.cells is a multidimensional array containing the Cell objects:
/// <summary>
/// Contains info about what kind of cell we're dealing with
/// </summary>
public enum Cell {
Empty,
Circle,
Cross
}
Below is the part I'm searching feedback on. Too many if statements? What could I have done different or better?
/// <summary>
/// Check all possible combinations for the target cell
/// of winning the game (row, column, or slope).
///
/// Returns true if there is a win condition, false if there isn't.
/// </summary>
private bool IsGameOver(Cell cell) {
// Row 1
if (this.cells[0, 0] == cell && this.cells[0, 1] == cell && this.cells[0, 2] == cell) {
return true;
}
// Row 2
if (this.cells[1, 0] == cell && this.cells[1, 1] == cell && this.cells[1, 2] == cell) {
return true;
}
// Row 3
if (this.cells[2, 0] == cell && this.cells[2, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Clm 1
if (this.cells[0, 0] == cell && this.cells[1, 0] == cell && this.cells[2, 0] == cell) {
return true;
}
// Clm 2
if (this.cells[1, 0] == cell && this.cells[1, 1] == cell && this.cells[1, 2] == cell) {
return true;
}
// Clm 3
if (this.cells[2, 0] == cell && this.cells[2, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Horizontal line 1
if (this.cells[0, 0] == cell && this.cells[1, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Horizontal line 2
if (this.cells[0, 2] == cell && this.cells[1, 1] == cell && this.cells[2, 0] == cell) {
return true;
}
return false;
}
c#
asked 7 mins ago
jubibannajubibanna
101
New contributor
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I'm learning C# and currently having an assignment on Tic Tac Toe. I'd love to have some feedback on where I can improve.
I've managed to create the end game functions but I feel it could be improved. I'm just not sure how to do it and was hoping someone here could help me.
I hope the information I've provided is enough, this.cells is a multidimensional array containing the Cell objects:
/// <summary>
/// Contains info about what kind of cell we're dealing with
/// </summary>
public enum Cell {
Empty,
Circle,
Cross
}
Below is the part I'm searching feedback on. Too many if statements? What could I have done different or better?
/// <summary>
/// Check all possible combinations for the target cell
/// of winning the game (row, column, or slope).
///
/// Returns true if there is a win condition, false if there isn't.
/// </summary>
private bool IsGameOver(Cell cell) {
// Row 1
if (this.cells[0, 0] == cell && this.cells[0, 1] == cell && this.cells[0, 2] == cell) {
return true;
}
// Row 2
if (this.cells[1, 0] == cell && this.cells[1, 1] == cell && this.cells[1, 2] == cell) {
return true;
}
// Row 3
if (this.cells[2, 0] == cell && this.cells[2, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Clm 1
if (this.cells[0, 0] == cell && this.cells[1, 0] == cell && this.cells[2, 0] == cell) {
return true;
}
// Clm 2
if (this.cells[1, 0] == cell && this.cells[1, 1] == cell && this.cells[1, 2] == cell) {
return true;
}
// Clm 3
if (this.cells[2, 0] == cell && this.cells[2, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Horizontal line 1
if (this.cells[0, 0] == cell && this.cells[1, 1] == cell && this.cells[2, 2] == cell) {
return true;
}
// Horizontal line 2
if (this.cells[0, 2] == cell && this.cells[1, 1] == cell && this.cells[2, 0] == cell) {
return true;
}
return false;
}
c#
c#
asked 7 mins ago
jubibannajubibanna
101
New contributor
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
jubibannajubibanna
101
New contributor
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
jubibannajubibanna
101
New contributor
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 mins ago
jubibannajubibanna
101
asked 7 mins ago
jubibannajubibanna
101
101
New contributor
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
jubibanna is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
jubibanna is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213852%2ftictactoe-endgame-feedback-in-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
jubibanna is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
jubibanna is a new contributor. Be nice, and check out our Code of Conduct.
jubibanna is a new contributor. Be nice, and check out our Code of Conduct.
jubibanna is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213852%2ftictactoe-endgame-feedback-in-c%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
