Can this AJAX + PHP code be improved in terms of security, performance, etc.?
0
$begingroup$
I would like to know if this code follows recommended practices and standards for AJAX/PHP calls.
ajax.js:
function getTableData() {
const xmlhttp = new XMLHttpRequest();
xmlhttp.onreadystatechange = function() {
if (this.readyState === 4 && this.status === 200) {
document.querySelector('#test-table tbody').innerHTML = this.responseText;
}
}
xmlhttp.open('GET', 'ajax.php', true);
xmlhttp.send();
}
$(document).ready(function () {
getTableData();
});
ajax.php:
<?php
$data = prepareDataForTable();
$data_length = count($data);
$columns = 4;
for ($row = 0; $row < $data_length; $row += $columns) {
echo '<tr>';
for ($col = 0; $col < $columns && ($col + $row) < $data_length; $col++) {
echo '<td>' . $data[$col + $row] . '</td>';
}
echo '</tr>';
}
?>
ajax.html:
<table id="test-table">
<tbody>
</tbody>
</table>
I specifically want to know if this is a good way to send information back to the client - by running loops and echoing output.
php ajax
asked 6 mins ago
tera_789tera_789
1011
New contributor
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I would like to know if this code follows recommended practices and standards for AJAX/PHP calls.
ajax.js:
function getTableData() {
const xmlhttp = new XMLHttpRequest();
xmlhttp.onreadystatechange = function() {
if (this.readyState === 4 && this.status === 200) {
document.querySelector('#test-table tbody').innerHTML = this.responseText;
}
}
xmlhttp.open('GET', 'ajax.php', true);
xmlhttp.send();
}
$(document).ready(function () {
getTableData();
});
ajax.php:
<?php
$data = prepareDataForTable();
$data_length = count($data);
$columns = 4;
for ($row = 0; $row < $data_length; $row += $columns) {
echo '<tr>';
for ($col = 0; $col < $columns && ($col + $row) < $data_length; $col++) {
echo '<td>' . $data[$col + $row] . '</td>';
}
echo '</tr>';
}
?>
ajax.html:
<table id="test-table">
<tbody>
</tbody>
</table>
I specifically want to know if this is a good way to send information back to the client - by running loops and echoing output.
php ajax
asked 6 mins ago
tera_789tera_789
1011
New contributor
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I would like to know if this code follows recommended practices and standards for AJAX/PHP calls.
ajax.js:
function getTableData() {
const xmlhttp = new XMLHttpRequest();
xmlhttp.onreadystatechange = function() {
if (this.readyState === 4 && this.status === 200) {
document.querySelector('#test-table tbody').innerHTML = this.responseText;
}
}
xmlhttp.open('GET', 'ajax.php', true);
xmlhttp.send();
}
$(document).ready(function () {
getTableData();
});
ajax.php:
<?php
$data = prepareDataForTable();
$data_length = count($data);
$columns = 4;
for ($row = 0; $row < $data_length; $row += $columns) {
echo '<tr>';
for ($col = 0; $col < $columns && ($col + $row) < $data_length; $col++) {
echo '<td>' . $data[$col + $row] . '</td>';
}
echo '</tr>';
}
?>
ajax.html:
<table id="test-table">
<tbody>
</tbody>
</table>
I specifically want to know if this is a good way to send information back to the client - by running loops and echoing output.
php ajax
asked 6 mins ago
tera_789tera_789
1011
New contributor
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I would like to know if this code follows recommended practices and standards for AJAX/PHP calls.
ajax.js:
function getTableData() {
const xmlhttp = new XMLHttpRequest();
xmlhttp.onreadystatechange = function() {
if (this.readyState === 4 && this.status === 200) {
document.querySelector('#test-table tbody').innerHTML = this.responseText;
}
}
xmlhttp.open('GET', 'ajax.php', true);
xmlhttp.send();
}
$(document).ready(function () {
getTableData();
});
ajax.php:
<?php
$data = prepareDataForTable();
$data_length = count($data);
$columns = 4;
for ($row = 0; $row < $data_length; $row += $columns) {
echo '<tr>';
for ($col = 0; $col < $columns && ($col + $row) < $data_length; $col++) {
echo '<td>' . $data[$col + $row] . '</td>';
}
echo '</tr>';
}
?>
ajax.html:
<table id="test-table">
<tbody>
</tbody>
</table>
I specifically want to know if this is a good way to send information back to the client - by running loops and echoing output.
php ajax
php ajax
asked 6 mins ago
tera_789tera_789
1011
New contributor
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 6 mins ago
tera_789tera_789
1011
New contributor
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 6 mins ago
tera_789tera_789
1011
New contributor
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 6 mins ago
tera_789tera_789
1011
asked 6 mins ago
tera_789tera_789
1011
1011
New contributor
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
tera_789 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
tera_789 is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216572%2fcan-this-ajax-php-code-be-improved-in-terms-of-security-performance-etc%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
tera_789 is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
tera_789 is a new contributor. Be nice, and check out our Code of Conduct.
tera_789 is a new contributor. Be nice, and check out our Code of Conduct.
tera_789 is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216572%2fcan-this-ajax-php-code-be-improved-in-terms-of-security-performance-etc%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
