Optimizing a simple solution












0














The idea is to write a function that takes two strings and returns a new string that repeats in the previous two: examples:



'ABBA' & 'AOHB' => 'AB'
'cohs' & 'ohba' => 'oh'


A brute force solution would be nested for loops like so:






const x = 'ABCD'
const y = 'AHOB'

function subStr(str1, str2) {
let final = ''

for (let i = 0; i < str1.length; i++) {
for (let j = 0; j < str2.length; j++) {
if (str1[i] === str2[j]) {
final += str1[i]
}
}
}

return final
}



console.log(subStr(x, y)) // => AB











share



























    0














    The idea is to write a function that takes two strings and returns a new string that repeats in the previous two: examples:



    'ABBA' & 'AOHB' => 'AB'
    'cohs' & 'ohba' => 'oh'


    A brute force solution would be nested for loops like so:






    const x = 'ABCD'
    const y = 'AHOB'

    function subStr(str1, str2) {
    let final = ''

    for (let i = 0; i < str1.length; i++) {
    for (let j = 0; j < str2.length; j++) {
    if (str1[i] === str2[j]) {
    final += str1[i]
    }
    }
    }

    return final
    }



    console.log(subStr(x, y)) // => AB











    share

























      0












      0








      0







      The idea is to write a function that takes two strings and returns a new string that repeats in the previous two: examples:



      'ABBA' & 'AOHB' => 'AB'
      'cohs' & 'ohba' => 'oh'


      A brute force solution would be nested for loops like so:






      const x = 'ABCD'
      const y = 'AHOB'

      function subStr(str1, str2) {
      let final = ''

      for (let i = 0; i < str1.length; i++) {
      for (let j = 0; j < str2.length; j++) {
      if (str1[i] === str2[j]) {
      final += str1[i]
      }
      }
      }

      return final
      }



      console.log(subStr(x, y)) // => AB











      share













      The idea is to write a function that takes two strings and returns a new string that repeats in the previous two: examples:



      'ABBA' & 'AOHB' => 'AB'
      'cohs' & 'ohba' => 'oh'


      A brute force solution would be nested for loops like so:






      const x = 'ABCD'
      const y = 'AHOB'

      function subStr(str1, str2) {
      let final = ''

      for (let i = 0; i < str1.length; i++) {
      for (let j = 0; j < str2.length; j++) {
      if (str1[i] === str2[j]) {
      final += str1[i]
      }
      }
      }

      return final
      }



      console.log(subStr(x, y)) // => AB








      const x = 'ABCD'
      const y = 'AHOB'

      function subStr(str1, str2) {
      let final = ''

      for (let i = 0; i < str1.length; i++) {
      for (let j = 0; j < str2.length; j++) {
      if (str1[i] === str2[j]) {
      final += str1[i]
      }
      }
      }

      return final
      }



      console.log(subStr(x, y)) // => AB





      const x = 'ABCD'
      const y = 'AHOB'

      function subStr(str1, str2) {
      let final = ''

      for (let i = 0; i < str1.length; i++) {
      for (let j = 0; j < str2.length; j++) {
      if (str1[i] === str2[j]) {
      final += str1[i]
      }
      }
      }

      return final
      }



      console.log(subStr(x, y)) // => AB






      javascript algorithm





      share












      share










      share



      share










      asked 6 mins ago









      SakoBu

      1211




      1211



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210341%2foptimizing-a-simple-solution%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210341%2foptimizing-a-simple-solution%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Costa Masnaga

          Fotorealismo

          Sidney Franklin