How can I change or redo the helper class for insert data from database to pojo?












0












$begingroup$


This is a helper class that helps fill models with data obtained from the database.



public class Util {

public static <M> ArrayList<M> createModel(M model, Cursor cursor) throws IOException {

try {
final Class<?> cls = model.getClass();

final ArrayList<M> result = new ArrayList<>();
while (cursor.next()) {

final Class<?> item = Class.forName(cls.getName());
final M obj = (M) item.newInstance();

final Field fields = item.getDeclaredFields();

for (Field field : fields) {
field.setAccessible(true);

final Class<?> type = field.getType();

switch (type.toString()) {

case "int": {
final int value = cursor.getInt(getFieldName(field), 0);
field.setInt(obj, value);
break;
}

default:
//throw new IOException();
continue;
}
}

result.add(obj);
}

return result;
} catch (IllegalAccessException | InstantiationException | ClassNotFoundException e) {
e.printStackTrace();
throw new IOException();
}
}

private static String getFieldName(Field field) {
final fieldName annotation = field.getDeclaredAnnotation(fieldName.class);
return annotation == null ? field.getName() : annotation.name();
}
}


All code here(pastebin.com)



I think my version is very bad, so I want to improve it, but I haven’t yet figured out how to do it.










share|improve this question







New contributor




MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    This is a helper class that helps fill models with data obtained from the database.



    public class Util {

    public static <M> ArrayList<M> createModel(M model, Cursor cursor) throws IOException {

    try {
    final Class<?> cls = model.getClass();

    final ArrayList<M> result = new ArrayList<>();
    while (cursor.next()) {

    final Class<?> item = Class.forName(cls.getName());
    final M obj = (M) item.newInstance();

    final Field fields = item.getDeclaredFields();

    for (Field field : fields) {
    field.setAccessible(true);

    final Class<?> type = field.getType();

    switch (type.toString()) {

    case "int": {
    final int value = cursor.getInt(getFieldName(field), 0);
    field.setInt(obj, value);
    break;
    }

    default:
    //throw new IOException();
    continue;
    }
    }

    result.add(obj);
    }

    return result;
    } catch (IllegalAccessException | InstantiationException | ClassNotFoundException e) {
    e.printStackTrace();
    throw new IOException();
    }
    }

    private static String getFieldName(Field field) {
    final fieldName annotation = field.getDeclaredAnnotation(fieldName.class);
    return annotation == null ? field.getName() : annotation.name();
    }
    }


    All code here(pastebin.com)



    I think my version is very bad, so I want to improve it, but I haven’t yet figured out how to do it.










    share|improve this question







    New contributor




    MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      This is a helper class that helps fill models with data obtained from the database.



      public class Util {

      public static <M> ArrayList<M> createModel(M model, Cursor cursor) throws IOException {

      try {
      final Class<?> cls = model.getClass();

      final ArrayList<M> result = new ArrayList<>();
      while (cursor.next()) {

      final Class<?> item = Class.forName(cls.getName());
      final M obj = (M) item.newInstance();

      final Field fields = item.getDeclaredFields();

      for (Field field : fields) {
      field.setAccessible(true);

      final Class<?> type = field.getType();

      switch (type.toString()) {

      case "int": {
      final int value = cursor.getInt(getFieldName(field), 0);
      field.setInt(obj, value);
      break;
      }

      default:
      //throw new IOException();
      continue;
      }
      }

      result.add(obj);
      }

      return result;
      } catch (IllegalAccessException | InstantiationException | ClassNotFoundException e) {
      e.printStackTrace();
      throw new IOException();
      }
      }

      private static String getFieldName(Field field) {
      final fieldName annotation = field.getDeclaredAnnotation(fieldName.class);
      return annotation == null ? field.getName() : annotation.name();
      }
      }


      All code here(pastebin.com)



      I think my version is very bad, so I want to improve it, but I haven’t yet figured out how to do it.










      share|improve this question







      New contributor




      MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      This is a helper class that helps fill models with data obtained from the database.



      public class Util {

      public static <M> ArrayList<M> createModel(M model, Cursor cursor) throws IOException {

      try {
      final Class<?> cls = model.getClass();

      final ArrayList<M> result = new ArrayList<>();
      while (cursor.next()) {

      final Class<?> item = Class.forName(cls.getName());
      final M obj = (M) item.newInstance();

      final Field fields = item.getDeclaredFields();

      for (Field field : fields) {
      field.setAccessible(true);

      final Class<?> type = field.getType();

      switch (type.toString()) {

      case "int": {
      final int value = cursor.getInt(getFieldName(field), 0);
      field.setInt(obj, value);
      break;
      }

      default:
      //throw new IOException();
      continue;
      }
      }

      result.add(obj);
      }

      return result;
      } catch (IllegalAccessException | InstantiationException | ClassNotFoundException e) {
      e.printStackTrace();
      throw new IOException();
      }
      }

      private static String getFieldName(Field field) {
      final fieldName annotation = field.getDeclaredAnnotation(fieldName.class);
      return annotation == null ? field.getName() : annotation.name();
      }
      }


      All code here(pastebin.com)



      I think my version is very bad, so I want to improve it, but I haven’t yet figured out how to do it.







      java






      share|improve this question







      New contributor




      MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 16 mins ago









      MadLaxMadLax

      1




      1




      New contributor




      MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      MadLax is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          MadLax is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212121%2fhow-can-i-change-or-redo-the-helper-class-for-insert-data-from-database-to-pojo%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          MadLax is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          MadLax is a new contributor. Be nice, and check out our Code of Conduct.













          MadLax is a new contributor. Be nice, and check out our Code of Conduct.












          MadLax is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212121%2fhow-can-i-change-or-redo-the-helper-class-for-insert-data-from-database-to-pojo%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Costa Masnaga

          Fotorealismo

          Sidney Franklin