Best Practice for Class Variable within Private Function?
$begingroup$
I know this is a subjective question, but it's been haunting me for years.
Let's jump straight to a simple Example:
class MyClass {
private $username;
function __constructor( $username ) {
$this->username = $username;
}
function register() {
if( $this->_has_duplicate( $this->username ) ) { // #1
return false;
}
...
}
private function _has_duplicate( $username ) {
...
}
}
In #1, I passed on a class variable to _has_duplicate(). But that function also has access to the same class variable.
Should I simply pass nothing and call the variable inside _has_duplicate()?
Is the code below follow better practice?
...
function register() {
// pass nothing
if( $this->_has_duplicate() ) {
return false;
}
...
}
private function _has_duplicate() {
// when needed I call $this->username
...
}
Thank you!
php
asked 14 mins ago
hrsetyonohrsetyono
1011
New contributor
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I know this is a subjective question, but it's been haunting me for years.
Let's jump straight to a simple Example:
class MyClass {
private $username;
function __constructor( $username ) {
$this->username = $username;
}
function register() {
if( $this->_has_duplicate( $this->username ) ) { // #1
return false;
}
...
}
private function _has_duplicate( $username ) {
...
}
}
In #1, I passed on a class variable to _has_duplicate(). But that function also has access to the same class variable.
Should I simply pass nothing and call the variable inside _has_duplicate()?
Is the code below follow better practice?
...
function register() {
// pass nothing
if( $this->_has_duplicate() ) {
return false;
}
...
}
private function _has_duplicate() {
// when needed I call $this->username
...
}
Thank you!
php
asked 14 mins ago
hrsetyonohrsetyono
1011
New contributor
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I know this is a subjective question, but it's been haunting me for years.
Let's jump straight to a simple Example:
class MyClass {
private $username;
function __constructor( $username ) {
$this->username = $username;
}
function register() {
if( $this->_has_duplicate( $this->username ) ) { // #1
return false;
}
...
}
private function _has_duplicate( $username ) {
...
}
}
In #1, I passed on a class variable to _has_duplicate(). But that function also has access to the same class variable.
Should I simply pass nothing and call the variable inside _has_duplicate()?
Is the code below follow better practice?
...
function register() {
// pass nothing
if( $this->_has_duplicate() ) {
return false;
}
...
}
private function _has_duplicate() {
// when needed I call $this->username
...
}
Thank you!
php
asked 14 mins ago
hrsetyonohrsetyono
1011
New contributor
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I know this is a subjective question, but it's been haunting me for years.
Let's jump straight to a simple Example:
class MyClass {
private $username;
function __constructor( $username ) {
$this->username = $username;
}
function register() {
if( $this->_has_duplicate( $this->username ) ) { // #1
return false;
}
...
}
private function _has_duplicate( $username ) {
...
}
}
In #1, I passed on a class variable to _has_duplicate(). But that function also has access to the same class variable.
Should I simply pass nothing and call the variable inside _has_duplicate()?
Is the code below follow better practice?
...
function register() {
// pass nothing
if( $this->_has_duplicate() ) {
return false;
}
...
}
private function _has_duplicate() {
// when needed I call $this->username
...
}
Thank you!
php
php
asked 14 mins ago
hrsetyonohrsetyono
1011
New contributor
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 14 mins ago
hrsetyonohrsetyono
1011
New contributor
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 14 mins ago
hrsetyonohrsetyono
1011
New contributor
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 14 mins ago
hrsetyonohrsetyono
1011
asked 14 mins ago
hrsetyonohrsetyono
1011
1011
New contributor
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
hrsetyono is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
hrsetyono is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215544%2fbest-practice-for-class-variable-within-private-function%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
hrsetyono is a new contributor. Be nice, and check out our Code of Conduct.
hrsetyono is a new contributor. Be nice, and check out our Code of Conduct.
hrsetyono is a new contributor. Be nice, and check out our Code of Conduct.
hrsetyono is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215544%2fbest-practice-for-class-variable-within-private-function%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
