Adapter class to display songs in an Android ListView











up vote
1
down vote

favorite












I am learning Android with Udacity nanodegree (having no support) and this is my assignment of music app. It is just an interface and no music I have to add. So far so the app is running without any error but I wold like to get expert feedback to write code in better and optimized way to achieve the same result.



My entire project is in my Bitbucket repo.



SongAdapter.java



public class SongAdapter extends ArrayAdapter<Song> {

int playingIndex = -1;
boolean currentTrack = false;

public SongAdapter(@NonNull Context context, int resource, @NonNull List<Song> objects) {
super(context, resource, objects);
}

@NonNull
@Override
public View getView(final int position, @Nullable View convertView, @NonNull ViewGroup parent) {

View playlistItemView = convertView;
final ViewHolder holder;

if (playlistItemView == null) {
playlistItemView = LayoutInflater.from(getContext()).inflate(R.layout.playlist_item, parent, false);

holder = new ViewHolder();

holder.albumCoverThumbnail = playlistItemView.findViewById(R.id.playlist_album_thumbnail);
holder.songTitle = playlistItemView.findViewById(R.id.playlist_song_title);
holder.songAlbumTitle = playlistItemView.findViewById(R.id.playlist_song_album_title);
holder.songArtist = playlistItemView.findViewById(R.id.playlist_song_artist);
holder.songPlayButton = playlistItemView.findViewById(R.id.playlist_play_button);

playlistItemView.setTag(holder);
} else {
holder = (ViewHolder) playlistItemView.getTag();
}

final Song currentSong = getItem(position);

// set data to the list item
assert currentSong != null;
holder.albumCoverThumbnail.setImageResource(currentSong.getSongAlbumCoverId());
holder.songTitle.setText(currentSong.getSongTitle());
holder.songAlbumTitle.setText(currentSong.getSongAlbumTitle());
holder.songArtist.setText(currentSong.getSongSingers());

// check the play status of the song item
if (playingIndex == position) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
}

// set song button action
holder.songPlayButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {

holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);

// pause current song on other click
if (position == playingIndex) {
playingIndex = -1;
} else {
playingIndex = position;
notifyDataSetChanged();
}

// pause play current track
if (currentTrack) {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
currentTrack = !currentTrack;
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
}
currentTrack = !currentTrack;
}
});

return playlistItemView;
}

static class ViewHolder {
ImageView albumCoverThumbnail;
TextView songTitle;
TextView songAlbumTitle;
TextView songArtist;
ImageButton songPlayButton;
}
}









share|improve this question




























    up vote
    1
    down vote

    favorite












    I am learning Android with Udacity nanodegree (having no support) and this is my assignment of music app. It is just an interface and no music I have to add. So far so the app is running without any error but I wold like to get expert feedback to write code in better and optimized way to achieve the same result.



    My entire project is in my Bitbucket repo.



    SongAdapter.java



    public class SongAdapter extends ArrayAdapter<Song> {

    int playingIndex = -1;
    boolean currentTrack = false;

    public SongAdapter(@NonNull Context context, int resource, @NonNull List<Song> objects) {
    super(context, resource, objects);
    }

    @NonNull
    @Override
    public View getView(final int position, @Nullable View convertView, @NonNull ViewGroup parent) {

    View playlistItemView = convertView;
    final ViewHolder holder;

    if (playlistItemView == null) {
    playlistItemView = LayoutInflater.from(getContext()).inflate(R.layout.playlist_item, parent, false);

    holder = new ViewHolder();

    holder.albumCoverThumbnail = playlistItemView.findViewById(R.id.playlist_album_thumbnail);
    holder.songTitle = playlistItemView.findViewById(R.id.playlist_song_title);
    holder.songAlbumTitle = playlistItemView.findViewById(R.id.playlist_song_album_title);
    holder.songArtist = playlistItemView.findViewById(R.id.playlist_song_artist);
    holder.songPlayButton = playlistItemView.findViewById(R.id.playlist_play_button);

    playlistItemView.setTag(holder);
    } else {
    holder = (ViewHolder) playlistItemView.getTag();
    }

    final Song currentSong = getItem(position);

    // set data to the list item
    assert currentSong != null;
    holder.albumCoverThumbnail.setImageResource(currentSong.getSongAlbumCoverId());
    holder.songTitle.setText(currentSong.getSongTitle());
    holder.songAlbumTitle.setText(currentSong.getSongAlbumTitle());
    holder.songArtist.setText(currentSong.getSongSingers());

    // check the play status of the song item
    if (playingIndex == position) {
    holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
    } else {
    holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
    }

    // set song button action
    holder.songPlayButton.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View v) {

    holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);

    // pause current song on other click
    if (position == playingIndex) {
    playingIndex = -1;
    } else {
    playingIndex = position;
    notifyDataSetChanged();
    }

    // pause play current track
    if (currentTrack) {
    holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
    currentTrack = !currentTrack;
    } else {
    holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
    }
    currentTrack = !currentTrack;
    }
    });

    return playlistItemView;
    }

    static class ViewHolder {
    ImageView albumCoverThumbnail;
    TextView songTitle;
    TextView songAlbumTitle;
    TextView songArtist;
    ImageButton songPlayButton;
    }
    }









    share|improve this question


























      up vote
      1
      down vote

      favorite









      up vote
      1
      down vote

      favorite











      I am learning Android with Udacity nanodegree (having no support) and this is my assignment of music app. It is just an interface and no music I have to add. So far so the app is running without any error but I wold like to get expert feedback to write code in better and optimized way to achieve the same result.



      My entire project is in my Bitbucket repo.



      SongAdapter.java



      public class SongAdapter extends ArrayAdapter<Song> {

      int playingIndex = -1;
      boolean currentTrack = false;

      public SongAdapter(@NonNull Context context, int resource, @NonNull List<Song> objects) {
      super(context, resource, objects);
      }

      @NonNull
      @Override
      public View getView(final int position, @Nullable View convertView, @NonNull ViewGroup parent) {

      View playlistItemView = convertView;
      final ViewHolder holder;

      if (playlistItemView == null) {
      playlistItemView = LayoutInflater.from(getContext()).inflate(R.layout.playlist_item, parent, false);

      holder = new ViewHolder();

      holder.albumCoverThumbnail = playlistItemView.findViewById(R.id.playlist_album_thumbnail);
      holder.songTitle = playlistItemView.findViewById(R.id.playlist_song_title);
      holder.songAlbumTitle = playlistItemView.findViewById(R.id.playlist_song_album_title);
      holder.songArtist = playlistItemView.findViewById(R.id.playlist_song_artist);
      holder.songPlayButton = playlistItemView.findViewById(R.id.playlist_play_button);

      playlistItemView.setTag(holder);
      } else {
      holder = (ViewHolder) playlistItemView.getTag();
      }

      final Song currentSong = getItem(position);

      // set data to the list item
      assert currentSong != null;
      holder.albumCoverThumbnail.setImageResource(currentSong.getSongAlbumCoverId());
      holder.songTitle.setText(currentSong.getSongTitle());
      holder.songAlbumTitle.setText(currentSong.getSongAlbumTitle());
      holder.songArtist.setText(currentSong.getSongSingers());

      // check the play status of the song item
      if (playingIndex == position) {
      holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
      } else {
      holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
      }

      // set song button action
      holder.songPlayButton.setOnClickListener(new View.OnClickListener() {
      @Override
      public void onClick(View v) {

      holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);

      // pause current song on other click
      if (position == playingIndex) {
      playingIndex = -1;
      } else {
      playingIndex = position;
      notifyDataSetChanged();
      }

      // pause play current track
      if (currentTrack) {
      holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
      currentTrack = !currentTrack;
      } else {
      holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
      }
      currentTrack = !currentTrack;
      }
      });

      return playlistItemView;
      }

      static class ViewHolder {
      ImageView albumCoverThumbnail;
      TextView songTitle;
      TextView songAlbumTitle;
      TextView songArtist;
      ImageButton songPlayButton;
      }
      }









      share|improve this question















      I am learning Android with Udacity nanodegree (having no support) and this is my assignment of music app. It is just an interface and no music I have to add. So far so the app is running without any error but I wold like to get expert feedback to write code in better and optimized way to achieve the same result.



      My entire project is in my Bitbucket repo.



      SongAdapter.java



      public class SongAdapter extends ArrayAdapter<Song> {

      int playingIndex = -1;
      boolean currentTrack = false;

      public SongAdapter(@NonNull Context context, int resource, @NonNull List<Song> objects) {
      super(context, resource, objects);
      }

      @NonNull
      @Override
      public View getView(final int position, @Nullable View convertView, @NonNull ViewGroup parent) {

      View playlistItemView = convertView;
      final ViewHolder holder;

      if (playlistItemView == null) {
      playlistItemView = LayoutInflater.from(getContext()).inflate(R.layout.playlist_item, parent, false);

      holder = new ViewHolder();

      holder.albumCoverThumbnail = playlistItemView.findViewById(R.id.playlist_album_thumbnail);
      holder.songTitle = playlistItemView.findViewById(R.id.playlist_song_title);
      holder.songAlbumTitle = playlistItemView.findViewById(R.id.playlist_song_album_title);
      holder.songArtist = playlistItemView.findViewById(R.id.playlist_song_artist);
      holder.songPlayButton = playlistItemView.findViewById(R.id.playlist_play_button);

      playlistItemView.setTag(holder);
      } else {
      holder = (ViewHolder) playlistItemView.getTag();
      }

      final Song currentSong = getItem(position);

      // set data to the list item
      assert currentSong != null;
      holder.albumCoverThumbnail.setImageResource(currentSong.getSongAlbumCoverId());
      holder.songTitle.setText(currentSong.getSongTitle());
      holder.songAlbumTitle.setText(currentSong.getSongAlbumTitle());
      holder.songArtist.setText(currentSong.getSongSingers());

      // check the play status of the song item
      if (playingIndex == position) {
      holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
      } else {
      holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
      }

      // set song button action
      holder.songPlayButton.setOnClickListener(new View.OnClickListener() {
      @Override
      public void onClick(View v) {

      holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);

      // pause current song on other click
      if (position == playingIndex) {
      playingIndex = -1;
      } else {
      playingIndex = position;
      notifyDataSetChanged();
      }

      // pause play current track
      if (currentTrack) {
      holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
      currentTrack = !currentTrack;
      } else {
      holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
      }
      currentTrack = !currentTrack;
      }
      });

      return playlistItemView;
      }

      static class ViewHolder {
      ImageView albumCoverThumbnail;
      TextView songTitle;
      TextView songAlbumTitle;
      TextView songArtist;
      ImageButton songPlayButton;
      }
      }






      java android






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 36 mins ago









      200_success

      128k15149412




      128k15149412










      asked 57 mins ago









      pixelngrain

      210111




      210111



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209412%2fadapter-class-to-display-songs-in-an-android-listview%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209412%2fadapter-class-to-display-songs-in-an-android-listview%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Costa Masnaga

          Fotorealismo

          Sidney Franklin