Adapter class to display songs in an Android ListView
up vote
1
down vote
favorite
I am learning Android with Udacity nanodegree (having no support) and this is my assignment of music app. It is just an interface and no music I have to add. So far so the app is running without any error but I wold like to get expert feedback to write code in better and optimized way to achieve the same result.
My entire project is in my Bitbucket repo.
SongAdapter.java
public class SongAdapter extends ArrayAdapter<Song> {
int playingIndex = -1;
boolean currentTrack = false;
public SongAdapter(@NonNull Context context, int resource, @NonNull List<Song> objects) {
super(context, resource, objects);
}
@NonNull
@Override
public View getView(final int position, @Nullable View convertView, @NonNull ViewGroup parent) {
View playlistItemView = convertView;
final ViewHolder holder;
if (playlistItemView == null) {
playlistItemView = LayoutInflater.from(getContext()).inflate(R.layout.playlist_item, parent, false);
holder = new ViewHolder();
holder.albumCoverThumbnail = playlistItemView.findViewById(R.id.playlist_album_thumbnail);
holder.songTitle = playlistItemView.findViewById(R.id.playlist_song_title);
holder.songAlbumTitle = playlistItemView.findViewById(R.id.playlist_song_album_title);
holder.songArtist = playlistItemView.findViewById(R.id.playlist_song_artist);
holder.songPlayButton = playlistItemView.findViewById(R.id.playlist_play_button);
playlistItemView.setTag(holder);
} else {
holder = (ViewHolder) playlistItemView.getTag();
}
final Song currentSong = getItem(position);
// set data to the list item
assert currentSong != null;
holder.albumCoverThumbnail.setImageResource(currentSong.getSongAlbumCoverId());
holder.songTitle.setText(currentSong.getSongTitle());
holder.songAlbumTitle.setText(currentSong.getSongAlbumTitle());
holder.songArtist.setText(currentSong.getSongSingers());
// check the play status of the song item
if (playingIndex == position) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
}
// set song button action
holder.songPlayButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
// pause current song on other click
if (position == playingIndex) {
playingIndex = -1;
} else {
playingIndex = position;
notifyDataSetChanged();
}
// pause play current track
if (currentTrack) {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
currentTrack = !currentTrack;
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
}
currentTrack = !currentTrack;
}
});
return playlistItemView;
}
static class ViewHolder {
ImageView albumCoverThumbnail;
TextView songTitle;
TextView songAlbumTitle;
TextView songArtist;
ImageButton songPlayButton;
}
}
java android
add a comment |
up vote
1
down vote
favorite
I am learning Android with Udacity nanodegree (having no support) and this is my assignment of music app. It is just an interface and no music I have to add. So far so the app is running without any error but I wold like to get expert feedback to write code in better and optimized way to achieve the same result.
My entire project is in my Bitbucket repo.
SongAdapter.java
public class SongAdapter extends ArrayAdapter<Song> {
int playingIndex = -1;
boolean currentTrack = false;
public SongAdapter(@NonNull Context context, int resource, @NonNull List<Song> objects) {
super(context, resource, objects);
}
@NonNull
@Override
public View getView(final int position, @Nullable View convertView, @NonNull ViewGroup parent) {
View playlistItemView = convertView;
final ViewHolder holder;
if (playlistItemView == null) {
playlistItemView = LayoutInflater.from(getContext()).inflate(R.layout.playlist_item, parent, false);
holder = new ViewHolder();
holder.albumCoverThumbnail = playlistItemView.findViewById(R.id.playlist_album_thumbnail);
holder.songTitle = playlistItemView.findViewById(R.id.playlist_song_title);
holder.songAlbumTitle = playlistItemView.findViewById(R.id.playlist_song_album_title);
holder.songArtist = playlistItemView.findViewById(R.id.playlist_song_artist);
holder.songPlayButton = playlistItemView.findViewById(R.id.playlist_play_button);
playlistItemView.setTag(holder);
} else {
holder = (ViewHolder) playlistItemView.getTag();
}
final Song currentSong = getItem(position);
// set data to the list item
assert currentSong != null;
holder.albumCoverThumbnail.setImageResource(currentSong.getSongAlbumCoverId());
holder.songTitle.setText(currentSong.getSongTitle());
holder.songAlbumTitle.setText(currentSong.getSongAlbumTitle());
holder.songArtist.setText(currentSong.getSongSingers());
// check the play status of the song item
if (playingIndex == position) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
}
// set song button action
holder.songPlayButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
// pause current song on other click
if (position == playingIndex) {
playingIndex = -1;
} else {
playingIndex = position;
notifyDataSetChanged();
}
// pause play current track
if (currentTrack) {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
currentTrack = !currentTrack;
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
}
currentTrack = !currentTrack;
}
});
return playlistItemView;
}
static class ViewHolder {
ImageView albumCoverThumbnail;
TextView songTitle;
TextView songAlbumTitle;
TextView songArtist;
ImageButton songPlayButton;
}
}
java android
add a comment |
up vote
1
down vote
favorite
up vote
1
down vote
favorite
I am learning Android with Udacity nanodegree (having no support) and this is my assignment of music app. It is just an interface and no music I have to add. So far so the app is running without any error but I wold like to get expert feedback to write code in better and optimized way to achieve the same result.
My entire project is in my Bitbucket repo.
SongAdapter.java
public class SongAdapter extends ArrayAdapter<Song> {
int playingIndex = -1;
boolean currentTrack = false;
public SongAdapter(@NonNull Context context, int resource, @NonNull List<Song> objects) {
super(context, resource, objects);
}
@NonNull
@Override
public View getView(final int position, @Nullable View convertView, @NonNull ViewGroup parent) {
View playlistItemView = convertView;
final ViewHolder holder;
if (playlistItemView == null) {
playlistItemView = LayoutInflater.from(getContext()).inflate(R.layout.playlist_item, parent, false);
holder = new ViewHolder();
holder.albumCoverThumbnail = playlistItemView.findViewById(R.id.playlist_album_thumbnail);
holder.songTitle = playlistItemView.findViewById(R.id.playlist_song_title);
holder.songAlbumTitle = playlistItemView.findViewById(R.id.playlist_song_album_title);
holder.songArtist = playlistItemView.findViewById(R.id.playlist_song_artist);
holder.songPlayButton = playlistItemView.findViewById(R.id.playlist_play_button);
playlistItemView.setTag(holder);
} else {
holder = (ViewHolder) playlistItemView.getTag();
}
final Song currentSong = getItem(position);
// set data to the list item
assert currentSong != null;
holder.albumCoverThumbnail.setImageResource(currentSong.getSongAlbumCoverId());
holder.songTitle.setText(currentSong.getSongTitle());
holder.songAlbumTitle.setText(currentSong.getSongAlbumTitle());
holder.songArtist.setText(currentSong.getSongSingers());
// check the play status of the song item
if (playingIndex == position) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
}
// set song button action
holder.songPlayButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
// pause current song on other click
if (position == playingIndex) {
playingIndex = -1;
} else {
playingIndex = position;
notifyDataSetChanged();
}
// pause play current track
if (currentTrack) {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
currentTrack = !currentTrack;
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
}
currentTrack = !currentTrack;
}
});
return playlistItemView;
}
static class ViewHolder {
ImageView albumCoverThumbnail;
TextView songTitle;
TextView songAlbumTitle;
TextView songArtist;
ImageButton songPlayButton;
}
}
java android
I am learning Android with Udacity nanodegree (having no support) and this is my assignment of music app. It is just an interface and no music I have to add. So far so the app is running without any error but I wold like to get expert feedback to write code in better and optimized way to achieve the same result.
My entire project is in my Bitbucket repo.
SongAdapter.java
public class SongAdapter extends ArrayAdapter<Song> {
int playingIndex = -1;
boolean currentTrack = false;
public SongAdapter(@NonNull Context context, int resource, @NonNull List<Song> objects) {
super(context, resource, objects);
}
@NonNull
@Override
public View getView(final int position, @Nullable View convertView, @NonNull ViewGroup parent) {
View playlistItemView = convertView;
final ViewHolder holder;
if (playlistItemView == null) {
playlistItemView = LayoutInflater.from(getContext()).inflate(R.layout.playlist_item, parent, false);
holder = new ViewHolder();
holder.albumCoverThumbnail = playlistItemView.findViewById(R.id.playlist_album_thumbnail);
holder.songTitle = playlistItemView.findViewById(R.id.playlist_song_title);
holder.songAlbumTitle = playlistItemView.findViewById(R.id.playlist_song_album_title);
holder.songArtist = playlistItemView.findViewById(R.id.playlist_song_artist);
holder.songPlayButton = playlistItemView.findViewById(R.id.playlist_play_button);
playlistItemView.setTag(holder);
} else {
holder = (ViewHolder) playlistItemView.getTag();
}
final Song currentSong = getItem(position);
// set data to the list item
assert currentSong != null;
holder.albumCoverThumbnail.setImageResource(currentSong.getSongAlbumCoverId());
holder.songTitle.setText(currentSong.getSongTitle());
holder.songAlbumTitle.setText(currentSong.getSongAlbumTitle());
holder.songArtist.setText(currentSong.getSongSingers());
// check the play status of the song item
if (playingIndex == position) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
}
// set song button action
holder.songPlayButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
// pause current song on other click
if (position == playingIndex) {
playingIndex = -1;
} else {
playingIndex = position;
notifyDataSetChanged();
}
// pause play current track
if (currentTrack) {
holder.songPlayButton.setImageResource(R.drawable.ic_play_arrow_black_24dp);
currentTrack = !currentTrack;
} else {
holder.songPlayButton.setImageResource(R.drawable.ic_pause_black_24dp);
}
currentTrack = !currentTrack;
}
});
return playlistItemView;
}
static class ViewHolder {
ImageView albumCoverThumbnail;
TextView songTitle;
TextView songAlbumTitle;
TextView songArtist;
ImageButton songPlayButton;
}
}
java android
java android
edited 36 mins ago
200_success
128k15149412
128k15149412
asked 57 mins ago
pixelngrain
210111
210111
add a comment |
add a comment |
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f209412%2fadapter-class-to-display-songs-in-an-android-listview%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown