Sychronous wrapper around UIApplication.openURL:options:completion:
I am deprecating iOS 9 on a project. One of the differences in the framework is that the openURL method has changed.
iOS 9
- (BOOL)openURL:(NSURL *)url;
iOS 10
- (void)openURL:(NSURL *)url
options:(NSDictionary<NSString *,id> *)options
completionHandler:(void (^)(BOOL success))completion;
Notice how the method changed from being synchronous to asynchronous.
Since I have a bunch of usages for the synchronous method, I want to create a synchronous wrapper around the asynchronous openURL:options:completion: method and I'm going to update the usages to call this asynchronous wrapper instead.
My first attempt looks like this:
- (BOOL)sync_openURL: (nullable NSURL *)url {
__block BOOL result = nil;
dispatch_semaphore_t semaphore = dispatch_semaphore_create(0);
[self openURL:url options:@{} completionHandler:^(BOOL success) {
result = success;
dispatch_semaphore_signal(semaphore);
}];
while (dispatch_semaphore_wait(semaphore, DISPATCH_TIME_NOW)) {
[[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0]];
}
return result;
}
Is this a good replacement ? Can it be improved in anyway ?
objective-c ios
asked Feb 8 at 19:15
gprasant
1012
add a comment |
I am deprecating iOS 9 on a project. One of the differences in the framework is that the openURL method has changed.
iOS 9
- (BOOL)openURL:(NSURL *)url;
iOS 10
- (void)openURL:(NSURL *)url
options:(NSDictionary<NSString *,id> *)options
completionHandler:(void (^)(BOOL success))completion;
Notice how the method changed from being synchronous to asynchronous.
Since I have a bunch of usages for the synchronous method, I want to create a synchronous wrapper around the asynchronous openURL:options:completion: method and I'm going to update the usages to call this asynchronous wrapper instead.
My first attempt looks like this:
- (BOOL)sync_openURL: (nullable NSURL *)url {
__block BOOL result = nil;
dispatch_semaphore_t semaphore = dispatch_semaphore_create(0);
[self openURL:url options:@{} completionHandler:^(BOOL success) {
result = success;
dispatch_semaphore_signal(semaphore);
}];
while (dispatch_semaphore_wait(semaphore, DISPATCH_TIME_NOW)) {
[[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0]];
}
return result;
}
Is this a good replacement ? Can it be improved in anyway ?
objective-c ios
asked Feb 8 at 19:15
gprasant
1012
1
Why don't you want to make your code asynchronous?
– Roman Podymov
Feb 20 at 13:08
add a comment |
I am deprecating iOS 9 on a project. One of the differences in the framework is that the openURL method has changed.
iOS 9
- (BOOL)openURL:(NSURL *)url;
iOS 10
- (void)openURL:(NSURL *)url
options:(NSDictionary<NSString *,id> *)options
completionHandler:(void (^)(BOOL success))completion;
Notice how the method changed from being synchronous to asynchronous.
Since I have a bunch of usages for the synchronous method, I want to create a synchronous wrapper around the asynchronous openURL:options:completion: method and I'm going to update the usages to call this asynchronous wrapper instead.
My first attempt looks like this:
- (BOOL)sync_openURL: (nullable NSURL *)url {
__block BOOL result = nil;
dispatch_semaphore_t semaphore = dispatch_semaphore_create(0);
[self openURL:url options:@{} completionHandler:^(BOOL success) {
result = success;
dispatch_semaphore_signal(semaphore);
}];
while (dispatch_semaphore_wait(semaphore, DISPATCH_TIME_NOW)) {
[[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0]];
}
return result;
}
Is this a good replacement ? Can it be improved in anyway ?
objective-c ios
asked Feb 8 at 19:15
gprasant
1012
I am deprecating iOS 9 on a project. One of the differences in the framework is that the openURL method has changed.
iOS 9
- (BOOL)openURL:(NSURL *)url;
iOS 10
- (void)openURL:(NSURL *)url
options:(NSDictionary<NSString *,id> *)options
completionHandler:(void (^)(BOOL success))completion;
Notice how the method changed from being synchronous to asynchronous.
Since I have a bunch of usages for the synchronous method, I want to create a synchronous wrapper around the asynchronous openURL:options:completion: method and I'm going to update the usages to call this asynchronous wrapper instead.
My first attempt looks like this:
- (BOOL)sync_openURL: (nullable NSURL *)url {
__block BOOL result = nil;
dispatch_semaphore_t semaphore = dispatch_semaphore_create(0);
[self openURL:url options:@{} completionHandler:^(BOOL success) {
result = success;
dispatch_semaphore_signal(semaphore);
}];
while (dispatch_semaphore_wait(semaphore, DISPATCH_TIME_NOW)) {
[[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0]];
}
return result;
}
Is this a good replacement ? Can it be improved in anyway ?
objective-c ios
objective-c ios
asked Feb 8 at 19:15
gprasant
1012
asked Feb 8 at 19:15
gprasant
1012
asked Feb 8 at 19:15
gprasant
1012
asked Feb 8 at 19:15
gprasant
1012
asked Feb 8 at 19:15
gprasant
1012
1012
1
Why don't you want to make your code asynchronous?
– Roman Podymov
Feb 20 at 13:08
add a comment |
1
Why don't you want to make your code asynchronous?
– Roman Podymov
Feb 20 at 13:08
1
1
Why don't you want to make your code asynchronous?
– Roman Podymov
Feb 20 at 13:08
Why don't you want to make your code asynchronous?
– Roman Podymov
Feb 20 at 13:08
add a comment |
2 Answers
2
active
oldest
votes
That code should work, but blocking the main thread is never a good idea. That's why the method was changed in the first place.
I suggest a deeper refactor of your code so that you use the new async method with completion handler as intended.
answered Feb 20 at 14:41
Duncan C
1712
add a comment |
You don't need to do anything special here.
Just change to the new method and ignore the completion handler.
[application openURL:url options:@{} completionHandler:nil];
answered 6 mins ago
trapper
1665
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f187112%2fsychronous-wrapper-around-uiapplication-openurloptionscompletion%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
That code should work, but blocking the main thread is never a good idea. That's why the method was changed in the first place.
I suggest a deeper refactor of your code so that you use the new async method with completion handler as intended.
answered Feb 20 at 14:41
Duncan C
1712
add a comment |
That code should work, but blocking the main thread is never a good idea. That's why the method was changed in the first place.
I suggest a deeper refactor of your code so that you use the new async method with completion handler as intended.
answered Feb 20 at 14:41
Duncan C
1712
add a comment |
That code should work, but blocking the main thread is never a good idea. That's why the method was changed in the first place.
I suggest a deeper refactor of your code so that you use the new async method with completion handler as intended.
answered Feb 20 at 14:41
Duncan C
1712
That code should work, but blocking the main thread is never a good idea. That's why the method was changed in the first place.
I suggest a deeper refactor of your code so that you use the new async method with completion handler as intended.
answered Feb 20 at 14:41
Duncan C
1712
answered Feb 20 at 14:41
Duncan C
1712
answered Feb 20 at 14:41
Duncan C
1712
answered Feb 20 at 14:41
Duncan C
1712
1712
add a comment |
add a comment |
You don't need to do anything special here.
Just change to the new method and ignore the completion handler.
[application openURL:url options:@{} completionHandler:nil];
answered 6 mins ago
trapper
1665
add a comment |
You don't need to do anything special here.
Just change to the new method and ignore the completion handler.
[application openURL:url options:@{} completionHandler:nil];
answered 6 mins ago
trapper
1665
add a comment |
You don't need to do anything special here.
Just change to the new method and ignore the completion handler.
[application openURL:url options:@{} completionHandler:nil];
answered 6 mins ago
trapper
1665
You don't need to do anything special here.
Just change to the new method and ignore the completion handler.
[application openURL:url options:@{} completionHandler:nil];
answered 6 mins ago
trapper
1665
answered 6 mins ago
trapper
1665
answered 6 mins ago
trapper
1665
answered 6 mins ago
trapper
1665
1665
add a comment |
add a comment |
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f187112%2fsychronous-wrapper-around-uiapplication-openurloptionscompletion%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Why don't you want to make your code asynchronous?
– Roman Podymov
Feb 20 at 13:08