Activity not getting closed
I am working on an app where I am drawing my custom lockscreen (An Activity) over the system's default lock.
Everything is working perfectly fine except one thing, I am using a reciever and whenever there is an incoming call, that reciever gets called and from inside that reciever I am closing the activity.
Note : This is happening only in case of OnePlus device, on any other device it's working perfectly.
private class CallStateListener extends PhoneStateListener {
@Override
public void onCallStateChanged(int state, String incomingNumber) {
OverlayActivity overlayActivity = new OverlayActivity();
switch (state) {
case TelephonyManager.CALL_STATE_RINGING:
// System.out.println("RINGING");
overlayActivity.finish();
// System.out.println("Activity has been closed!!");
break;
}
}
}
Both the lines before and after the code where I am closing the activity is working completely fine, but the activity is not getting closed.
java android android-activity
|
show 1 more comment
I am working on an app where I am drawing my custom lockscreen (An Activity) over the system's default lock.
Everything is working perfectly fine except one thing, I am using a reciever and whenever there is an incoming call, that reciever gets called and from inside that reciever I am closing the activity.
Note : This is happening only in case of OnePlus device, on any other device it's working perfectly.
private class CallStateListener extends PhoneStateListener {
@Override
public void onCallStateChanged(int state, String incomingNumber) {
OverlayActivity overlayActivity = new OverlayActivity();
switch (state) {
case TelephonyManager.CALL_STATE_RINGING:
// System.out.println("RINGING");
overlayActivity.finish();
// System.out.println("Activity has been closed!!");
break;
}
}
}
Both the lines before and after the code where I am closing the activity is working completely fine, but the activity is not getting closed.
java android android-activity
can you put your code which is actuality finishes Activity
– Chetan Joshi
Nov 23 '18 at 6:43
@ChetanJoshi "overlayActivity.finish();", this is the code which closes the activity.
– Kunal
Nov 23 '18 at 6:46
4
You're creating new activity object and trying to call finish on it. It doesn't work like that. You need get hold of the activity reference which is showing on the screen and then call finish on it.
– Samuel Robert
Nov 23 '18 at 6:50
4
OverlayActivity overlayActivity = new OverlayActivity();
you should never create an instance of activity. Only the system can create it. Also it makes totally no sense to finish the activity you have created and not shown.
– Vladyslav Matviienko
Nov 23 '18 at 6:52
@Samuel Robert It was exactly what you have mentioned. +1 for pointing out :)
– Kunal
Nov 23 '18 at 8:10
|
show 1 more comment
I am working on an app where I am drawing my custom lockscreen (An Activity) over the system's default lock.
Everything is working perfectly fine except one thing, I am using a reciever and whenever there is an incoming call, that reciever gets called and from inside that reciever I am closing the activity.
Note : This is happening only in case of OnePlus device, on any other device it's working perfectly.
private class CallStateListener extends PhoneStateListener {
@Override
public void onCallStateChanged(int state, String incomingNumber) {
OverlayActivity overlayActivity = new OverlayActivity();
switch (state) {
case TelephonyManager.CALL_STATE_RINGING:
// System.out.println("RINGING");
overlayActivity.finish();
// System.out.println("Activity has been closed!!");
break;
}
}
}
Both the lines before and after the code where I am closing the activity is working completely fine, but the activity is not getting closed.
java android android-activity
I am working on an app where I am drawing my custom lockscreen (An Activity) over the system's default lock.
Everything is working perfectly fine except one thing, I am using a reciever and whenever there is an incoming call, that reciever gets called and from inside that reciever I am closing the activity.
Note : This is happening only in case of OnePlus device, on any other device it's working perfectly.
private class CallStateListener extends PhoneStateListener {
@Override
public void onCallStateChanged(int state, String incomingNumber) {
OverlayActivity overlayActivity = new OverlayActivity();
switch (state) {
case TelephonyManager.CALL_STATE_RINGING:
// System.out.println("RINGING");
overlayActivity.finish();
// System.out.println("Activity has been closed!!");
break;
}
}
}
Both the lines before and after the code where I am closing the activity is working completely fine, but the activity is not getting closed.
java android android-activity
java android android-activity
edited Nov 23 '18 at 6:51
scienticious
190216
190216
asked Nov 23 '18 at 6:38
KunalKunal
5611
5611
can you put your code which is actuality finishes Activity
– Chetan Joshi
Nov 23 '18 at 6:43
@ChetanJoshi "overlayActivity.finish();", this is the code which closes the activity.
– Kunal
Nov 23 '18 at 6:46
4
You're creating new activity object and trying to call finish on it. It doesn't work like that. You need get hold of the activity reference which is showing on the screen and then call finish on it.
– Samuel Robert
Nov 23 '18 at 6:50
4
OverlayActivity overlayActivity = new OverlayActivity();
you should never create an instance of activity. Only the system can create it. Also it makes totally no sense to finish the activity you have created and not shown.
– Vladyslav Matviienko
Nov 23 '18 at 6:52
@Samuel Robert It was exactly what you have mentioned. +1 for pointing out :)
– Kunal
Nov 23 '18 at 8:10
|
show 1 more comment
can you put your code which is actuality finishes Activity
– Chetan Joshi
Nov 23 '18 at 6:43
@ChetanJoshi "overlayActivity.finish();", this is the code which closes the activity.
– Kunal
Nov 23 '18 at 6:46
4
You're creating new activity object and trying to call finish on it. It doesn't work like that. You need get hold of the activity reference which is showing on the screen and then call finish on it.
– Samuel Robert
Nov 23 '18 at 6:50
4
OverlayActivity overlayActivity = new OverlayActivity();
you should never create an instance of activity. Only the system can create it. Also it makes totally no sense to finish the activity you have created and not shown.
– Vladyslav Matviienko
Nov 23 '18 at 6:52
@Samuel Robert It was exactly what you have mentioned. +1 for pointing out :)
– Kunal
Nov 23 '18 at 8:10
can you put your code which is actuality finishes Activity
– Chetan Joshi
Nov 23 '18 at 6:43
can you put your code which is actuality finishes Activity
– Chetan Joshi
Nov 23 '18 at 6:43
@ChetanJoshi "overlayActivity.finish();", this is the code which closes the activity.
– Kunal
Nov 23 '18 at 6:46
@ChetanJoshi "overlayActivity.finish();", this is the code which closes the activity.
– Kunal
Nov 23 '18 at 6:46
4
4
You're creating new activity object and trying to call finish on it. It doesn't work like that. You need get hold of the activity reference which is showing on the screen and then call finish on it.
– Samuel Robert
Nov 23 '18 at 6:50
You're creating new activity object and trying to call finish on it. It doesn't work like that. You need get hold of the activity reference which is showing on the screen and then call finish on it.
– Samuel Robert
Nov 23 '18 at 6:50
4
4
OverlayActivity overlayActivity = new OverlayActivity();
you should never create an instance of activity. Only the system can create it. Also it makes totally no sense to finish the activity you have created and not shown.– Vladyslav Matviienko
Nov 23 '18 at 6:52
OverlayActivity overlayActivity = new OverlayActivity();
you should never create an instance of activity. Only the system can create it. Also it makes totally no sense to finish the activity you have created and not shown.– Vladyslav Matviienko
Nov 23 '18 at 6:52
@Samuel Robert It was exactly what you have mentioned. +1 for pointing out :)
– Kunal
Nov 23 '18 at 8:10
@Samuel Robert It was exactly what you have mentioned. +1 for pointing out :)
– Kunal
Nov 23 '18 at 8:10
|
show 1 more comment
1 Answer
1
active
oldest
votes
And if you are creating Activity Object its not working at all you
needs and Actual Activity Object or Context of Activity to close it.
And if you are creating Activity Object its not working at all you needs and Actual Activity Object or Context of Activity to close it. This was the issue, i was creating a new instance of the activity and calling finish() on that. Thanks for pointing out.
– Kunal
Nov 23 '18 at 8:13
@Kunal if my answer helpful for you then please upvote and accept it.
– Chetan Joshi
Nov 23 '18 at 9:00
your partial answer was helpful, so if you could edit and remove rest of the part i will accept the answer.
– Kunal
Nov 23 '18 at 10:18
@kunal i have removed first section of answer .
– Chetan Joshi
Nov 23 '18 at 11:09
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53441708%2factivity-not-getting-closed%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
And if you are creating Activity Object its not working at all you
needs and Actual Activity Object or Context of Activity to close it.
And if you are creating Activity Object its not working at all you needs and Actual Activity Object or Context of Activity to close it. This was the issue, i was creating a new instance of the activity and calling finish() on that. Thanks for pointing out.
– Kunal
Nov 23 '18 at 8:13
@Kunal if my answer helpful for you then please upvote and accept it.
– Chetan Joshi
Nov 23 '18 at 9:00
your partial answer was helpful, so if you could edit and remove rest of the part i will accept the answer.
– Kunal
Nov 23 '18 at 10:18
@kunal i have removed first section of answer .
– Chetan Joshi
Nov 23 '18 at 11:09
add a comment |
And if you are creating Activity Object its not working at all you
needs and Actual Activity Object or Context of Activity to close it.
And if you are creating Activity Object its not working at all you needs and Actual Activity Object or Context of Activity to close it. This was the issue, i was creating a new instance of the activity and calling finish() on that. Thanks for pointing out.
– Kunal
Nov 23 '18 at 8:13
@Kunal if my answer helpful for you then please upvote and accept it.
– Chetan Joshi
Nov 23 '18 at 9:00
your partial answer was helpful, so if you could edit and remove rest of the part i will accept the answer.
– Kunal
Nov 23 '18 at 10:18
@kunal i have removed first section of answer .
– Chetan Joshi
Nov 23 '18 at 11:09
add a comment |
And if you are creating Activity Object its not working at all you
needs and Actual Activity Object or Context of Activity to close it.
And if you are creating Activity Object its not working at all you
needs and Actual Activity Object or Context of Activity to close it.
edited Nov 23 '18 at 10:22
answered Nov 23 '18 at 6:51
Chetan JoshiChetan Joshi
3,72411620
3,72411620
And if you are creating Activity Object its not working at all you needs and Actual Activity Object or Context of Activity to close it. This was the issue, i was creating a new instance of the activity and calling finish() on that. Thanks for pointing out.
– Kunal
Nov 23 '18 at 8:13
@Kunal if my answer helpful for you then please upvote and accept it.
– Chetan Joshi
Nov 23 '18 at 9:00
your partial answer was helpful, so if you could edit and remove rest of the part i will accept the answer.
– Kunal
Nov 23 '18 at 10:18
@kunal i have removed first section of answer .
– Chetan Joshi
Nov 23 '18 at 11:09
add a comment |
And if you are creating Activity Object its not working at all you needs and Actual Activity Object or Context of Activity to close it. This was the issue, i was creating a new instance of the activity and calling finish() on that. Thanks for pointing out.
– Kunal
Nov 23 '18 at 8:13
@Kunal if my answer helpful for you then please upvote and accept it.
– Chetan Joshi
Nov 23 '18 at 9:00
your partial answer was helpful, so if you could edit and remove rest of the part i will accept the answer.
– Kunal
Nov 23 '18 at 10:18
@kunal i have removed first section of answer .
– Chetan Joshi
Nov 23 '18 at 11:09
And if you are creating Activity Object its not working at all you needs and Actual Activity Object or Context of Activity to close it. This was the issue, i was creating a new instance of the activity and calling finish() on that. Thanks for pointing out.
– Kunal
Nov 23 '18 at 8:13
And if you are creating Activity Object its not working at all you needs and Actual Activity Object or Context of Activity to close it. This was the issue, i was creating a new instance of the activity and calling finish() on that. Thanks for pointing out.
– Kunal
Nov 23 '18 at 8:13
@Kunal if my answer helpful for you then please upvote and accept it.
– Chetan Joshi
Nov 23 '18 at 9:00
@Kunal if my answer helpful for you then please upvote and accept it.
– Chetan Joshi
Nov 23 '18 at 9:00
your partial answer was helpful, so if you could edit and remove rest of the part i will accept the answer.
– Kunal
Nov 23 '18 at 10:18
your partial answer was helpful, so if you could edit and remove rest of the part i will accept the answer.
– Kunal
Nov 23 '18 at 10:18
@kunal i have removed first section of answer .
– Chetan Joshi
Nov 23 '18 at 11:09
@kunal i have removed first section of answer .
– Chetan Joshi
Nov 23 '18 at 11:09
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53441708%2factivity-not-getting-closed%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
can you put your code which is actuality finishes Activity
– Chetan Joshi
Nov 23 '18 at 6:43
@ChetanJoshi "overlayActivity.finish();", this is the code which closes the activity.
– Kunal
Nov 23 '18 at 6:46
4
You're creating new activity object and trying to call finish on it. It doesn't work like that. You need get hold of the activity reference which is showing on the screen and then call finish on it.
– Samuel Robert
Nov 23 '18 at 6:50
4
OverlayActivity overlayActivity = new OverlayActivity();
you should never create an instance of activity. Only the system can create it. Also it makes totally no sense to finish the activity you have created and not shown.– Vladyslav Matviienko
Nov 23 '18 at 6:52
@Samuel Robert It was exactly what you have mentioned. +1 for pointing out :)
– Kunal
Nov 23 '18 at 8:10