Adding volume slider and display time - React
Current instructions:
We've implemented the time control slider. Now implement the volume slider.
The time is currently displayed in seconds.
Add a method called formatTime to the Album component.
It should accept a time in seconds as a parameter and convert it into a string with the format of M:SS. Where ever the time is displayed, wrap it in this method.
(Bonus: If formatTime is passed an invalid/non-numeric value, it should return a fallback value of "-:--")
https://github.com/cjl85/bloc-jams-react/tree/master/src/components
Have four files Album, Landing (main page), Library, and PlayerBar.
When I render the page, everything runs except whenever I click the volume slider it gives me NaN.
reactjs components react-props
asked Nov 25 '18 at 3:25
cjl85cjl85
7510
|
show 1 more comment
Current instructions:
We've implemented the time control slider. Now implement the volume slider.
The time is currently displayed in seconds.
Add a method called formatTime to the Album component.
It should accept a time in seconds as a parameter and convert it into a string with the format of M:SS. Where ever the time is displayed, wrap it in this method.
(Bonus: If formatTime is passed an invalid/non-numeric value, it should return a fallback value of "-:--")
https://github.com/cjl85/bloc-jams-react/tree/master/src/components
Have four files Album, Landing (main page), Library, and PlayerBar.
When I render the page, everything runs except whenever I click the volume slider it gives me NaN.
reactjs components react-props
asked Nov 25 '18 at 3:25
cjl85cjl85
7510
If im not mistaken, the value for the volume slider isvalue={(this.props.currentVolume / this.props.length) || 0}? if thats the case, did you add to that render method aconsole.log(${this.props.currentVolume} || ${this.props.length})to output the values? it could a divide-by-zero
– Shawn Andrews
Nov 25 '18 at 3:35
Yeah I think you're right about the divide by zero but im not sure what you mean by adding the console.log in the render method. Right now, the volume slider doesn't slide and the moment I try to, it says NaN
– cjl85
Nov 25 '18 at 3:40
Adding it hereclass PlayerBar extends Component { render() { console.log(${this.props.currentVolume} || ${this.props.length}); return ( ... ); } }
– Shawn Andrews
Nov 25 '18 at 3:43
it's giving me a parsing error and it's pointing to the period in the console.log
– cjl85
Nov 25 '18 at 3:45
You can do this instead,console.log("current volume: ", this.props.currentVolume); console.log("length: ", this.props.length), just to get the values. if it outputs length: 0 or null or undefined then you found your problem
– Shawn Andrews
Nov 25 '18 at 3:50
|
show 1 more comment
Current instructions:
We've implemented the time control slider. Now implement the volume slider.
The time is currently displayed in seconds.
Add a method called formatTime to the Album component.
It should accept a time in seconds as a parameter and convert it into a string with the format of M:SS. Where ever the time is displayed, wrap it in this method.
(Bonus: If formatTime is passed an invalid/non-numeric value, it should return a fallback value of "-:--")
https://github.com/cjl85/bloc-jams-react/tree/master/src/components
Have four files Album, Landing (main page), Library, and PlayerBar.
When I render the page, everything runs except whenever I click the volume slider it gives me NaN.
reactjs components react-props
asked Nov 25 '18 at 3:25
cjl85cjl85
7510
Current instructions:
We've implemented the time control slider. Now implement the volume slider.
The time is currently displayed in seconds.
Add a method called formatTime to the Album component.
It should accept a time in seconds as a parameter and convert it into a string with the format of M:SS. Where ever the time is displayed, wrap it in this method.
(Bonus: If formatTime is passed an invalid/non-numeric value, it should return a fallback value of "-:--")
https://github.com/cjl85/bloc-jams-react/tree/master/src/components
Have four files Album, Landing (main page), Library, and PlayerBar.
When I render the page, everything runs except whenever I click the volume slider it gives me NaN.
reactjs components react-props
reactjs components react-props
asked Nov 25 '18 at 3:25
cjl85cjl85
7510
asked Nov 25 '18 at 3:25
cjl85cjl85
7510
asked Nov 25 '18 at 3:25
cjl85cjl85
7510
asked Nov 25 '18 at 3:25
cjl85cjl85
7510
asked Nov 25 '18 at 3:25
cjl85cjl85
7510
7510
If im not mistaken, the value for the volume slider isvalue={(this.props.currentVolume / this.props.length) || 0}? if thats the case, did you add to that render method aconsole.log(${this.props.currentVolume} || ${this.props.length})to output the values? it could a divide-by-zero
– Shawn Andrews
Nov 25 '18 at 3:35
Yeah I think you're right about the divide by zero but im not sure what you mean by adding the console.log in the render method. Right now, the volume slider doesn't slide and the moment I try to, it says NaN
– cjl85
Nov 25 '18 at 3:40
Adding it hereclass PlayerBar extends Component { render() { console.log(${this.props.currentVolume} || ${this.props.length}); return ( ... ); } }
– Shawn Andrews
Nov 25 '18 at 3:43
it's giving me a parsing error and it's pointing to the period in the console.log
– cjl85
Nov 25 '18 at 3:45
You can do this instead,console.log("current volume: ", this.props.currentVolume); console.log("length: ", this.props.length), just to get the values. if it outputs length: 0 or null or undefined then you found your problem
– Shawn Andrews
Nov 25 '18 at 3:50
|
show 1 more comment
If im not mistaken, the value for the volume slider isvalue={(this.props.currentVolume / this.props.length) || 0}? if thats the case, did you add to that render method aconsole.log(${this.props.currentVolume} || ${this.props.length})to output the values? it could a divide-by-zero
– Shawn Andrews
Nov 25 '18 at 3:35
Yeah I think you're right about the divide by zero but im not sure what you mean by adding the console.log in the render method. Right now, the volume slider doesn't slide and the moment I try to, it says NaN
– cjl85
Nov 25 '18 at 3:40
Adding it hereclass PlayerBar extends Component { render() { console.log(${this.props.currentVolume} || ${this.props.length}); return ( ... ); } }
– Shawn Andrews
Nov 25 '18 at 3:43
it's giving me a parsing error and it's pointing to the period in the console.log
– cjl85
Nov 25 '18 at 3:45
You can do this instead,console.log("current volume: ", this.props.currentVolume); console.log("length: ", this.props.length), just to get the values. if it outputs length: 0 or null or undefined then you found your problem
– Shawn Andrews
Nov 25 '18 at 3:50
If im not mistaken, the value for the volume slider is
value={(this.props.currentVolume / this.props.length) || 0}? if thats the case, did you add to that render method a console.log(${this.props.currentVolume} || ${this.props.length}) to output the values? it could a divide-by-zero– Shawn Andrews
Nov 25 '18 at 3:35
If im not mistaken, the value for the volume slider is
value={(this.props.currentVolume / this.props.length) || 0}? if thats the case, did you add to that render method a console.log(${this.props.currentVolume} || ${this.props.length}) to output the values? it could a divide-by-zero– Shawn Andrews
Nov 25 '18 at 3:35
Yeah I think you're right about the divide by zero but im not sure what you mean by adding the console.log in the render method. Right now, the volume slider doesn't slide and the moment I try to, it says NaN
– cjl85
Nov 25 '18 at 3:40
Yeah I think you're right about the divide by zero but im not sure what you mean by adding the console.log in the render method. Right now, the volume slider doesn't slide and the moment I try to, it says NaN
– cjl85
Nov 25 '18 at 3:40
Adding it here
class PlayerBar extends Component { render() { console.log(${this.props.currentVolume} || ${this.props.length}); return ( ... ); } }– Shawn Andrews
Nov 25 '18 at 3:43
Adding it here
class PlayerBar extends Component { render() { console.log(${this.props.currentVolume} || ${this.props.length}); return ( ... ); } }– Shawn Andrews
Nov 25 '18 at 3:43
it's giving me a parsing error and it's pointing to the period in the console.log
– cjl85
Nov 25 '18 at 3:45
it's giving me a parsing error and it's pointing to the period in the console.log
– cjl85
Nov 25 '18 at 3:45
You can do this instead,
console.log("current volume: ", this.props.currentVolume); console.log("length: ", this.props.length), just to get the values. if it outputs length: 0 or null or undefined then you found your problem– Shawn Andrews
Nov 25 '18 at 3:50
You can do this instead,
console.log("current volume: ", this.props.currentVolume); console.log("length: ", this.props.length), just to get the values. if it outputs length: 0 or null or undefined then you found your problem– Shawn Andrews
Nov 25 '18 at 3:50
|
show 1 more comment
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53464378%2fadding-volume-slider-and-display-time-react%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53464378%2fadding-volume-slider-and-display-time-react%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
If im not mistaken, the value for the volume slider is
value={(this.props.currentVolume / this.props.length) || 0}? if thats the case, did you add to that render method aconsole.log(${this.props.currentVolume} || ${this.props.length})to output the values? it could a divide-by-zero– Shawn Andrews
Nov 25 '18 at 3:35
Yeah I think you're right about the divide by zero but im not sure what you mean by adding the console.log in the render method. Right now, the volume slider doesn't slide and the moment I try to, it says NaN
– cjl85
Nov 25 '18 at 3:40
Adding it here
class PlayerBar extends Component { render() { console.log(${this.props.currentVolume} || ${this.props.length}); return ( ... ); } }– Shawn Andrews
Nov 25 '18 at 3:43
it's giving me a parsing error and it's pointing to the period in the console.log
– cjl85
Nov 25 '18 at 3:45
You can do this instead,
console.log("current volume: ", this.props.currentVolume); console.log("length: ", this.props.length), just to get the values. if it outputs length: 0 or null or undefined then you found your problem– Shawn Andrews
Nov 25 '18 at 3:50