Incremental Sieve of Eratosthenes












1












$begingroup$


I am in the process of learning rust and am still having some issues with borrowing and ownership. I find myself trying to borrow mutable references that are already borrowed as immutable references etc...



I noticed that when I try to iterate over the primes without owning them, I encounter issues trying to modify the composites hash map. I was able to get around this by calling to_owned on the vector. Is this the right way to handle this?



This uses the generator feature.



cargo -V 
cargo 1.35.0-nightly (0e35bd8af 2019-03-13)


    #![feature(generators, generator_trait)]

use std::collections::HashMap;
use std::ops::{Generator, GeneratorState};

let mut sieve = || {
let mut x: u32 = 2;
let mut composites: HashMap<u32, Vec<u32>> = HashMap::new();

loop {
match composites.get(&x) {
Some(primes) => {
for _prime in primes.to_owned() {
composites
.entry(x + _prime)
.and_modify(|v| v.push(_prime))
.or_insert(vec![_prime]);
composites.remove(&x);
}
}
None => {
yield x;
composites.insert(x * x, vec![x]);
}
}

x = x + 1;
}
};









share|improve this question











$endgroup$












  • $begingroup$
    @Stargateur this code is working, it does require generators though
    $endgroup$
    – kyle
    4 hours ago










  • $begingroup$
    @E_net4 I apologize, I had added in this information!
    $endgroup$
    – kyle
    3 hours ago
















1












$begingroup$


I am in the process of learning rust and am still having some issues with borrowing and ownership. I find myself trying to borrow mutable references that are already borrowed as immutable references etc...



I noticed that when I try to iterate over the primes without owning them, I encounter issues trying to modify the composites hash map. I was able to get around this by calling to_owned on the vector. Is this the right way to handle this?



This uses the generator feature.



cargo -V 
cargo 1.35.0-nightly (0e35bd8af 2019-03-13)


    #![feature(generators, generator_trait)]

use std::collections::HashMap;
use std::ops::{Generator, GeneratorState};

let mut sieve = || {
let mut x: u32 = 2;
let mut composites: HashMap<u32, Vec<u32>> = HashMap::new();

loop {
match composites.get(&x) {
Some(primes) => {
for _prime in primes.to_owned() {
composites
.entry(x + _prime)
.and_modify(|v| v.push(_prime))
.or_insert(vec![_prime]);
composites.remove(&x);
}
}
None => {
yield x;
composites.insert(x * x, vec![x]);
}
}

x = x + 1;
}
};









share|improve this question











$endgroup$












  • $begingroup$
    @Stargateur this code is working, it does require generators though
    $endgroup$
    – kyle
    4 hours ago










  • $begingroup$
    @E_net4 I apologize, I had added in this information!
    $endgroup$
    – kyle
    3 hours ago














1












1








1





$begingroup$


I am in the process of learning rust and am still having some issues with borrowing and ownership. I find myself trying to borrow mutable references that are already borrowed as immutable references etc...



I noticed that when I try to iterate over the primes without owning them, I encounter issues trying to modify the composites hash map. I was able to get around this by calling to_owned on the vector. Is this the right way to handle this?



This uses the generator feature.



cargo -V 
cargo 1.35.0-nightly (0e35bd8af 2019-03-13)


    #![feature(generators, generator_trait)]

use std::collections::HashMap;
use std::ops::{Generator, GeneratorState};

let mut sieve = || {
let mut x: u32 = 2;
let mut composites: HashMap<u32, Vec<u32>> = HashMap::new();

loop {
match composites.get(&x) {
Some(primes) => {
for _prime in primes.to_owned() {
composites
.entry(x + _prime)
.and_modify(|v| v.push(_prime))
.or_insert(vec![_prime]);
composites.remove(&x);
}
}
None => {
yield x;
composites.insert(x * x, vec![x]);
}
}

x = x + 1;
}
};









share|improve this question











$endgroup$




I am in the process of learning rust and am still having some issues with borrowing and ownership. I find myself trying to borrow mutable references that are already borrowed as immutable references etc...



I noticed that when I try to iterate over the primes without owning them, I encounter issues trying to modify the composites hash map. I was able to get around this by calling to_owned on the vector. Is this the right way to handle this?



This uses the generator feature.



cargo -V 
cargo 1.35.0-nightly (0e35bd8af 2019-03-13)


    #![feature(generators, generator_trait)]

use std::collections::HashMap;
use std::ops::{Generator, GeneratorState};

let mut sieve = || {
let mut x: u32 = 2;
let mut composites: HashMap<u32, Vec<u32>> = HashMap::new();

loop {
match composites.get(&x) {
Some(primes) => {
for _prime in primes.to_owned() {
composites
.entry(x + _prime)
.and_modify(|v| v.push(_prime))
.or_insert(vec![_prime]);
composites.remove(&x);
}
}
None => {
yield x;
composites.insert(x * x, vec![x]);
}
}

x = x + 1;
}
};






rust sieve-of-eratosthenes






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 12 mins ago









Jamal

30.4k11121227




30.4k11121227










asked 4 hours ago









kylekyle

1316




1316












  • $begingroup$
    @Stargateur this code is working, it does require generators though
    $endgroup$
    – kyle
    4 hours ago










  • $begingroup$
    @E_net4 I apologize, I had added in this information!
    $endgroup$
    – kyle
    3 hours ago


















  • $begingroup$
    @Stargateur this code is working, it does require generators though
    $endgroup$
    – kyle
    4 hours ago










  • $begingroup$
    @E_net4 I apologize, I had added in this information!
    $endgroup$
    – kyle
    3 hours ago
















$begingroup$
@Stargateur this code is working, it does require generators though
$endgroup$
– kyle
4 hours ago




$begingroup$
@Stargateur this code is working, it does require generators though
$endgroup$
– kyle
4 hours ago












$begingroup$
@E_net4 I apologize, I had added in this information!
$endgroup$
– kyle
3 hours ago




$begingroup$
@E_net4 I apologize, I had added in this information!
$endgroup$
– kyle
3 hours ago










0






active

oldest

votes











Your Answer





StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215708%2fincremental-sieve-of-eratosthenes%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes
















draft saved

draft discarded




















































Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215708%2fincremental-sieve-of-eratosthenes%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Costa Masnaga

Fotorealismo

Sidney Franklin