Nsryjdtyk

I have a logger module that is able to log three types of messages from my application.

• default ones


• events


• commands

Currently I export this module

module.exports = {

    logMessage: (message) => {

        logAction('Info', null, message);

    },

    logEvent: (eventName, message) => {

        logAction('Event', eventName, message);

    },

    logCommand: (commandName, message) => {

        logAction('Command', commandName, message);

    }

};

and when it comes to the logAction function I am looking for a clean way to concatenate all the information of the log message.

My first solution would be

function logAction(actionType, actionName, message){

    actionName = actionName ? ` => ${actionName}` : '';



    let logMessage = `

[${actionType}${actionName}]

[${new Date()}]`;



    if(message){

        logMessage += `n${message}`;

    }



    console.log(logMessage);

}

Is there a way improving this one? I don't know if I really need the if(message) check. Also there might be a better way for

actionName = actionName ? ` => ${actionName}` : '';

My second solution would be an array of information that gets converted to a string at the end.

function logAction(actionType, actionName, message){

    const actionSegments = [`[${actionType}`];



    if(actionName)

        actionSegments.push(` => ${actionName}`);



    actionSegments.push(`]n[${new Date()}]`);



    if(message)

        actionSegments.push(`n${message}`);



    console.log(actionSegments.join(''));

}

I think this would be a bad solution because there is no need for it.

Any suggestions or improvements?