Null on global object in viewmodel
0
I want to pass ID from onItemClick method to the editTask method by global object Task mTask, but when I want to set ID on mTask.setId(item.getId()); in onItemClick I always get null... If I set ID on: ID = item.getId(); is fine. What could be the problem or maybe you know better solution of passing data between methods in viewmodel?
ViewModel:
public class MainViewModel extends AndroidViewModel implements RecyclerViewAdapter.OnItemClickListener {
private TaskRepository taskRepository;
private LiveData<List<Task>> allTasks;
public final ObservableField<String> description = new ObservableField<>();
public final ObservableField<String> date = new ObservableField<>();
public final ObservableField<String> time = new ObservableField<>();
private String TAG;
private int ID;
private Task mTask;
public MainViewModel(@NonNull Application application) {
super(application);
taskRepository = new TaskRepository(application);
allTasks = taskRepository.getAllTasks();
}
public LiveData<List<Task>> getAllTasks() {
return allTasks;
}
public void deleteTask(Task task) {
taskRepository.delete(task);
}
public void getDataToEdit() {
editTask(description.get(), date.get(), time.get());
}
public void editTask(String description, String date, String time) {
Task task = new Task(description, date, time);
task.setId(ID);
taskRepository.update(task);
Log.d(TAG, "MVM editTask " + task.getId());
}
@Override
public void onItemClick(View view, Task item) {
Log.d(TAG, "MVM " + item.getDescription() + " / " + item.getDate() + " / " + item.getTime() + " / " + mTask);
description.set(item.getDescription());
date.set(item.getDate());
time.set(item.getTime());
ID = item.getId();
mTask.setId(item.getId());
if (mTask != null) {
mTask.setId(item.getId());
}
}
android android-databinding android-viewmodel asked Nov 23 '18 at 14:26
user9897182user9897182
357
add a comment |
0
I want to pass ID from onItemClick method to the editTask method by global object Task mTask, but when I want to set ID on mTask.setId(item.getId()); in onItemClick I always get null... If I set ID on: ID = item.getId(); is fine. What could be the problem or maybe you know better solution of passing data between methods in viewmodel?
ViewModel:
public class MainViewModel extends AndroidViewModel implements RecyclerViewAdapter.OnItemClickListener {
private TaskRepository taskRepository;
private LiveData<List<Task>> allTasks;
public final ObservableField<String> description = new ObservableField<>();
public final ObservableField<String> date = new ObservableField<>();
public final ObservableField<String> time = new ObservableField<>();
private String TAG;
private int ID;
private Task mTask;
public MainViewModel(@NonNull Application application) {
super(application);
taskRepository = new TaskRepository(application);
allTasks = taskRepository.getAllTasks();
}
public LiveData<List<Task>> getAllTasks() {
return allTasks;
}
public void deleteTask(Task task) {
taskRepository.delete(task);
}
public void getDataToEdit() {
editTask(description.get(), date.get(), time.get());
}
public void editTask(String description, String date, String time) {
Task task = new Task(description, date, time);
task.setId(ID);
taskRepository.update(task);
Log.d(TAG, "MVM editTask " + task.getId());
}
@Override
public void onItemClick(View view, Task item) {
Log.d(TAG, "MVM " + item.getDescription() + " / " + item.getDate() + " / " + item.getTime() + " / " + mTask);
description.set(item.getDescription());
date.set(item.getDate());
time.set(item.getTime());
ID = item.getId();
mTask.setId(item.getId());
if (mTask != null) {
mTask.setId(item.getId());
}
}
asked Nov 23 '18 at 14:26
user9897182user9897182
357
1
mTaskvariable never initialized. Can't find where you create instance of it. That's why when calling ` mTask.setId(item.getId());` you have NPE.
– ConstOrVar
Nov 24 '18 at 7:08
add a comment |
0
0
0
I want to pass ID from onItemClick method to the editTask method by global object Task mTask, but when I want to set ID on mTask.setId(item.getId()); in onItemClick I always get null... If I set ID on: ID = item.getId(); is fine. What could be the problem or maybe you know better solution of passing data between methods in viewmodel?
ViewModel:
public class MainViewModel extends AndroidViewModel implements RecyclerViewAdapter.OnItemClickListener {
private TaskRepository taskRepository;
private LiveData<List<Task>> allTasks;
public final ObservableField<String> description = new ObservableField<>();
public final ObservableField<String> date = new ObservableField<>();
public final ObservableField<String> time = new ObservableField<>();
private String TAG;
private int ID;
private Task mTask;
public MainViewModel(@NonNull Application application) {
super(application);
taskRepository = new TaskRepository(application);
allTasks = taskRepository.getAllTasks();
}
public LiveData<List<Task>> getAllTasks() {
return allTasks;
}
public void deleteTask(Task task) {
taskRepository.delete(task);
}
public void getDataToEdit() {
editTask(description.get(), date.get(), time.get());
}
public void editTask(String description, String date, String time) {
Task task = new Task(description, date, time);
task.setId(ID);
taskRepository.update(task);
Log.d(TAG, "MVM editTask " + task.getId());
}
@Override
public void onItemClick(View view, Task item) {
Log.d(TAG, "MVM " + item.getDescription() + " / " + item.getDate() + " / " + item.getTime() + " / " + mTask);
description.set(item.getDescription());
date.set(item.getDate());
time.set(item.getTime());
ID = item.getId();
mTask.setId(item.getId());
if (mTask != null) {
mTask.setId(item.getId());
}
}
asked Nov 23 '18 at 14:26
user9897182user9897182
357
I want to pass ID from onItemClick method to the editTask method by global object Task mTask, but when I want to set ID on mTask.setId(item.getId()); in onItemClick I always get null... If I set ID on: ID = item.getId(); is fine. What could be the problem or maybe you know better solution of passing data between methods in viewmodel?
ViewModel:
public class MainViewModel extends AndroidViewModel implements RecyclerViewAdapter.OnItemClickListener {
private TaskRepository taskRepository;
private LiveData<List<Task>> allTasks;
public final ObservableField<String> description = new ObservableField<>();
public final ObservableField<String> date = new ObservableField<>();
public final ObservableField<String> time = new ObservableField<>();
private String TAG;
private int ID;
private Task mTask;
public MainViewModel(@NonNull Application application) {
super(application);
taskRepository = new TaskRepository(application);
allTasks = taskRepository.getAllTasks();
}
public LiveData<List<Task>> getAllTasks() {
return allTasks;
}
public void deleteTask(Task task) {
taskRepository.delete(task);
}
public void getDataToEdit() {
editTask(description.get(), date.get(), time.get());
}
public void editTask(String description, String date, String time) {
Task task = new Task(description, date, time);
task.setId(ID);
taskRepository.update(task);
Log.d(TAG, "MVM editTask " + task.getId());
}
@Override
public void onItemClick(View view, Task item) {
Log.d(TAG, "MVM " + item.getDescription() + " / " + item.getDate() + " / " + item.getTime() + " / " + mTask);
description.set(item.getDescription());
date.set(item.getDate());
time.set(item.getTime());
ID = item.getId();
mTask.setId(item.getId());
if (mTask != null) {
mTask.setId(item.getId());
}
}
asked Nov 23 '18 at 14:26
user9897182user9897182
357
asked Nov 23 '18 at 14:26
user9897182user9897182
357
asked Nov 23 '18 at 14:26
user9897182user9897182
357
asked Nov 23 '18 at 14:26
user9897182user9897182
357
asked Nov 23 '18 at 14:26
user9897182user9897182
357
357
1
mTaskvariable never initialized. Can't find where you create instance of it. That's why when calling ` mTask.setId(item.getId());` you have NPE.
– ConstOrVar
Nov 24 '18 at 7:08
add a comment |
1
mTaskvariable never initialized. Can't find where you create instance of it. That's why when calling ` mTask.setId(item.getId());` you have NPE.
– ConstOrVar
Nov 24 '18 at 7:08
1
1
mTask variable never initialized. Can't find where you create instance of it. That's why when calling ` mTask.setId(item.getId());` you have NPE.– ConstOrVar
Nov 24 '18 at 7:08
mTask variable never initialized. Can't find where you create instance of it. That's why when calling ` mTask.setId(item.getId());` you have NPE.– ConstOrVar
Nov 24 '18 at 7:08
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53448481%2fnull-on-global-object-in-viewmodel%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53448481%2fnull-on-global-object-in-viewmodel%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
mTaskvariable never initialized. Can't find where you create instance of it. That's why when calling ` mTask.setId(item.getId());` you have NPE.– ConstOrVar
Nov 24 '18 at 7:08