Learning Javascript - Is this a messy implementation of a Javascript Slider?
0
I've been learning JS for a few months now and I've just finished creating a small image slider for a website. The sliders functionality is as follows:
- Continuously cycle through images and loop back to the start
- Allow the user to click through to a certain section
- When clicked, the cycle timer must reset and the loop must continue from that point
- cycle through a corresponding DOM element (in this case it's a testimonial quote)
I'm mainly looking for pointers on how to make my code more efficient or if I've used bad practice. Any help would be appreciated.
var container = document.getElementById('slide-container');
var button = document.getElementById('slider-buttons');
var quote = document.getElementById('quote-container');
var interval = 0;
sliderMove = function(position){
// Move container to next image
container.style.left = -(350 * position) + 'px';
// Remove active classes from all children
for (var i = 0; i < quote.children.length; i++) {
quote.children[i].classList.remove("quote-active");
button.children[i].classList.remove('active');
};
// Add active classes to specified children
quote.children[position].classList.add("quote-active");
button.children[position].classList.add('active');
// Increase global interval variable by 1
interval++;
// Set interval back to 0 if it exceeds the amount of quotes
if (interval >= quote.children.length) {
interval = 0;
};
};
// Add event listener to buttons
button.addEventListener('click', function(event){
clearInterval(timer); // Resets timer when user clicks on an image
autoMove(); // Restarts timer
if (event.target.id > -1) { // Ensures the target is valid
interval = event.target.id;
sliderMove(interval);
};
});
// Auto Rotate
function autoMove(index) {
timer = setInterval(function(){
index = interval;
sliderMove(index);
},5000);
}
autoMove(0);
sliderMove(0);
javascript
asked 3 mins ago
Lachlan McBride
1
New contributor
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
0
I've been learning JS for a few months now and I've just finished creating a small image slider for a website. The sliders functionality is as follows:
- Continuously cycle through images and loop back to the start
- Allow the user to click through to a certain section
- When clicked, the cycle timer must reset and the loop must continue from that point
- cycle through a corresponding DOM element (in this case it's a testimonial quote)
I'm mainly looking for pointers on how to make my code more efficient or if I've used bad practice. Any help would be appreciated.
var container = document.getElementById('slide-container');
var button = document.getElementById('slider-buttons');
var quote = document.getElementById('quote-container');
var interval = 0;
sliderMove = function(position){
// Move container to next image
container.style.left = -(350 * position) + 'px';
// Remove active classes from all children
for (var i = 0; i < quote.children.length; i++) {
quote.children[i].classList.remove("quote-active");
button.children[i].classList.remove('active');
};
// Add active classes to specified children
quote.children[position].classList.add("quote-active");
button.children[position].classList.add('active');
// Increase global interval variable by 1
interval++;
// Set interval back to 0 if it exceeds the amount of quotes
if (interval >= quote.children.length) {
interval = 0;
};
};
// Add event listener to buttons
button.addEventListener('click', function(event){
clearInterval(timer); // Resets timer when user clicks on an image
autoMove(); // Restarts timer
if (event.target.id > -1) { // Ensures the target is valid
interval = event.target.id;
sliderMove(interval);
};
});
// Auto Rotate
function autoMove(index) {
timer = setInterval(function(){
index = interval;
sliderMove(index);
},5000);
}
autoMove(0);
sliderMove(0);
javascript
asked 3 mins ago
Lachlan McBride
1
New contributor
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
0
0
0
I've been learning JS for a few months now and I've just finished creating a small image slider for a website. The sliders functionality is as follows:
- Continuously cycle through images and loop back to the start
- Allow the user to click through to a certain section
- When clicked, the cycle timer must reset and the loop must continue from that point
- cycle through a corresponding DOM element (in this case it's a testimonial quote)
I'm mainly looking for pointers on how to make my code more efficient or if I've used bad practice. Any help would be appreciated.
var container = document.getElementById('slide-container');
var button = document.getElementById('slider-buttons');
var quote = document.getElementById('quote-container');
var interval = 0;
sliderMove = function(position){
// Move container to next image
container.style.left = -(350 * position) + 'px';
// Remove active classes from all children
for (var i = 0; i < quote.children.length; i++) {
quote.children[i].classList.remove("quote-active");
button.children[i].classList.remove('active');
};
// Add active classes to specified children
quote.children[position].classList.add("quote-active");
button.children[position].classList.add('active');
// Increase global interval variable by 1
interval++;
// Set interval back to 0 if it exceeds the amount of quotes
if (interval >= quote.children.length) {
interval = 0;
};
};
// Add event listener to buttons
button.addEventListener('click', function(event){
clearInterval(timer); // Resets timer when user clicks on an image
autoMove(); // Restarts timer
if (event.target.id > -1) { // Ensures the target is valid
interval = event.target.id;
sliderMove(interval);
};
});
// Auto Rotate
function autoMove(index) {
timer = setInterval(function(){
index = interval;
sliderMove(index);
},5000);
}
autoMove(0);
sliderMove(0);
javascript
asked 3 mins ago
Lachlan McBride
1
New contributor
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
I've been learning JS for a few months now and I've just finished creating a small image slider for a website. The sliders functionality is as follows:
- Continuously cycle through images and loop back to the start
- Allow the user to click through to a certain section
- When clicked, the cycle timer must reset and the loop must continue from that point
- cycle through a corresponding DOM element (in this case it's a testimonial quote)
I'm mainly looking for pointers on how to make my code more efficient or if I've used bad practice. Any help would be appreciated.
var container = document.getElementById('slide-container');
var button = document.getElementById('slider-buttons');
var quote = document.getElementById('quote-container');
var interval = 0;
sliderMove = function(position){
// Move container to next image
container.style.left = -(350 * position) + 'px';
// Remove active classes from all children
for (var i = 0; i < quote.children.length; i++) {
quote.children[i].classList.remove("quote-active");
button.children[i].classList.remove('active');
};
// Add active classes to specified children
quote.children[position].classList.add("quote-active");
button.children[position].classList.add('active');
// Increase global interval variable by 1
interval++;
// Set interval back to 0 if it exceeds the amount of quotes
if (interval >= quote.children.length) {
interval = 0;
};
};
// Add event listener to buttons
button.addEventListener('click', function(event){
clearInterval(timer); // Resets timer when user clicks on an image
autoMove(); // Restarts timer
if (event.target.id > -1) { // Ensures the target is valid
interval = event.target.id;
sliderMove(interval);
};
});
// Auto Rotate
function autoMove(index) {
timer = setInterval(function(){
index = interval;
sliderMove(index);
},5000);
}
autoMove(0);
sliderMove(0);
javascript
javascript
asked 3 mins ago
Lachlan McBride
1
New contributor
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
Lachlan McBride
1
New contributor
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
Lachlan McBride
1
New contributor
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 3 mins ago
Lachlan McBride
1
asked 3 mins ago
Lachlan McBride
1
1
New contributor
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Lachlan McBride is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Lachlan McBride is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211008%2flearning-javascript-is-this-a-messy-implementation-of-a-javascript-slider%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Lachlan McBride is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Lachlan McBride is a new contributor. Be nice, and check out our Code of Conduct.
Lachlan McBride is a new contributor. Be nice, and check out our Code of Conduct.
Lachlan McBride is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211008%2flearning-javascript-is-this-a-messy-implementation-of-a-javascript-slider%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
