Getting the value of a Batch File Variable that is within another Variable
I am trying to create a batch file that adds a Desktop shortcut to a network share using 'mklink'.
My code worked fine, but I have now found some users that have their desktop redirected. To get around this I have tried using 'reg query' to get the current desktop location
for /f "tokens=3" %%a in ('reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"') do set DTLOC=%%a
mklink %DTLOC%"Shortcut Name" "\NETWORK-PCShare Name" /D
The problem now is that for a normal Desktop location 'reg query' returns the string %USERPROFILE%desktop but as this is within a variable itself (DTLOC), it never resolves to the actual value. So all I can get from DTLOC is %USERPROFILE%desktop and not say c:usersusernamedesktop.
The actual command that is output from the batch file gives:
mklink %USERPROFILE%desktop"Shortcut Name" "\NETWORK-PCShare Name" /D
This causes the shortcut creation to fail with a 'file not found' error.
Is there a way to expand the output from 'reg query' to give the actual value, so that it can be used in the mklink command.
file batch-file variables
asked Nov 22 '18 at 16:58
dabdab
31
add a comment |
I am trying to create a batch file that adds a Desktop shortcut to a network share using 'mklink'.
My code worked fine, but I have now found some users that have their desktop redirected. To get around this I have tried using 'reg query' to get the current desktop location
for /f "tokens=3" %%a in ('reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"') do set DTLOC=%%a
mklink %DTLOC%"Shortcut Name" "\NETWORK-PCShare Name" /D
The problem now is that for a normal Desktop location 'reg query' returns the string %USERPROFILE%desktop but as this is within a variable itself (DTLOC), it never resolves to the actual value. So all I can get from DTLOC is %USERPROFILE%desktop and not say c:usersusernamedesktop.
The actual command that is output from the batch file gives:
mklink %USERPROFILE%desktop"Shortcut Name" "\NETWORK-PCShare Name" /D
This causes the shortcut creation to fail with a 'file not found' error.
Is there a way to expand the output from 'reg query' to give the actual value, so that it can be used in the mklink command.
file batch-file variables
asked Nov 22 '18 at 16:58
dabdab
31
1
Insert acallcommand before:call mklink %DTLOC%...
– Aacini
Nov 22 '18 at 17:01
Adding the call works perfectly, Thank you.
– dab
Nov 23 '18 at 12:09
add a comment |
I am trying to create a batch file that adds a Desktop shortcut to a network share using 'mklink'.
My code worked fine, but I have now found some users that have their desktop redirected. To get around this I have tried using 'reg query' to get the current desktop location
for /f "tokens=3" %%a in ('reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"') do set DTLOC=%%a
mklink %DTLOC%"Shortcut Name" "\NETWORK-PCShare Name" /D
The problem now is that for a normal Desktop location 'reg query' returns the string %USERPROFILE%desktop but as this is within a variable itself (DTLOC), it never resolves to the actual value. So all I can get from DTLOC is %USERPROFILE%desktop and not say c:usersusernamedesktop.
The actual command that is output from the batch file gives:
mklink %USERPROFILE%desktop"Shortcut Name" "\NETWORK-PCShare Name" /D
This causes the shortcut creation to fail with a 'file not found' error.
Is there a way to expand the output from 'reg query' to give the actual value, so that it can be used in the mklink command.
file batch-file variables
asked Nov 22 '18 at 16:58
dabdab
31
I am trying to create a batch file that adds a Desktop shortcut to a network share using 'mklink'.
My code worked fine, but I have now found some users that have their desktop redirected. To get around this I have tried using 'reg query' to get the current desktop location
for /f "tokens=3" %%a in ('reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"') do set DTLOC=%%a
mklink %DTLOC%"Shortcut Name" "\NETWORK-PCShare Name" /D
The problem now is that for a normal Desktop location 'reg query' returns the string %USERPROFILE%desktop but as this is within a variable itself (DTLOC), it never resolves to the actual value. So all I can get from DTLOC is %USERPROFILE%desktop and not say c:usersusernamedesktop.
The actual command that is output from the batch file gives:
mklink %USERPROFILE%desktop"Shortcut Name" "\NETWORK-PCShare Name" /D
This causes the shortcut creation to fail with a 'file not found' error.
Is there a way to expand the output from 'reg query' to give the actual value, so that it can be used in the mklink command.
file batch-file variables
file batch-file variables
asked Nov 22 '18 at 16:58
dabdab
31
asked Nov 22 '18 at 16:58
dabdab
31
asked Nov 22 '18 at 16:58
dabdab
31
asked Nov 22 '18 at 16:58
dabdab
31
asked Nov 22 '18 at 16:58
dabdab
31
31
1
Insert acallcommand before:call mklink %DTLOC%...
– Aacini
Nov 22 '18 at 17:01
Adding the call works perfectly, Thank you.
– dab
Nov 23 '18 at 12:09
add a comment |
1
Insert acallcommand before:call mklink %DTLOC%...
– Aacini
Nov 22 '18 at 17:01
Adding the call works perfectly, Thank you.
– dab
Nov 23 '18 at 12:09
1
1
Insert a
call command before: call mklink %DTLOC%...– Aacini
Nov 22 '18 at 17:01
Insert a
call command before: call mklink %DTLOC%...– Aacini
Nov 22 '18 at 17:01
Adding the call works perfectly, Thank you.
– dab
Nov 23 '18 at 12:09
Adding the call works perfectly, Thank you.
– dab
Nov 23 '18 at 12:09
add a comment |
1 Answer
1
active
oldest
votes
The solution is to use call, which introduces another parsing phase of the command line, so nested variables become expanded too. In addition, let me recommend to adapt quotation as follows:
for /f "tokens=3" %%a in ('
reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"
') do set "DTLOC=%%a"
call mklink "%DTLOC%Shortcut Name" "\NETWORK-PCShare Name" /D
answered Nov 22 '18 at 17:15
aschipflaschipfl
18.5k82856
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53435471%2fgetting-the-value-of-a-batch-file-variable-that-is-within-another-variable%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
The solution is to use call, which introduces another parsing phase of the command line, so nested variables become expanded too. In addition, let me recommend to adapt quotation as follows:
for /f "tokens=3" %%a in ('
reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"
') do set "DTLOC=%%a"
call mklink "%DTLOC%Shortcut Name" "\NETWORK-PCShare Name" /D
answered Nov 22 '18 at 17:15
aschipflaschipfl
18.5k82856
add a comment |
The solution is to use call, which introduces another parsing phase of the command line, so nested variables become expanded too. In addition, let me recommend to adapt quotation as follows:
for /f "tokens=3" %%a in ('
reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"
') do set "DTLOC=%%a"
call mklink "%DTLOC%Shortcut Name" "\NETWORK-PCShare Name" /D
answered Nov 22 '18 at 17:15
aschipflaschipfl
18.5k82856
add a comment |
The solution is to use call, which introduces another parsing phase of the command line, so nested variables become expanded too. In addition, let me recommend to adapt quotation as follows:
for /f "tokens=3" %%a in ('
reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"
') do set "DTLOC=%%a"
call mklink "%DTLOC%Shortcut Name" "\NETWORK-PCShare Name" /D
answered Nov 22 '18 at 17:15
aschipflaschipfl
18.5k82856
The solution is to use call, which introduces another parsing phase of the command line, so nested variables become expanded too. In addition, let me recommend to adapt quotation as follows:
for /f "tokens=3" %%a in ('
reg query "HKEY_CURRENT_USERSoftwareMicrosoftWindowsCurrentVersionExplorerUser Shell Folders" /v Desktop ^|findstr /ri "REG_EXPAND_SZ"
') do set "DTLOC=%%a"
call mklink "%DTLOC%Shortcut Name" "\NETWORK-PCShare Name" /D
answered Nov 22 '18 at 17:15
aschipflaschipfl
18.5k82856
answered Nov 22 '18 at 17:15
aschipflaschipfl
18.5k82856
answered Nov 22 '18 at 17:15
aschipflaschipfl
18.5k82856
answered Nov 22 '18 at 17:15
aschipflaschipfl
18.5k82856
18.5k82856
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53435471%2fgetting-the-value-of-a-batch-file-variable-that-is-within-another-variable%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Insert a
callcommand before:call mklink %DTLOC%...– Aacini
Nov 22 '18 at 17:01
Adding the call works perfectly, Thank you.
– dab
Nov 23 '18 at 12:09