Modal does not close after clicking button












0















im trying to build a modal, with a try-catch block, so if everyting is valid and entered correctly in the form, the modal should be closed



This is the function login, i wonder why $('#dialog').modal('hide'); does not work



  <script>
function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');
</script>



</head>


This is the modal



 <div class="container">
<h2></h2>
<button type="button" class="btn btn-danger" data-toggle="modal" data-target="#dialog">
Login-Dialog öffnen
</button>

<!-- The Modal -->
<div class="modal" id="dialog">
<div class="modal-dialog">
<div class="modal-content">
<div class="modal-header">
<h4 class="modal-title">Login (im header)</h4>
<button type="button" class="close" data-dismiss="modal">&times;</button>
</div>

<div class="modal-body">
<div class="container">
<p>im body:</p>
<form>
<div class="form-group row">
<label for="name" class="col-sm-2 col-form-label">Name</label>
<div class="col-sm-10">
<input type="text" class="form-control" placeholder="Name" id="name">
</div>
</div>
<div class="form-group row">
<label for="email" class="col-sm-2 col-form-label">E-Mail</label>
<div class="col-sm-10">
<input type="email" class="form-control" placeholder="E-Mail" id="email">
</div>
</div>
<div class="form-group row">
<label for="plz" class="col-sm-2 col-form-label">PLZ</label>
<div class="col-sm-10">
<input type="number" class="form-control" placeholder="PLZ" id="plz">
</div>
</div>
<div class="form-group row">
<label for="ort" class="col-sm-2 col-form-label">Ort</label>
<div class="col-sm-10">
<input type="text" class="form-control" id="ort" placeholder="Ort">
</div>
</div>
<div class="form-group row">
<label for="strasse" class="col-sm-2 col-form-label">Strasse und Hausnummer</label>
<div class="col-sm-10">
<input type="text" class="form-control" id="strasse" placeholder="Strasse und Hausnummer">
</div>
</div>
</form>
</div>
</div>

<div class="modal-footer">
<button type="button" class="btn btn-primary btn-block" onclick="login()">Speichern</button>
</div>
</div>
</div>
</div>

</div>









share|improve this question























  • Put $('#dialog').modal('hide'); inside the function. It's outside the function.

    – Niraj Kaushal
    Nov 24 '18 at 12:42


















0















im trying to build a modal, with a try-catch block, so if everyting is valid and entered correctly in the form, the modal should be closed



This is the function login, i wonder why $('#dialog').modal('hide'); does not work



  <script>
function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');
</script>



</head>


This is the modal



 <div class="container">
<h2></h2>
<button type="button" class="btn btn-danger" data-toggle="modal" data-target="#dialog">
Login-Dialog öffnen
</button>

<!-- The Modal -->
<div class="modal" id="dialog">
<div class="modal-dialog">
<div class="modal-content">
<div class="modal-header">
<h4 class="modal-title">Login (im header)</h4>
<button type="button" class="close" data-dismiss="modal">&times;</button>
</div>

<div class="modal-body">
<div class="container">
<p>im body:</p>
<form>
<div class="form-group row">
<label for="name" class="col-sm-2 col-form-label">Name</label>
<div class="col-sm-10">
<input type="text" class="form-control" placeholder="Name" id="name">
</div>
</div>
<div class="form-group row">
<label for="email" class="col-sm-2 col-form-label">E-Mail</label>
<div class="col-sm-10">
<input type="email" class="form-control" placeholder="E-Mail" id="email">
</div>
</div>
<div class="form-group row">
<label for="plz" class="col-sm-2 col-form-label">PLZ</label>
<div class="col-sm-10">
<input type="number" class="form-control" placeholder="PLZ" id="plz">
</div>
</div>
<div class="form-group row">
<label for="ort" class="col-sm-2 col-form-label">Ort</label>
<div class="col-sm-10">
<input type="text" class="form-control" id="ort" placeholder="Ort">
</div>
</div>
<div class="form-group row">
<label for="strasse" class="col-sm-2 col-form-label">Strasse und Hausnummer</label>
<div class="col-sm-10">
<input type="text" class="form-control" id="strasse" placeholder="Strasse und Hausnummer">
</div>
</div>
</form>
</div>
</div>

<div class="modal-footer">
<button type="button" class="btn btn-primary btn-block" onclick="login()">Speichern</button>
</div>
</div>
</div>
</div>

</div>









share|improve this question























  • Put $('#dialog').modal('hide'); inside the function. It's outside the function.

    – Niraj Kaushal
    Nov 24 '18 at 12:42
















0












0








0








im trying to build a modal, with a try-catch block, so if everyting is valid and entered correctly in the form, the modal should be closed



This is the function login, i wonder why $('#dialog').modal('hide'); does not work



  <script>
function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');
</script>



</head>


This is the modal



 <div class="container">
<h2></h2>
<button type="button" class="btn btn-danger" data-toggle="modal" data-target="#dialog">
Login-Dialog öffnen
</button>

<!-- The Modal -->
<div class="modal" id="dialog">
<div class="modal-dialog">
<div class="modal-content">
<div class="modal-header">
<h4 class="modal-title">Login (im header)</h4>
<button type="button" class="close" data-dismiss="modal">&times;</button>
</div>

<div class="modal-body">
<div class="container">
<p>im body:</p>
<form>
<div class="form-group row">
<label for="name" class="col-sm-2 col-form-label">Name</label>
<div class="col-sm-10">
<input type="text" class="form-control" placeholder="Name" id="name">
</div>
</div>
<div class="form-group row">
<label for="email" class="col-sm-2 col-form-label">E-Mail</label>
<div class="col-sm-10">
<input type="email" class="form-control" placeholder="E-Mail" id="email">
</div>
</div>
<div class="form-group row">
<label for="plz" class="col-sm-2 col-form-label">PLZ</label>
<div class="col-sm-10">
<input type="number" class="form-control" placeholder="PLZ" id="plz">
</div>
</div>
<div class="form-group row">
<label for="ort" class="col-sm-2 col-form-label">Ort</label>
<div class="col-sm-10">
<input type="text" class="form-control" id="ort" placeholder="Ort">
</div>
</div>
<div class="form-group row">
<label for="strasse" class="col-sm-2 col-form-label">Strasse und Hausnummer</label>
<div class="col-sm-10">
<input type="text" class="form-control" id="strasse" placeholder="Strasse und Hausnummer">
</div>
</div>
</form>
</div>
</div>

<div class="modal-footer">
<button type="button" class="btn btn-primary btn-block" onclick="login()">Speichern</button>
</div>
</div>
</div>
</div>

</div>









share|improve this question














im trying to build a modal, with a try-catch block, so if everyting is valid and entered correctly in the form, the modal should be closed



This is the function login, i wonder why $('#dialog').modal('hide'); does not work



  <script>
function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');
</script>



</head>


This is the modal



 <div class="container">
<h2></h2>
<button type="button" class="btn btn-danger" data-toggle="modal" data-target="#dialog">
Login-Dialog öffnen
</button>

<!-- The Modal -->
<div class="modal" id="dialog">
<div class="modal-dialog">
<div class="modal-content">
<div class="modal-header">
<h4 class="modal-title">Login (im header)</h4>
<button type="button" class="close" data-dismiss="modal">&times;</button>
</div>

<div class="modal-body">
<div class="container">
<p>im body:</p>
<form>
<div class="form-group row">
<label for="name" class="col-sm-2 col-form-label">Name</label>
<div class="col-sm-10">
<input type="text" class="form-control" placeholder="Name" id="name">
</div>
</div>
<div class="form-group row">
<label for="email" class="col-sm-2 col-form-label">E-Mail</label>
<div class="col-sm-10">
<input type="email" class="form-control" placeholder="E-Mail" id="email">
</div>
</div>
<div class="form-group row">
<label for="plz" class="col-sm-2 col-form-label">PLZ</label>
<div class="col-sm-10">
<input type="number" class="form-control" placeholder="PLZ" id="plz">
</div>
</div>
<div class="form-group row">
<label for="ort" class="col-sm-2 col-form-label">Ort</label>
<div class="col-sm-10">
<input type="text" class="form-control" id="ort" placeholder="Ort">
</div>
</div>
<div class="form-group row">
<label for="strasse" class="col-sm-2 col-form-label">Strasse und Hausnummer</label>
<div class="col-sm-10">
<input type="text" class="form-control" id="strasse" placeholder="Strasse und Hausnummer">
</div>
</div>
</form>
</div>
</div>

<div class="modal-footer">
<button type="button" class="btn btn-primary btn-block" onclick="login()">Speichern</button>
</div>
</div>
</div>
</div>

</div>






javascript bootstrap-4






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 24 '18 at 12:32









AlpinwhitessAlpinwhitess

63




63













  • Put $('#dialog').modal('hide'); inside the function. It's outside the function.

    – Niraj Kaushal
    Nov 24 '18 at 12:42





















  • Put $('#dialog').modal('hide'); inside the function. It's outside the function.

    – Niraj Kaushal
    Nov 24 '18 at 12:42



















Put $('#dialog').modal('hide'); inside the function. It's outside the function.

– Niraj Kaushal
Nov 24 '18 at 12:42







Put $('#dialog').modal('hide'); inside the function. It's outside the function.

– Niraj Kaushal
Nov 24 '18 at 12:42














2 Answers
2






active

oldest

votes


















0














The only problem you have is that the $("#dialog").modal('hide') statement isn't inside your login function body.
This should work.



function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide');
}





share|improve this answer
























  • Thank you that worked :)

    – Alpinwhitess
    Nov 24 '18 at 12:53



















0














It seems like you are closing your login function on the line before the call to close the modal.
Try to change this:



kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');


to this:



kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide'); }





share|improve this answer
























  • That worked, thank you

    – Alpinwhitess
    Nov 24 '18 at 12:55











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53458187%2fmodal-does-not-close-after-clicking-button%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























2 Answers
2






active

oldest

votes








2 Answers
2






active

oldest

votes









active

oldest

votes






active

oldest

votes









0














The only problem you have is that the $("#dialog").modal('hide') statement isn't inside your login function body.
This should work.



function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide');
}





share|improve this answer
























  • Thank you that worked :)

    – Alpinwhitess
    Nov 24 '18 at 12:53
















0














The only problem you have is that the $("#dialog").modal('hide') statement isn't inside your login function body.
This should work.



function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide');
}





share|improve this answer
























  • Thank you that worked :)

    – Alpinwhitess
    Nov 24 '18 at 12:53














0












0








0







The only problem you have is that the $("#dialog").modal('hide') statement isn't inside your login function body.
This should work.



function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide');
}





share|improve this answer













The only problem you have is that the $("#dialog").modal('hide') statement isn't inside your login function body.
This should work.



function login() {

var kontakt = new Kontakt();
kontakt.name = document.getElementById('name').value;
kontakt.email = document.getElementById('email').value;
kontakt.plz = document.getElementById('plz').value;
kontakt.ort = document.getElementById('ort').value;
kontakt.strasse = document.getElementById('strasse').value;




try {
kontakt.pruefe();
}
catch(err) {
return window.alert(err.message);
}

kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide');
}






share|improve this answer












share|improve this answer



share|improve this answer










answered Nov 24 '18 at 12:41









Mehdi BenHemdeneMehdi BenHemdene

4814




4814













  • Thank you that worked :)

    – Alpinwhitess
    Nov 24 '18 at 12:53



















  • Thank you that worked :)

    – Alpinwhitess
    Nov 24 '18 at 12:53

















Thank you that worked :)

– Alpinwhitess
Nov 24 '18 at 12:53





Thank you that worked :)

– Alpinwhitess
Nov 24 '18 at 12:53













0














It seems like you are closing your login function on the line before the call to close the modal.
Try to change this:



kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');


to this:



kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide'); }





share|improve this answer
























  • That worked, thank you

    – Alpinwhitess
    Nov 24 '18 at 12:55
















0














It seems like you are closing your login function on the line before the call to close the modal.
Try to change this:



kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');


to this:



kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide'); }





share|improve this answer
























  • That worked, thank you

    – Alpinwhitess
    Nov 24 '18 at 12:55














0












0








0







It seems like you are closing your login function on the line before the call to close the modal.
Try to change this:



kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');


to this:



kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide'); }





share|improve this answer













It seems like you are closing your login function on the line before the call to close the modal.
Try to change this:



kontakteSpeicher.neuerKontakt(kontakt);}
$('#dialog').modal('hide');


to this:



kontakteSpeicher.neuerKontakt(kontakt);
$('#dialog').modal('hide'); }






share|improve this answer












share|improve this answer



share|improve this answer










answered Nov 24 '18 at 12:41









ShushanShushan

1,1171814




1,1171814













  • That worked, thank you

    – Alpinwhitess
    Nov 24 '18 at 12:55



















  • That worked, thank you

    – Alpinwhitess
    Nov 24 '18 at 12:55

















That worked, thank you

– Alpinwhitess
Nov 24 '18 at 12:55





That worked, thank you

– Alpinwhitess
Nov 24 '18 at 12:55


















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53458187%2fmodal-does-not-close-after-clicking-button%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Ottavio Pratesi

Tricia Helfer

15 giugno