Php 7 way to submit forms











up vote
0
down vote

favorite












The following script submits a form. I want a more php 7/cleaner way to do the same exact thing. The functions are being passed in the object oriented User.php file.



How would a senior php developer refactor this code.



index.php



$username = htmlentities(trim($_POST['txt_username']));
$unpass = htmlentities(trim($_POST['txt_password']));
$password = password_hash($unpass, PASSWORD_BCRYPT, ['cost' => 12] );
$unemail = $_POST['txt_email'];
$email = filter_var($unemail, FILTER_VALIDATE_EMAIL);


if (isset($_POST['btn_signup']) ){

if($guest->check_user_exists($username)){
$errors= "Username Already Taken";
}
elseif(strlen($username) < 6){
$errors = "Username must be at least 6 characters";
}
elseif(strlen($unpass) < 6){
$errors = "Password must be at least 6 characters";
}

elseif($guest->check_email_exists($email)){
$errors= "Email Already Taken";
}

elseif($guest->signup($email,$password,$username)){
header("Location:index.php?registered");
die('didnt redirect');
}
else{
$errors= "Invalid Entry";
}


}









share|improve this question


























    up vote
    0
    down vote

    favorite












    The following script submits a form. I want a more php 7/cleaner way to do the same exact thing. The functions are being passed in the object oriented User.php file.



    How would a senior php developer refactor this code.



    index.php



    $username = htmlentities(trim($_POST['txt_username']));
    $unpass = htmlentities(trim($_POST['txt_password']));
    $password = password_hash($unpass, PASSWORD_BCRYPT, ['cost' => 12] );
    $unemail = $_POST['txt_email'];
    $email = filter_var($unemail, FILTER_VALIDATE_EMAIL);


    if (isset($_POST['btn_signup']) ){

    if($guest->check_user_exists($username)){
    $errors= "Username Already Taken";
    }
    elseif(strlen($username) < 6){
    $errors = "Username must be at least 6 characters";
    }
    elseif(strlen($unpass) < 6){
    $errors = "Password must be at least 6 characters";
    }

    elseif($guest->check_email_exists($email)){
    $errors= "Email Already Taken";
    }

    elseif($guest->signup($email,$password,$username)){
    header("Location:index.php?registered");
    die('didnt redirect');
    }
    else{
    $errors= "Invalid Entry";
    }


    }









    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      The following script submits a form. I want a more php 7/cleaner way to do the same exact thing. The functions are being passed in the object oriented User.php file.



      How would a senior php developer refactor this code.



      index.php



      $username = htmlentities(trim($_POST['txt_username']));
      $unpass = htmlentities(trim($_POST['txt_password']));
      $password = password_hash($unpass, PASSWORD_BCRYPT, ['cost' => 12] );
      $unemail = $_POST['txt_email'];
      $email = filter_var($unemail, FILTER_VALIDATE_EMAIL);


      if (isset($_POST['btn_signup']) ){

      if($guest->check_user_exists($username)){
      $errors= "Username Already Taken";
      }
      elseif(strlen($username) < 6){
      $errors = "Username must be at least 6 characters";
      }
      elseif(strlen($unpass) < 6){
      $errors = "Password must be at least 6 characters";
      }

      elseif($guest->check_email_exists($email)){
      $errors= "Email Already Taken";
      }

      elseif($guest->signup($email,$password,$username)){
      header("Location:index.php?registered");
      die('didnt redirect');
      }
      else{
      $errors= "Invalid Entry";
      }


      }









      share|improve this question













      The following script submits a form. I want a more php 7/cleaner way to do the same exact thing. The functions are being passed in the object oriented User.php file.



      How would a senior php developer refactor this code.



      index.php



      $username = htmlentities(trim($_POST['txt_username']));
      $unpass = htmlentities(trim($_POST['txt_password']));
      $password = password_hash($unpass, PASSWORD_BCRYPT, ['cost' => 12] );
      $unemail = $_POST['txt_email'];
      $email = filter_var($unemail, FILTER_VALIDATE_EMAIL);


      if (isset($_POST['btn_signup']) ){

      if($guest->check_user_exists($username)){
      $errors= "Username Already Taken";
      }
      elseif(strlen($username) < 6){
      $errors = "Username must be at least 6 characters";
      }
      elseif(strlen($unpass) < 6){
      $errors = "Password must be at least 6 characters";
      }

      elseif($guest->check_email_exists($email)){
      $errors= "Email Already Taken";
      }

      elseif($guest->signup($email,$password,$username)){
      header("Location:index.php?registered");
      die('didnt redirect');
      }
      else{
      $errors= "Invalid Entry";
      }


      }






      php






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 12 mins ago









      BARNOWL

      1625




      1625



























          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














           

          draft saved


          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208426%2fphp-7-way-to-submit-forms%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown






























          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















           

          draft saved


          draft discarded



















































           


          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f208426%2fphp-7-way-to-submit-forms%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Costa Masnaga

          Fotorealismo

          Sidney Franklin