Why is the difference between two dates returning one extra day?












0















I have the following Instant object



Instant instant = Instant.parse("2018-11-29T00:00:00.00Z");
verify(instant, 5);


And the date today is Nov 24, 2018. I want to write a method that verifies that the instant is 5 days from today. Here is the method:



public void verify(Instant instant, int offsetInDays)
{
LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
LocalDate endDate = LocalDate.from(localDateTime);
LocalDate now = LocalDate.now();
assertEquals(offsetInDays, ChronoUnit.DAYS.between(now, endDate));
}


It should assert that 5 is equal to 5, but ChronoUnit.DAYS.between(now, endDate) is returning 6 days. Why is there an extra day in the comparison? I'm unable to figure out how to do an accurate comparison.










share|improve this question























  • LocalDate.now() is not in UTC time zone, hence the extra day...

    – moilejter
    Nov 25 '18 at 1:02











  • @moilejter I changed it to LocalDate.now(ZoneOffset.UTC) and it still returns 6 days

    – RonApple1996
    Nov 25 '18 at 1:05






  • 1





    Print out the two date values, converted to the same time zone, so you can see what it's comparing?

    – moilejter
    Nov 25 '18 at 1:10











  • Actually @moilejter you were right.. thanks for pointing that out. I ran the test sometime yesterday morning and it worked. But tonight it didnt because UTC time actually makes it Nov 30 1am instead of Nov 29 7pm. adding ZoneOffset.UTC did in fact fix it. Thanks again

    – RonApple1996
    Nov 25 '18 at 1:20
















0















I have the following Instant object



Instant instant = Instant.parse("2018-11-29T00:00:00.00Z");
verify(instant, 5);


And the date today is Nov 24, 2018. I want to write a method that verifies that the instant is 5 days from today. Here is the method:



public void verify(Instant instant, int offsetInDays)
{
LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
LocalDate endDate = LocalDate.from(localDateTime);
LocalDate now = LocalDate.now();
assertEquals(offsetInDays, ChronoUnit.DAYS.between(now, endDate));
}


It should assert that 5 is equal to 5, but ChronoUnit.DAYS.between(now, endDate) is returning 6 days. Why is there an extra day in the comparison? I'm unable to figure out how to do an accurate comparison.










share|improve this question























  • LocalDate.now() is not in UTC time zone, hence the extra day...

    – moilejter
    Nov 25 '18 at 1:02











  • @moilejter I changed it to LocalDate.now(ZoneOffset.UTC) and it still returns 6 days

    – RonApple1996
    Nov 25 '18 at 1:05






  • 1





    Print out the two date values, converted to the same time zone, so you can see what it's comparing?

    – moilejter
    Nov 25 '18 at 1:10











  • Actually @moilejter you were right.. thanks for pointing that out. I ran the test sometime yesterday morning and it worked. But tonight it didnt because UTC time actually makes it Nov 30 1am instead of Nov 29 7pm. adding ZoneOffset.UTC did in fact fix it. Thanks again

    – RonApple1996
    Nov 25 '18 at 1:20














0












0








0








I have the following Instant object



Instant instant = Instant.parse("2018-11-29T00:00:00.00Z");
verify(instant, 5);


And the date today is Nov 24, 2018. I want to write a method that verifies that the instant is 5 days from today. Here is the method:



public void verify(Instant instant, int offsetInDays)
{
LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
LocalDate endDate = LocalDate.from(localDateTime);
LocalDate now = LocalDate.now();
assertEquals(offsetInDays, ChronoUnit.DAYS.between(now, endDate));
}


It should assert that 5 is equal to 5, but ChronoUnit.DAYS.between(now, endDate) is returning 6 days. Why is there an extra day in the comparison? I'm unable to figure out how to do an accurate comparison.










share|improve this question














I have the following Instant object



Instant instant = Instant.parse("2018-11-29T00:00:00.00Z");
verify(instant, 5);


And the date today is Nov 24, 2018. I want to write a method that verifies that the instant is 5 days from today. Here is the method:



public void verify(Instant instant, int offsetInDays)
{
LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
LocalDate endDate = LocalDate.from(localDateTime);
LocalDate now = LocalDate.now();
assertEquals(offsetInDays, ChronoUnit.DAYS.between(now, endDate));
}


It should assert that 5 is equal to 5, but ChronoUnit.DAYS.between(now, endDate) is returning 6 days. Why is there an extra day in the comparison? I'm unable to figure out how to do an accurate comparison.







java






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 25 '18 at 0:51









RonApple1996RonApple1996

877




877













  • LocalDate.now() is not in UTC time zone, hence the extra day...

    – moilejter
    Nov 25 '18 at 1:02











  • @moilejter I changed it to LocalDate.now(ZoneOffset.UTC) and it still returns 6 days

    – RonApple1996
    Nov 25 '18 at 1:05






  • 1





    Print out the two date values, converted to the same time zone, so you can see what it's comparing?

    – moilejter
    Nov 25 '18 at 1:10











  • Actually @moilejter you were right.. thanks for pointing that out. I ran the test sometime yesterday morning and it worked. But tonight it didnt because UTC time actually makes it Nov 30 1am instead of Nov 29 7pm. adding ZoneOffset.UTC did in fact fix it. Thanks again

    – RonApple1996
    Nov 25 '18 at 1:20



















  • LocalDate.now() is not in UTC time zone, hence the extra day...

    – moilejter
    Nov 25 '18 at 1:02











  • @moilejter I changed it to LocalDate.now(ZoneOffset.UTC) and it still returns 6 days

    – RonApple1996
    Nov 25 '18 at 1:05






  • 1





    Print out the two date values, converted to the same time zone, so you can see what it's comparing?

    – moilejter
    Nov 25 '18 at 1:10











  • Actually @moilejter you were right.. thanks for pointing that out. I ran the test sometime yesterday morning and it worked. But tonight it didnt because UTC time actually makes it Nov 30 1am instead of Nov 29 7pm. adding ZoneOffset.UTC did in fact fix it. Thanks again

    – RonApple1996
    Nov 25 '18 at 1:20

















LocalDate.now() is not in UTC time zone, hence the extra day...

– moilejter
Nov 25 '18 at 1:02





LocalDate.now() is not in UTC time zone, hence the extra day...

– moilejter
Nov 25 '18 at 1:02













@moilejter I changed it to LocalDate.now(ZoneOffset.UTC) and it still returns 6 days

– RonApple1996
Nov 25 '18 at 1:05





@moilejter I changed it to LocalDate.now(ZoneOffset.UTC) and it still returns 6 days

– RonApple1996
Nov 25 '18 at 1:05




1




1





Print out the two date values, converted to the same time zone, so you can see what it's comparing?

– moilejter
Nov 25 '18 at 1:10





Print out the two date values, converted to the same time zone, so you can see what it's comparing?

– moilejter
Nov 25 '18 at 1:10













Actually @moilejter you were right.. thanks for pointing that out. I ran the test sometime yesterday morning and it worked. But tonight it didnt because UTC time actually makes it Nov 30 1am instead of Nov 29 7pm. adding ZoneOffset.UTC did in fact fix it. Thanks again

– RonApple1996
Nov 25 '18 at 1:20





Actually @moilejter you were right.. thanks for pointing that out. I ran the test sometime yesterday morning and it worked. But tonight it didnt because UTC time actually makes it Nov 30 1am instead of Nov 29 7pm. adding ZoneOffset.UTC did in fact fix it. Thanks again

– RonApple1996
Nov 25 '18 at 1:20












1 Answer
1






active

oldest

votes


















1














I think you're exposing some conversions that you aren't aware of, by forcing UTC in the first line of verify(), and then converting it to LocalDate. This works regardless of the time zones involved on my machine.



public void verify(Instant instant, int offsetInDays)
{
LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
LocalDateTime endDate = localDateTime.plusDays(offsetInDays);
assertEquals(offsetInDays, ChronoUnit.DAYS.between(localDateTime, endDate));
}





share|improve this answer























    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53463753%2fwhy-is-the-difference-between-two-dates-returning-one-extra-day%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    1














    I think you're exposing some conversions that you aren't aware of, by forcing UTC in the first line of verify(), and then converting it to LocalDate. This works regardless of the time zones involved on my machine.



    public void verify(Instant instant, int offsetInDays)
    {
    LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
    LocalDateTime endDate = localDateTime.plusDays(offsetInDays);
    assertEquals(offsetInDays, ChronoUnit.DAYS.between(localDateTime, endDate));
    }





    share|improve this answer




























      1














      I think you're exposing some conversions that you aren't aware of, by forcing UTC in the first line of verify(), and then converting it to LocalDate. This works regardless of the time zones involved on my machine.



      public void verify(Instant instant, int offsetInDays)
      {
      LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
      LocalDateTime endDate = localDateTime.plusDays(offsetInDays);
      assertEquals(offsetInDays, ChronoUnit.DAYS.between(localDateTime, endDate));
      }





      share|improve this answer


























        1












        1








        1







        I think you're exposing some conversions that you aren't aware of, by forcing UTC in the first line of verify(), and then converting it to LocalDate. This works regardless of the time zones involved on my machine.



        public void verify(Instant instant, int offsetInDays)
        {
        LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
        LocalDateTime endDate = localDateTime.plusDays(offsetInDays);
        assertEquals(offsetInDays, ChronoUnit.DAYS.between(localDateTime, endDate));
        }





        share|improve this answer













        I think you're exposing some conversions that you aren't aware of, by forcing UTC in the first line of verify(), and then converting it to LocalDate. This works regardless of the time zones involved on my machine.



        public void verify(Instant instant, int offsetInDays)
        {
        LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneOffset.UTC);
        LocalDateTime endDate = localDateTime.plusDays(offsetInDays);
        assertEquals(offsetInDays, ChronoUnit.DAYS.between(localDateTime, endDate));
        }






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 25 '18 at 1:11









        gtcompscientistgtcompscientist

        613516




        613516
































            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53463753%2fwhy-is-the-difference-between-two-dates-returning-one-extra-day%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Ottavio Pratesi

            Tricia Helfer

            15 giugno