A One-Pass Hash Table Solution to twoSum












0












$begingroup$


I read the guiding solution to twoSum in leetcodes ;




Approach 3: One-pass Hash Table

It turns out we can do it in one-pass. While we iterate and inserting elements into the table, we also look back to check if current element's complement already exists in the table. If it exists, we have found a solution and return immediately.




and mimic a python solution



class Solution:
def twoSum(self, nums, target) -> List[int]:
"""
:type nums: List[int]
:type target: int
"""
nums_d = {}

for i in range(len(nums)):
complement = target - nums[i]

if nums_d.get(complement) != None: #Check None not True Value
return [i, nums_d.get(complement)]
nums_d[nums[i]] = i #produce a map
return


Unfortunately, my solution is only faster than 81%, which I thought was a best solution.




Runtime: 40 ms, faster than 81.00% of Python3 online submissions for Two Sum.
Memory Usage: 14.3 MB, less than 5.08% of Python3 online submissions for Two Sum.
Next challenges:




How could continue to improve the code, and I am curious about the approaches of the top 20%.










share|improve this question







New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I read the guiding solution to twoSum in leetcodes ;




    Approach 3: One-pass Hash Table

    It turns out we can do it in one-pass. While we iterate and inserting elements into the table, we also look back to check if current element's complement already exists in the table. If it exists, we have found a solution and return immediately.




    and mimic a python solution



    class Solution:
    def twoSum(self, nums, target) -> List[int]:
    """
    :type nums: List[int]
    :type target: int
    """
    nums_d = {}

    for i in range(len(nums)):
    complement = target - nums[i]

    if nums_d.get(complement) != None: #Check None not True Value
    return [i, nums_d.get(complement)]
    nums_d[nums[i]] = i #produce a map
    return


    Unfortunately, my solution is only faster than 81%, which I thought was a best solution.




    Runtime: 40 ms, faster than 81.00% of Python3 online submissions for Two Sum.
    Memory Usage: 14.3 MB, less than 5.08% of Python3 online submissions for Two Sum.
    Next challenges:




    How could continue to improve the code, and I am curious about the approaches of the top 20%.










    share|improve this question







    New contributor




    Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I read the guiding solution to twoSum in leetcodes ;




      Approach 3: One-pass Hash Table

      It turns out we can do it in one-pass. While we iterate and inserting elements into the table, we also look back to check if current element's complement already exists in the table. If it exists, we have found a solution and return immediately.




      and mimic a python solution



      class Solution:
      def twoSum(self, nums, target) -> List[int]:
      """
      :type nums: List[int]
      :type target: int
      """
      nums_d = {}

      for i in range(len(nums)):
      complement = target - nums[i]

      if nums_d.get(complement) != None: #Check None not True Value
      return [i, nums_d.get(complement)]
      nums_d[nums[i]] = i #produce a map
      return


      Unfortunately, my solution is only faster than 81%, which I thought was a best solution.




      Runtime: 40 ms, faster than 81.00% of Python3 online submissions for Two Sum.
      Memory Usage: 14.3 MB, less than 5.08% of Python3 online submissions for Two Sum.
      Next challenges:




      How could continue to improve the code, and I am curious about the approaches of the top 20%.










      share|improve this question







      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I read the guiding solution to twoSum in leetcodes ;




      Approach 3: One-pass Hash Table

      It turns out we can do it in one-pass. While we iterate and inserting elements into the table, we also look back to check if current element's complement already exists in the table. If it exists, we have found a solution and return immediately.




      and mimic a python solution



      class Solution:
      def twoSum(self, nums, target) -> List[int]:
      """
      :type nums: List[int]
      :type target: int
      """
      nums_d = {}

      for i in range(len(nums)):
      complement = target - nums[i]

      if nums_d.get(complement) != None: #Check None not True Value
      return [i, nums_d.get(complement)]
      nums_d[nums[i]] = i #produce a map
      return


      Unfortunately, my solution is only faster than 81%, which I thought was a best solution.




      Runtime: 40 ms, faster than 81.00% of Python3 online submissions for Two Sum.
      Memory Usage: 14.3 MB, less than 5.08% of Python3 online submissions for Two Sum.
      Next challenges:




      How could continue to improve the code, and I am curious about the approaches of the top 20%.







      algorithm python-3.x programming-challenge






      share|improve this question







      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 17 mins ago









      AliceAlice

      1603




      1603




      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Alice is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216025%2fa-one-pass-hash-table-solution-to-twosum%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Alice is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Alice is a new contributor. Be nice, and check out our Code of Conduct.













          Alice is a new contributor. Be nice, and check out our Code of Conduct.












          Alice is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216025%2fa-one-pass-hash-table-solution-to-twosum%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Ottavio Pratesi

          Tricia Helfer

          15 giugno