Translating Python to Rust: reading a Salesforce ID from a string
$begingroup$
As a first project in Rust, I'm translating an existing, working piece of Python code. This code's purpose is to convert a 15-character Salesforce Id (which is guaranteed to be ASCII, exactly 15 bytes of base-62 data) to its 18-character equivalent, which includes a 3-character suffix to discriminate between values differing from one another only in case.
The Rust code works. I am looking for guidance on how to improve its idiomaticity in Rust, particularly around processing this type of data. It's a String conceptually, but doesn't need the overhead of UTF-8 handling, and is likely to be read from (e.g.) CSV files or Web services that do return UTF-8 encoded data.
I also suspect that the way I handle the "accumulator" values suffix and base_two is not proper Rust and welcome education there.
Python
class SalesforceId(object):
def __init__(self, idstr):
if isinstance(idstr, SalesforceId):
self.id = idstr.id
else:
idstr = idstr.strip()
if len(idstr) == 15:
suffix = ''
for i in range(0, 3):
baseTwo = 0
for j in range (0, 5):
character = idstr[i*5+j]
if character >= 'A' and character <= 'Z':
baseTwo += 1 << j
suffix += 'ABCDEFGHIJKLMNOPQRSTUVWXYZ012345'[baseTwo]
self.id = idstr + suffix
elif len(idstr) == 18:
self.id = idstr
else:
raise ValueError('Salesforce Ids must be 15 or 18 characters.')
Rust
#[derive(Debug)]
struct SalesforceId(String);
impl SalesforceId {
fn from_string(s: &str) -> SalesforceId {
let b = s.as_bytes();
match b.len() {
18 => { SalesforceId(s.to_string()) }
15 => {
let mut suffix: [u8; 3] = [b'A', b'A', b'A'];
for i in 0..3 {
let mut base_two = 0;
for j in 0..5 {
let character = b[i*5+j];
if character >= b'A' && character <= b'Z' {
base_two += 1 << j;
}
}
suffix[i] = b'A' + base_two
}
SalesforceId(format!("{}{}", s, std::str::from_utf8(&suffix).unwrap()))
}
_ => panic!("invalid Salesforce Id")
}
}
}
fn main() {
println!("{:?}", SalesforceId::from_string("0063600000aqQ1h"));
}
beginner rust base64
edited 25 mins ago
200_success
130k16153419
asked 40 mins ago
David ReedDavid Reed
1062
New contributor
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
As a first project in Rust, I'm translating an existing, working piece of Python code. This code's purpose is to convert a 15-character Salesforce Id (which is guaranteed to be ASCII, exactly 15 bytes of base-62 data) to its 18-character equivalent, which includes a 3-character suffix to discriminate between values differing from one another only in case.
The Rust code works. I am looking for guidance on how to improve its idiomaticity in Rust, particularly around processing this type of data. It's a String conceptually, but doesn't need the overhead of UTF-8 handling, and is likely to be read from (e.g.) CSV files or Web services that do return UTF-8 encoded data.
I also suspect that the way I handle the "accumulator" values suffix and base_two is not proper Rust and welcome education there.
Python
class SalesforceId(object):
def __init__(self, idstr):
if isinstance(idstr, SalesforceId):
self.id = idstr.id
else:
idstr = idstr.strip()
if len(idstr) == 15:
suffix = ''
for i in range(0, 3):
baseTwo = 0
for j in range (0, 5):
character = idstr[i*5+j]
if character >= 'A' and character <= 'Z':
baseTwo += 1 << j
suffix += 'ABCDEFGHIJKLMNOPQRSTUVWXYZ012345'[baseTwo]
self.id = idstr + suffix
elif len(idstr) == 18:
self.id = idstr
else:
raise ValueError('Salesforce Ids must be 15 or 18 characters.')
Rust
#[derive(Debug)]
struct SalesforceId(String);
impl SalesforceId {
fn from_string(s: &str) -> SalesforceId {
let b = s.as_bytes();
match b.len() {
18 => { SalesforceId(s.to_string()) }
15 => {
let mut suffix: [u8; 3] = [b'A', b'A', b'A'];
for i in 0..3 {
let mut base_two = 0;
for j in 0..5 {
let character = b[i*5+j];
if character >= b'A' && character <= b'Z' {
base_two += 1 << j;
}
}
suffix[i] = b'A' + base_two
}
SalesforceId(format!("{}{}", s, std::str::from_utf8(&suffix).unwrap()))
}
_ => panic!("invalid Salesforce Id")
}
}
}
fn main() {
println!("{:?}", SalesforceId::from_string("0063600000aqQ1h"));
}
beginner rust base64
edited 25 mins ago
200_success
130k16153419
asked 40 mins ago
David ReedDavid Reed
1062
New contributor
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
As a first project in Rust, I'm translating an existing, working piece of Python code. This code's purpose is to convert a 15-character Salesforce Id (which is guaranteed to be ASCII, exactly 15 bytes of base-62 data) to its 18-character equivalent, which includes a 3-character suffix to discriminate between values differing from one another only in case.
The Rust code works. I am looking for guidance on how to improve its idiomaticity in Rust, particularly around processing this type of data. It's a String conceptually, but doesn't need the overhead of UTF-8 handling, and is likely to be read from (e.g.) CSV files or Web services that do return UTF-8 encoded data.
I also suspect that the way I handle the "accumulator" values suffix and base_two is not proper Rust and welcome education there.
Python
class SalesforceId(object):
def __init__(self, idstr):
if isinstance(idstr, SalesforceId):
self.id = idstr.id
else:
idstr = idstr.strip()
if len(idstr) == 15:
suffix = ''
for i in range(0, 3):
baseTwo = 0
for j in range (0, 5):
character = idstr[i*5+j]
if character >= 'A' and character <= 'Z':
baseTwo += 1 << j
suffix += 'ABCDEFGHIJKLMNOPQRSTUVWXYZ012345'[baseTwo]
self.id = idstr + suffix
elif len(idstr) == 18:
self.id = idstr
else:
raise ValueError('Salesforce Ids must be 15 or 18 characters.')
Rust
#[derive(Debug)]
struct SalesforceId(String);
impl SalesforceId {
fn from_string(s: &str) -> SalesforceId {
let b = s.as_bytes();
match b.len() {
18 => { SalesforceId(s.to_string()) }
15 => {
let mut suffix: [u8; 3] = [b'A', b'A', b'A'];
for i in 0..3 {
let mut base_two = 0;
for j in 0..5 {
let character = b[i*5+j];
if character >= b'A' && character <= b'Z' {
base_two += 1 << j;
}
}
suffix[i] = b'A' + base_two
}
SalesforceId(format!("{}{}", s, std::str::from_utf8(&suffix).unwrap()))
}
_ => panic!("invalid Salesforce Id")
}
}
}
fn main() {
println!("{:?}", SalesforceId::from_string("0063600000aqQ1h"));
}
beginner rust base64
edited 25 mins ago
200_success
130k16153419
asked 40 mins ago
David ReedDavid Reed
1062
New contributor
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
As a first project in Rust, I'm translating an existing, working piece of Python code. This code's purpose is to convert a 15-character Salesforce Id (which is guaranteed to be ASCII, exactly 15 bytes of base-62 data) to its 18-character equivalent, which includes a 3-character suffix to discriminate between values differing from one another only in case.
The Rust code works. I am looking for guidance on how to improve its idiomaticity in Rust, particularly around processing this type of data. It's a String conceptually, but doesn't need the overhead of UTF-8 handling, and is likely to be read from (e.g.) CSV files or Web services that do return UTF-8 encoded data.
I also suspect that the way I handle the "accumulator" values suffix and base_two is not proper Rust and welcome education there.
Python
class SalesforceId(object):
def __init__(self, idstr):
if isinstance(idstr, SalesforceId):
self.id = idstr.id
else:
idstr = idstr.strip()
if len(idstr) == 15:
suffix = ''
for i in range(0, 3):
baseTwo = 0
for j in range (0, 5):
character = idstr[i*5+j]
if character >= 'A' and character <= 'Z':
baseTwo += 1 << j
suffix += 'ABCDEFGHIJKLMNOPQRSTUVWXYZ012345'[baseTwo]
self.id = idstr + suffix
elif len(idstr) == 18:
self.id = idstr
else:
raise ValueError('Salesforce Ids must be 15 or 18 characters.')
Rust
#[derive(Debug)]
struct SalesforceId(String);
impl SalesforceId {
fn from_string(s: &str) -> SalesforceId {
let b = s.as_bytes();
match b.len() {
18 => { SalesforceId(s.to_string()) }
15 => {
let mut suffix: [u8; 3] = [b'A', b'A', b'A'];
for i in 0..3 {
let mut base_two = 0;
for j in 0..5 {
let character = b[i*5+j];
if character >= b'A' && character <= b'Z' {
base_two += 1 << j;
}
}
suffix[i] = b'A' + base_two
}
SalesforceId(format!("{}{}", s, std::str::from_utf8(&suffix).unwrap()))
}
_ => panic!("invalid Salesforce Id")
}
}
}
fn main() {
println!("{:?}", SalesforceId::from_string("0063600000aqQ1h"));
}
beginner rust base64
beginner rust base64
edited 25 mins ago
200_success
130k16153419
asked 40 mins ago
David ReedDavid Reed
1062
New contributor
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 25 mins ago
200_success
130k16153419
asked 40 mins ago
David ReedDavid Reed
1062
New contributor
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 25 mins ago
200_success
130k16153419
edited 25 mins ago
200_success
130k16153419
edited 25 mins ago
200_success
130k16153419
130k16153419
asked 40 mins ago
David ReedDavid Reed
1062
New contributor
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 40 mins ago
David ReedDavid Reed
1062
asked 40 mins ago
David ReedDavid Reed
1062
1062
New contributor
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
David Reed is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
David Reed is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215227%2ftranslating-python-to-rust-reading-a-salesforce-id-from-a-string%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
David Reed is a new contributor. Be nice, and check out our Code of Conduct.
David Reed is a new contributor. Be nice, and check out our Code of Conduct.
David Reed is a new contributor. Be nice, and check out our Code of Conduct.
David Reed is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215227%2ftranslating-python-to-rust-reading-a-salesforce-id-from-a-string%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
